respond to comments: do not panic, return invalid/skip instead

timl3136 · timl3136 · commit b321e47d2ec1 · 2025-06-26T13:19:46.000-07:00
diff --git a/internal/compatibility/proto/enum.go b/internal/compatibility/proto/enum.go
@@ -404,5 +404,5 @@ func CronOverlapPolicy(t *shared.CronOverlapPolicy) apiv1.CronOverlapPolicy {
 	case shared.CronOverlapPolicyBufferone:
 		return apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_BUFFER_ONE
 	}
-	panic("unexpected enum value")
+	return apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_INVALID
 }
diff --git a/internal/compatibility/thrift/enum.go b/internal/compatibility/thrift/enum.go
@@ -391,5 +391,5 @@ func CronOverlapPolicy(t apiv1.CronOverlapPolicy) *shared.CronOverlapPolicy {
 	case apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_BUFFER_ONE:
 		return shared.CronOverlapPolicyBufferone.Ptr()
 	}
-	panic("unexpected enum value")
+	return shared.CronOverlapPolicySkipped.Ptr()
 }

Original file line number	Diff line number	Diff line change
`@@ -404,5 +404,5 @@ func CronOverlapPolicy(t *shared.CronOverlapPolicy) apiv1.CronOverlapPolicy {`
`404`	`404`	`case shared.CronOverlapPolicyBufferone:`
`405`	`405`	`return apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_BUFFER_ONE`
`406`	`406`	`}`
`407`		`- panic("unexpected enum value")`
	`407`	`+ return apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_INVALID`
`408`	`408`	`}`
Original file line number	Diff line number	Diff line change
`@@ -391,5 +391,5 @@ func CronOverlapPolicy(t apiv1.CronOverlapPolicy) *shared.CronOverlapPolicy {`
`391`	`391`	`case apiv1.CronOverlapPolicy_CRON_OVERLAP_POLICY_BUFFER_ONE:`
`392`	`392`	`return shared.CronOverlapPolicyBufferone.Ptr()`
`393`	`393`	`}`
`394`		`- panic("unexpected enum value")`
	`394`	`+ return shared.CronOverlapPolicySkipped.Ptr()`
`395`	`395`	`}`