add test for WithActivity

Author: shijiesheng

internal/activity_test.go

@@ -235,7 +235,8 @@ func (s *activityTestSuite) TestGetWorkerStopChannel() {
 	s.NotNil(channel)
 }
 
-func (s *activityTestSuite) TestWithActivityTask() {
+// TestWithActivityTask_EmptyTask empty task should NEVER be passsed this stage. But still adding a test to avoid panics.
+func (s *activityTestSuite) TestWithActivityTask_EmptyTask() {
 	ctx, cancel := context.WithCancel(context.Background())
 	invoker := newServiceInvoker([]byte("task-token"), "identity", s.service, cancel, 5, make(chan struct{}), FeatureFlags{}, s.logger, testWorkflowType, testActivityType)
 	ctx = context.WithValue(ctx, activityEnvContextKey, &activityEnvironment{serviceInvoker: invoker})
@@ -245,12 +246,5 @@ func (s *activityTestSuite) TestWithActivityTask() {
 	newCtx := WithActivityTask(ctx, emptyTask, "task-list", invoker, s.logger, nil, nil, nil, nil, mocktracer.New())
 
 	// assertion
-	activityEnv := newCtx.Value(activityEnvContextKey).(*activityEnvironment)
-	s.Equal(testActivityType, activityEnv.activityType.Name)
-	s.Equal(testWorkflowType, activityEnv.workflowType.Name)
-	s.Equal("task-list", activityEnv.taskList)
-	s.Equal(invoker, activityEnv.serviceInvoker)
-	s.Equal(s.logger, activityEnv.logger)
-	s.Equal(nil, activityEnv.metricsScope)
-	s.Equal(nil, activityEnv.dataConverter)
+	s.NotNil(newCtx)
 }