print history blob as JSON string (#235)

Author: yiminc

common/util/stringer.go

@@ -67,7 +67,9 @@ func valueToString(v reflect.Value) string {
 	case reflect.Invalid:
 		return ""
 	case reflect.Slice:
-		// TODO: find a better way to handle this.
+		if v.Type().Elem().Kind() == reflect.Uint8 {
+			return fmt.Sprintf("[%v]", string(v.Bytes()))
+		}
 		return fmt.Sprintf("[len=%d]", v.Len())
 	default:
 		return fmt.Sprint(v.Interface())

common/util/stringer_test.go

@@ -0,0 +1,42 @@
+// Copyright (c) 2017 Uber Technologies, Inc.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
+package util
+
+import (
+	"reflect"
+	"testing"
+
+	"github.com/stretchr/testify/require"
+)
+
+func Test_byteSliceToString(t *testing.T) {
+	data := []byte("blob-data")
+	v := reflect.ValueOf(data)
+	strVal := valueToString(v)
+
+	require.Equal(t, "[blob-data]", strVal)
+
+	intBlob := []int32{1, 2, 3}
+	v2 := reflect.ValueOf(intBlob)
+	strVal2 := valueToString(v2)
+
+	require.Equal(t, "[len=3]", strVal2)
+}