Improved panic message when MutableSideEffect not found during replay (#656)

algobardo · mfateev · commit c99d7e59f28e · 2019-05-03T15:06:45.000-07:00
diff --git a/internal/internal_event_handlers.go b/internal/internal_event_handlers.go
@@ -569,7 +569,7 @@ func (wc *workflowEnvironmentImpl) MutableSideEffect(id string, f func() interfa
 
 	if wc.isReplay {
 		// This should not happen
-		panic("MutableSideEffect with given ID not found during replay")
+		panic(fmt.Sprintf("Non deterministic workflow code change detected. MutableSideEffect API call doesn't have a correspondent event in the workflow history. MutableSideEffect ID: %s", id))
 	}
 
 	return wc.recordMutableSideEffect(id, wc.encodeValue(f()))

Original file line number	Diff line number	Diff line change
`@@ -569,7 +569,7 @@ func (wc *workflowEnvironmentImpl) MutableSideEffect(id string, f func() interfa`
`569`	`569`
`570`	`570`	`if wc.isReplay {`
`571`	`571`	`// This should not happen`
`572`		`- panic("MutableSideEffect with given ID not found during replay")`
	`572`	`+ panic(fmt.Sprintf("Non deterministic workflow code change detected. MutableSideEffect API call doesn't have a correspondent event in the workflow history. MutableSideEffect ID: %s", id))`
`573`	`573`	`}`
`574`	`574`
`575`	`575`	`return wc.recordMutableSideEffect(id, wc.encodeValue(f()))`