Correctly pass through WorkflowIDReusePolicy on SignalWithStart API (#707)

samarabbas · web-flow · commit d48199573d1a · 2019-05-08T11:21:48.000-07:00
Workflow client implementation does not pass on user specified
WorkflowIDReusePolicy to Cadence server on SignalWithStart API call
resulting in default policy 'WorkflowIDReusePolicyAllowDuplicate'
to be used for all calls.
diff --git a/internal/internal_workflow_client.go b/internal/internal_workflow_client.go
@@ -343,6 +343,7 @@ func (wc *workflowClient) SignalWithStartWorkflow(ctx context.Context, workflowI
 		RetryPolicy:                         convertRetryPolicy(options.RetryPolicy),
 		CronSchedule:                        common.StringPtr(options.CronSchedule),
 		Memo:                                memo,
+		WorkflowIdReusePolicy:               options.WorkflowIDReusePolicy.toThriftPtr(),
 	}
 
 	var response *s.StartWorkflowExecutionResponse

Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,7 @@ func (wc *workflowClient) SignalWithStartWorkflow(ctx context.Context, workflowI`
`343`	`343`	`RetryPolicy: convertRetryPolicy(options.RetryPolicy),`
`344`	`344`	`CronSchedule: common.StringPtr(options.CronSchedule),`
`345`	`345`	`Memo: memo,`
	`346`	`+ WorkflowIdReusePolicy: options.WorkflowIDReusePolicy.toThriftPtr(),`
`346`	`347`	`}`
`347`	`348`
`348`	`349`	`var response *s.StartWorkflowExecutionResponse`