Fix worker option typo (#772)

Author: yycptt

internal/internal_worker.go

@@ -386,7 +386,7 @@ func newSessionWorker(service workflowserviceclient.Interface,
 	params workerExecutionParameters,
 	overrides *workerOverrides,
 	env *hostEnvImpl,
-	maxConCurrentSessionExecutionSize int,
+	maxConcurrentSessionExecutionSize int,
 ) Worker {
 	if params.Identity == "" {
 		params.Identity = getWorkerIdentity(params.TaskList)
@@ -395,7 +395,7 @@ func newSessionWorker(service workflowserviceclient.Interface,
 	if params.SessionResourceID == "" {
 		params.SessionResourceID = uuid.New()
 	}
-	sessionEnvironment := newSessionEnvironment(params.SessionResourceID, maxConCurrentSessionExecutionSize)
+	sessionEnvironment := newSessionEnvironment(params.SessionResourceID, maxConcurrentSessionExecutionSize)
 
 	creationTasklist := getCreationTasklist(params.TaskList)
 	params.UserContext = context.WithValue(params.UserContext, sessionEnvironmentContextKey, sessionEnvironment)
@@ -1200,7 +1200,7 @@ func newAggregatedWorker(
 			workerParams,
 			nil,
 			hostEnv,
-			wOptions.MaxConCurrentSessionExecutionSize,
+			wOptions.MaxConcurrentSessionExecutionSize,
 		)
 	}
 
@@ -1393,8 +1393,8 @@ func augmentWorkerOptions(options WorkerOptions) WorkerOptions {
 	if options.DataConverter == nil {
 		options.DataConverter = getDefaultDataConverter()
 	}
-	if options.MaxConCurrentSessionExecutionSize == 0 {
-		options.MaxConCurrentSessionExecutionSize = defaultMaxConcurrentSessionExecutionSize
+	if options.MaxConcurrentSessionExecutionSize == 0 {
+		options.MaxConcurrentSessionExecutionSize = defaultMaxConcurrentSessionExecutionSize
 	}
 
 	// if the user passes in a tracer then add a tracing context propagator

internal/internal_workflow_testsuite.go

@@ -383,8 +383,8 @@ func (env *testWorkflowEnvironmentImpl) setWorkerOptions(options WorkerOptions)
 	// if options.SessionResourceID != "" {
 	// 	env.workerOptions.SessionResourceID = options.SessionResourceID
 	// }
-	if options.MaxConCurrentSessionExecutionSize != 0 {
-		env.workerOptions.MaxConCurrentSessionExecutionSize = options.MaxConCurrentSessionExecutionSize
+	if options.MaxConcurrentSessionExecutionSize != 0 {
+		env.workerOptions.MaxConcurrentSessionExecutionSize = options.MaxConcurrentSessionExecutionSize
 	}
 	if len(options.ContextPropagators) > 0 {
 		env.workerOptions.ContextPropagators = options.ContextPropagators
@@ -1465,7 +1465,7 @@ func (env *testWorkflowEnvironmentImpl) newTestActivityTaskHandler(taskList stri
 		params.UserContext = context.Background()
 	}
 	if env.sessionEnvironment == nil {
-		env.sessionEnvironment = newTestSessionEnvironment(env, &params, wOptions.MaxConCurrentSessionExecutionSize)
+		env.sessionEnvironment = newTestSessionEnvironment(env, &params, wOptions.MaxConcurrentSessionExecutionSize)
 	}
 	params.UserContext = context.WithValue(params.UserContext, sessionEnvironmentContextKey, env.sessionEnvironment)
 

internal/session.go

@@ -133,7 +133,7 @@ var (
 //     SessionResourceID: The identifier of the resource consumed by sessions.
 //         It's the user's responsibility to ensure there's only one worker using this resourceID.
 //         This option is not available for now as automatic session reestablishing is not implemented.
-//     MaxConCurrentSessionExecutionSize: the maximum number of concurrently sessions the resource
+//     MaxConcurrentSessionExecutionSize: the maximum number of concurrently sessions the resource
 //         support. By default, 1000 is used.
 
 // CreateSession creates a session and returns a new context which contains information
@@ -144,7 +144,7 @@ var (
 //     1. The context passed in already contains a session which is still open
 //        (not closed and failed).
 //     2. All the workers are busy (number of sessions currently running on all the workers have reached
-//        MaxConCurrentSessionExecutionSize, which is specified when starting the workers) and session
+//        MaxConcurrentSessionExecutionSize, which is specified when starting the workers) and session
 //        cannot be created within a specified timeout.
 //
 // If an activity is executed using the returned context, it's regarded as part of the

internal/session_test.go

@@ -279,15 +279,15 @@ func (s *SessionTestSuite) TestRecreation() {
 }
 
 func (s *SessionTestSuite) TestMaxConcurrentSession_CreationOnly() {
-	maxConCurrentSessionExecutionSize := 3
+	maxConcurrentSessionExecutionSize := 3
 	workflowFn := func(ctx Context) error {
 		ao := ActivityOptions{
 			ScheduleToStartTimeout: time.Minute,
 			StartToCloseTimeout:    time.Minute,
 			HeartbeatTimeout:       time.Second * 20,
 		}
 		ctx = WithActivityOptions(ctx, ao)
-		for i := 0; i != maxConCurrentSessionExecutionSize+1; i++ {
+		for i := 0; i != maxConcurrentSessionExecutionSize+1; i++ {
 			if _, err := s.createSessionWithoutRetry(ctx); err != nil {
 				return err
 			}
@@ -298,7 +298,7 @@ func (s *SessionTestSuite) TestMaxConcurrentSession_CreationOnly() {
 	RegisterWorkflow(workflowFn)
 	env := s.NewTestWorkflowEnvironment()
 	env.SetWorkerOptions(WorkerOptions{
-		MaxConCurrentSessionExecutionSize: maxConCurrentSessionExecutionSize,
+		MaxConcurrentSessionExecutionSize: maxConcurrentSessionExecutionSize,
 	})
 	env.ExecuteWorkflow(workflowFn)
 
@@ -307,7 +307,7 @@ func (s *SessionTestSuite) TestMaxConcurrentSession_CreationOnly() {
 }
 
 func (s *SessionTestSuite) TestMaxConcurrentSession_WithRecreation() {
-	maxConCurrentSessionExecutionSize := 3
+	maxConcurrentSessionExecutionSize := 3
 	workflowFn := func(ctx Context) error {
 		ao := ActivityOptions{
 			ScheduleToStartTimeout: time.Minute,
@@ -324,7 +324,7 @@ func (s *SessionTestSuite) TestMaxConcurrentSession_WithRecreation() {
 			return errors.New("Returned session info should not be nil")
 		}
 
-		for i := 0; i != maxConCurrentSessionExecutionSize; i++ {
+		for i := 0; i != maxConcurrentSessionExecutionSize; i++ {
 			if i%2 == 0 {
 				_, err = s.createSessionWithoutRetry(ctx)
 			} else {
@@ -340,7 +340,7 @@ func (s *SessionTestSuite) TestMaxConcurrentSession_WithRecreation() {
 	RegisterWorkflow(workflowFn)
 	env := s.NewTestWorkflowEnvironment()
 	env.SetWorkerOptions(WorkerOptions{
-		MaxConCurrentSessionExecutionSize: maxConCurrentSessionExecutionSize,
+		MaxConcurrentSessionExecutionSize: maxConcurrentSessionExecutionSize,
 	})
 	env.ExecuteWorkflow(workflowFn)
 

internal/worker.go

@@ -206,7 +206,7 @@ type (
 
 		// Optional: Sets the maximum number of concurrently running sessions the resource support.
 		// default: 1000
-		MaxConCurrentSessionExecutionSize int
+		MaxConcurrentSessionExecutionSize int
 
 		// Optional: Sets ContextPropagators that allows users to control the context information passed through a workflow
 		// default: no ContextPropagators

workflow/session.go

@@ -47,7 +47,7 @@ var ErrSessionFailed = internal.ErrSessionFailed
 // Note: Worker should be configured to process session. To do this, set the following
 // fields in WorkerOptions:
 //     EnableSessionWorker: true
-//     MaxConCurrentSessionExecutionSize: the maximum number of concurrently sessions the resource
+//     MaxConcurrentSessionExecutionSize: the maximum number of concurrently sessions the resource
 //         support. By default, 1000 is used.
 
 // CreateSession creates a session and returns a new context which contains information
@@ -58,7 +58,7 @@ var ErrSessionFailed = internal.ErrSessionFailed
 //     1. The context passed in already contains a session which is still open
 //        (not closed and failed).
 //     2. All the workers are busy (number of sessions currently running on all the workers have reached
-//        MaxConCurrentSessionExecutionSize, which is specified when starting the workers) and session
+//        MaxConcurrentSessionExecutionSize, which is specified when starting the workers) and session
 //        cannot be created within a specified timeout.
 //
 // If an activity is executed using the returned context, it's regarded as part of the