add a nil case to ValueFromPtr

3vilhamster · 3vilhamster · commit e209ff6afb8d · 2024-11-11T14:04:58.000+01:00
diff --git a/internal/common/convert_test.go b/internal/common/convert_test.go
@@ -64,6 +64,7 @@ func TestValueFromPtr(t *testing.T) {
 	assert.Equal(t, 1.1, ValueFromPtr(PtrOf(1.1)))
 	assert.Equal(t, true, ValueFromPtr(PtrOf(true)))
 	assert.Equal(t, []string{"a"}, ValueFromPtr(PtrOf([]string{"a"})))
+	assert.Equal(t, "" /* default value */, ValueFromPtr((*string)(nil)))
 }
 
 func TestZero(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ func TestValueFromPtr(t *testing.T) {`
`64`	`64`	`assert.Equal(t, 1.1, ValueFromPtr(PtrOf(1.1)))`
`65`	`65`	`assert.Equal(t, true, ValueFromPtr(PtrOf(true)))`
`66`	`66`	`assert.Equal(t, []string{"a"}, ValueFromPtr(PtrOf([]string{"a"})))`
	`67`	`+ assert.Equal(t, "" /* default value /, ValueFromPtr((string)(nil)))`
`67`	`68`	`}`
`68`	`69`
`69`	`70`	`func TestZero(t *testing.T) {`