fix potential blocking

shijiesheng · shijiesheng · commit f453fb3bf4d7 · 2024-11-27T10:55:44.000-08:00
diff --git a/internal/worker/concurrency.go b/internal/worker/concurrency.go
@@ -24,7 +24,6 @@ import (
 	"context"
 	"fmt"
 	"sync"
-	"time"
 
 	"github.com/marusama/semaphore/v2"
 )
@@ -77,7 +76,7 @@ func (p *permit) AcquireChan(ctx context.Context, wg *sync.WaitGroup) <-chan str
 		}
 		select { // try to send to channel, but don't block if listener is gone
 		case ch <- struct{}{}:
-		case <-time.After(10 * time.Millisecond): // wait time is needed to avoid race condition of channel sending
+		case <-ctx.Done():
 			p.sem.Release(1)
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ import (`
`24`	`24`	`"context"`
`25`	`25`	`"fmt"`
`26`	`26`	`"sync"`
`27`		`- "time"`
`28`	`27`
`29`	`28`	`"github.com/marusama/semaphore/v2"`
`30`	`29`	`)`
`@@ -77,7 +76,7 @@ func (p permit) AcquireChan(ctx context.Context, wg sync.WaitGroup) <-chan str`
`77`	`76`	`}`
`78`	`77`	`select { // try to send to channel, but don't block if listener is gone`
`79`	`78`	`case ch <- struct{}{}:`
`80`		`- case <-time.After(10 * time.Millisecond): // wait time is needed to avoid race condition of channel sending`
	`79`	`+ case <-ctx.Done():`
`81`	`80`	`p.sem.Release(1)`
`82`	`81`	`}`
`83`	`82`	`}()`