Skip to content

Commit f6dc487

Browse files
shijieshengshijiesheng
committed
fix and enforce lint
1 parent 6e22a27 commit f6dc487

27 files changed

+232
-129
lines changed

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ $Q +$(MAKE) --no-print-directory $(addprefix $(BUILD)/,$(1))
252252
endef
253253

254254
.PHONY: build
255-
build: $(BUILD)/fmt ## ensure all packages build
255+
build: $(BUILD)/lint ## ensure all packages build
256256
go build ./...
257257
$Q # caution: some errors are reported on stdout for some reason
258258
go test -exec true ./... >/dev/null

‎internal/compatibility/adapter.go‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ func (a thrift2protoAdapter) RecordActivityTaskHeartbeat(ctx context.Context, re
145145
}
146146

147147
func (a thrift2protoAdapter) RecordActivityTaskHeartbeatByID(ctx context.Context, request *shared.RecordActivityTaskHeartbeatByIDRequest, opts ...yarpc.CallOption) (*shared.RecordActivityTaskHeartbeatResponse, error) {
148-
response, err := a.worker.RecordActivityTaskHeartbeatByID(ctx, proto.RecordActivityTaskHeartbeatByIdRequest(request), opts...)
149-
return thrift.RecordActivityTaskHeartbeatByIdResponse(response), thrift.Error(err)
148+
response, err := a.worker.RecordActivityTaskHeartbeatByID(ctx, proto.RecordActivityTaskHeartbeatByIDRequest(request), opts...)
149+
return thrift.RecordActivityTaskHeartbeatByIDResponse(response), thrift.Error(err)
150150
}
151151

152152
func (a thrift2protoAdapter) RegisterDomain(ctx context.Context, request *shared.RegisterDomainRequest, opts ...yarpc.CallOption) error {
@@ -175,7 +175,7 @@ func (a thrift2protoAdapter) RespondActivityTaskCanceled(ctx context.Context, re
175175
}
176176

177177
func (a thrift2protoAdapter) RespondActivityTaskCanceledByID(ctx context.Context, request *shared.RespondActivityTaskCanceledByIDRequest, opts ...yarpc.CallOption) error {
178-
_, err := a.worker.RespondActivityTaskCanceledByID(ctx, proto.RespondActivityTaskCanceledByIdRequest(request), opts...)
178+
_, err := a.worker.RespondActivityTaskCanceledByID(ctx, proto.RespondActivityTaskCanceledByIDRequest(request), opts...)
179179
return thrift.Error(err)
180180
}
181181

@@ -185,7 +185,7 @@ func (a thrift2protoAdapter) RespondActivityTaskCompleted(ctx context.Context, r
185185
}
186186

187187
func (a thrift2protoAdapter) RespondActivityTaskCompletedByID(ctx context.Context, request *shared.RespondActivityTaskCompletedByIDRequest, opts ...yarpc.CallOption) error {
188-
_, err := a.worker.RespondActivityTaskCompletedByID(ctx, proto.RespondActivityTaskCompletedByIdRequest(request), opts...)
188+
_, err := a.worker.RespondActivityTaskCompletedByID(ctx, proto.RespondActivityTaskCompletedByIDRequest(request), opts...)
189189
return thrift.Error(err)
190190
}
191191

@@ -195,7 +195,7 @@ func (a thrift2protoAdapter) RespondActivityTaskFailed(ctx context.Context, requ
195195
}
196196

197197
func (a thrift2protoAdapter) RespondActivityTaskFailedByID(ctx context.Context, request *shared.RespondActivityTaskFailedByIDRequest, opts ...yarpc.CallOption) error {
198-
_, err := a.worker.RespondActivityTaskFailedByID(ctx, proto.RespondActivityTaskFailedByIdRequest(request), opts...)
198+
_, err := a.worker.RespondActivityTaskFailedByID(ctx, proto.RespondActivityTaskFailedByIDRequest(request), opts...)
199199
return thrift.Error(err)
200200
}
201201

@@ -272,7 +272,7 @@ type domainAPIthriftAdapter struct {
272272
service workflowserviceclient.Interface
273273
}
274274

275-
func NewDomainAPITriftAdapter(thrift workflowserviceclient.Interface) domainAPIthriftAdapter {
275+
func NewDomainAPITriftAdapter(thrift workflowserviceclient.Interface) domainAPIthriftAdapter { //revive:disable-line:unexported-return this is not used at all, consider removing
276276
return domainAPIthriftAdapter{thrift}
277277
}
278278

@@ -301,7 +301,7 @@ type workflowAPIthriftAdapter struct {
301301
service workflowserviceclient.Interface
302302
}
303303

304-
func NewWorkflowAPITriftAdapter(thrift workflowserviceclient.Interface) workflowAPIthriftAdapter {
304+
func NewWorkflowAPITriftAdapter(thrift workflowserviceclient.Interface) workflowAPIthriftAdapter { //revive:disable-line:unexported-return this is not used at all, consider removing
305305
return workflowAPIthriftAdapter{thrift}
306306
}
307307

@@ -362,7 +362,7 @@ type workerAPIthriftAdapter struct {
362362
service workflowserviceclient.Interface
363363
}
364364

365-
func NewWorkerAPITriftAdapter(thrift workflowserviceclient.Interface) workerAPIthriftAdapter {
365+
func NewWorkerAPITriftAdapter(thrift workflowserviceclient.Interface) workerAPIthriftAdapter { //revive:disable-line:unexported-return this is not used at all, consider removing
366366
return workerAPIthriftAdapter{thrift}
367367
}
368368

@@ -387,32 +387,32 @@ func (a workerAPIthriftAdapter) RespondActivityTaskCompleted(ctx context.Context
387387
return &apiv1.RespondActivityTaskCompletedResponse{}, proto.Error(err)
388388
}
389389
func (a workerAPIthriftAdapter) RespondActivityTaskCompletedByID(ctx context.Context, request *apiv1.RespondActivityTaskCompletedByIDRequest, opts ...yarpc.CallOption) (*apiv1.RespondActivityTaskCompletedByIDResponse, error) {
390-
err := a.service.RespondActivityTaskCompletedByID(ctx, thrift.RespondActivityTaskCompletedByIdRequest(request), opts...)
390+
err := a.service.RespondActivityTaskCompletedByID(ctx, thrift.RespondActivityTaskCompletedByIDRequest(request), opts...)
391391
return &apiv1.RespondActivityTaskCompletedByIDResponse{}, proto.Error(err)
392392
}
393393
func (a workerAPIthriftAdapter) RespondActivityTaskFailed(ctx context.Context, request *apiv1.RespondActivityTaskFailedRequest, opts ...yarpc.CallOption) (*apiv1.RespondActivityTaskFailedResponse, error) {
394394
err := a.service.RespondActivityTaskFailed(ctx, thrift.RespondActivityTaskFailedRequest(request), opts...)
395395
return &apiv1.RespondActivityTaskFailedResponse{}, proto.Error(err)
396396
}
397397
func (a workerAPIthriftAdapter) RespondActivityTaskFailedByID(ctx context.Context, request *apiv1.RespondActivityTaskFailedByIDRequest, opts ...yarpc.CallOption) (*apiv1.RespondActivityTaskFailedByIDResponse, error) {
398-
err := a.service.RespondActivityTaskFailedByID(ctx, thrift.RespondActivityTaskFailedByIdRequest(request), opts...)
398+
err := a.service.RespondActivityTaskFailedByID(ctx, thrift.RespondActivityTaskFailedByIDRequest(request), opts...)
399399
return &apiv1.RespondActivityTaskFailedByIDResponse{}, proto.Error(err)
400400
}
401401
func (a workerAPIthriftAdapter) RespondActivityTaskCanceled(ctx context.Context, request *apiv1.RespondActivityTaskCanceledRequest, opts ...yarpc.CallOption) (*apiv1.RespondActivityTaskCanceledResponse, error) {
402402
err := a.service.RespondActivityTaskCanceled(ctx, thrift.RespondActivityTaskCanceledRequest(request), opts...)
403403
return &apiv1.RespondActivityTaskCanceledResponse{}, proto.Error(err)
404404
}
405405
func (a workerAPIthriftAdapter) RespondActivityTaskCanceledByID(ctx context.Context, request *apiv1.RespondActivityTaskCanceledByIDRequest, opts ...yarpc.CallOption) (*apiv1.RespondActivityTaskCanceledByIDResponse, error) {
406-
err := a.service.RespondActivityTaskCanceledByID(ctx, thrift.RespondActivityTaskCanceledByIdRequest(request), opts...)
406+
err := a.service.RespondActivityTaskCanceledByID(ctx, thrift.RespondActivityTaskCanceledByIDRequest(request), opts...)
407407
return &apiv1.RespondActivityTaskCanceledByIDResponse{}, proto.Error(err)
408408
}
409409
func (a workerAPIthriftAdapter) RecordActivityTaskHeartbeat(ctx context.Context, request *apiv1.RecordActivityTaskHeartbeatRequest, opts ...yarpc.CallOption) (*apiv1.RecordActivityTaskHeartbeatResponse, error) {
410410
response, err := a.service.RecordActivityTaskHeartbeat(ctx, thrift.RecordActivityTaskHeartbeatRequest(request), opts...)
411411
return proto.RecordActivityTaskHeartbeatResponse(response), proto.Error(err)
412412
}
413413
func (a workerAPIthriftAdapter) RecordActivityTaskHeartbeatByID(ctx context.Context, request *apiv1.RecordActivityTaskHeartbeatByIDRequest, opts ...yarpc.CallOption) (*apiv1.RecordActivityTaskHeartbeatByIDResponse, error) {
414-
response, err := a.service.RecordActivityTaskHeartbeatByID(ctx, thrift.RecordActivityTaskHeartbeatByIdRequest(request), opts...)
415-
return proto.RecordActivityTaskHeartbeatByIdResponse(response), proto.Error(err)
414+
response, err := a.service.RecordActivityTaskHeartbeatByID(ctx, thrift.RecordActivityTaskHeartbeatByIDRequest(request), opts...)
415+
return proto.RecordActivityTaskHeartbeatByIDResponse(response), proto.Error(err)
416416
}
417417
func (a workerAPIthriftAdapter) RespondQueryTaskCompleted(ctx context.Context, request *apiv1.RespondQueryTaskCompletedRequest, opts ...yarpc.CallOption) (*apiv1.RespondQueryTaskCompletedResponse, error) {
418418
err := a.service.RespondQueryTaskCompleted(ctx, thrift.RespondQueryTaskCompletedRequest(request), opts...)
@@ -427,7 +427,7 @@ type visibilityAPIthriftAdapter struct {
427427
service workflowserviceclient.Interface
428428
}
429429

430-
func NewVisibilityAPITriftAdapter(thrift workflowserviceclient.Interface) visibilityAPIthriftAdapter {
430+
func NewVisibilityAPITriftAdapter(thrift workflowserviceclient.Interface) visibilityAPIthriftAdapter { //revive:disable-line:unexported-return this is not used at all, consider removing
431431
return visibilityAPIthriftAdapter{thrift}
432432
}
433433

‎internal/compatibility/api_test.go‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -384,12 +384,12 @@ func TestQueryWorkflowResponse(t *testing.T) {
384384
}
385385
func TestRecordActivityTaskHeartbeatByIDRequest(t *testing.T) {
386386
for _, item := range []*apiv1.RecordActivityTaskHeartbeatByIDRequest{nil, {}, &testdata.RecordActivityTaskHeartbeatByIDRequest} {
387-
assert.Equal(t, item, proto.RecordActivityTaskHeartbeatByIdRequest(thrift.RecordActivityTaskHeartbeatByIdRequest(item)))
387+
assert.Equal(t, item, proto.RecordActivityTaskHeartbeatByIDRequest(thrift.RecordActivityTaskHeartbeatByIDRequest(item)))
388388
}
389389
}
390390
func TestRecordActivityTaskHeartbeatByIDResponse(t *testing.T) {
391391
for _, item := range []*apiv1.RecordActivityTaskHeartbeatByIDResponse{nil, {}, &testdata.RecordActivityTaskHeartbeatByIDResponse} {
392-
assert.Equal(t, item, proto.RecordActivityTaskHeartbeatByIdResponse(thrift.RecordActivityTaskHeartbeatByIdResponse(item)))
392+
assert.Equal(t, item, proto.RecordActivityTaskHeartbeatByIDResponse(thrift.RecordActivityTaskHeartbeatByIDResponse(item)))
393393
}
394394
}
395395
func TestRecordActivityTaskHeartbeatRequest(t *testing.T) {
@@ -454,7 +454,7 @@ func TestResetWorkflowExecutionResponse(t *testing.T) {
454454
}
455455
func TestRespondActivityTaskCanceledByIDRequest(t *testing.T) {
456456
for _, item := range []*apiv1.RespondActivityTaskCanceledByIDRequest{nil, {}, &testdata.RespondActivityTaskCanceledByIDRequest} {
457-
assert.Equal(t, item, proto.RespondActivityTaskCanceledByIdRequest(thrift.RespondActivityTaskCanceledByIdRequest(item)))
457+
assert.Equal(t, item, proto.RespondActivityTaskCanceledByIDRequest(thrift.RespondActivityTaskCanceledByIDRequest(item)))
458458
}
459459
}
460460
func TestRespondActivityTaskCanceledRequest(t *testing.T) {
@@ -464,7 +464,7 @@ func TestRespondActivityTaskCanceledRequest(t *testing.T) {
464464
}
465465
func TestRespondActivityTaskCompletedByIDRequest(t *testing.T) {
466466
for _, item := range []*apiv1.RespondActivityTaskCompletedByIDRequest{nil, {}, &testdata.RespondActivityTaskCompletedByIDRequest} {
467-
assert.Equal(t, item, proto.RespondActivityTaskCompletedByIdRequest(thrift.RespondActivityTaskCompletedByIdRequest(item)))
467+
assert.Equal(t, item, proto.RespondActivityTaskCompletedByIDRequest(thrift.RespondActivityTaskCompletedByIDRequest(item)))
468468
}
469469
}
470470
func TestRespondActivityTaskCompletedRequest(t *testing.T) {
@@ -474,7 +474,7 @@ func TestRespondActivityTaskCompletedRequest(t *testing.T) {
474474
}
475475
func TestRespondActivityTaskFailedByIDRequest(t *testing.T) {
476476
for _, item := range []*apiv1.RespondActivityTaskFailedByIDRequest{nil, {}, &testdata.RespondActivityTaskFailedByIDRequest} {
477-
assert.Equal(t, item, proto.RespondActivityTaskFailedByIdRequest(thrift.RespondActivityTaskFailedByIdRequest(item)))
477+
assert.Equal(t, item, proto.RespondActivityTaskFailedByIDRequest(thrift.RespondActivityTaskFailedByIDRequest(item)))
478478
}
479479
}
480480
func TestRespondActivityTaskFailedRequest(t *testing.T) {
@@ -589,7 +589,7 @@ func TestSupportedClientVersions(t *testing.T) {
589589
}
590590
func TestTaskIDBlock(t *testing.T) {
591591
for _, item := range []*apiv1.TaskIDBlock{nil, {}, &testdata.TaskIDBlock} {
592-
assert.Equal(t, item, proto.TaskIdBlock(thrift.TaskIdBlock(item)))
592+
assert.Equal(t, item, proto.TaskIDBlock(thrift.TaskIDBlock(item)))
593593
}
594594
}
595595
func TestTaskList(t *testing.T) {
@@ -656,13 +656,13 @@ func TestWorkflowExecution(t *testing.T) {
656656
for _, item := range []*apiv1.WorkflowExecution{nil, {}, &testdata.WorkflowExecution} {
657657
assert.Equal(t, item, proto.WorkflowExecution(thrift.WorkflowExecution(item)))
658658
}
659-
assert.Empty(t, thrift.WorkflowId(nil))
660-
assert.Empty(t, thrift.RunId(nil))
659+
assert.Empty(t, thrift.WorkflowID(nil))
660+
assert.Empty(t, thrift.RunID(nil))
661661
}
662662
func TestExternalExecutionInfo(t *testing.T) {
663663
assert.Nil(t, proto.ExternalExecutionInfo(nil, nil))
664664
assert.Nil(t, thrift.ExternalWorkflowExecution(nil))
665-
assert.Nil(t, thrift.ExternalInitiatedId(nil))
665+
assert.Nil(t, thrift.ExternalInitiatedID(nil))
666666
assert.Panics(t, func() { proto.ExternalExecutionInfo(nil, common.Int64Ptr(testdata.EventID1)) })
667667
assert.Panics(t, func() { proto.ExternalExecutionInfo(thrift.WorkflowExecution(&testdata.WorkflowExecution), nil) })
668668
info := proto.ExternalExecutionInfo(thrift.WorkflowExecution(&testdata.WorkflowExecution), common.Int64Ptr(testdata.EventID1))

‎internal/compatibility/enum_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,8 @@ func TestWorkflowIDReusePolicy(t *testing.T) {
330330
apiv1.WorkflowIdReusePolicy_WORKFLOW_ID_REUSE_POLICY_REJECT_DUPLICATE,
331331
apiv1.WorkflowIdReusePolicy_WORKFLOW_ID_REUSE_POLICY_TERMINATE_IF_RUNNING,
332332
} {
333-
assert.Equal(t, item, proto.WorkflowIdReusePolicy(thrift.WorkflowIdReusePolicy(item)))
333+
assert.Equal(t, item, proto.WorkflowIDReusePolicy(thrift.WorkflowIDReusePolicy(item)))
334334
}
335-
assert.Panics(t, func() { proto.WorkflowIdReusePolicy(shared.WorkflowIdReusePolicy(UnknownValue).Ptr()) })
336-
assert.Panics(t, func() { thrift.WorkflowIdReusePolicy(apiv1.WorkflowIdReusePolicy(UnknownValue)) })
335+
assert.Panics(t, func() { proto.WorkflowIDReusePolicy(shared.WorkflowIdReusePolicy(UnknownValue).Ptr()) })
336+
assert.Panics(t, func() { thrift.WorkflowIDReusePolicy(apiv1.WorkflowIdReusePolicy(UnknownValue)) })
337337
}

‎internal/compatibility/proto/decision.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ func Decision(d *shared.Decision) *apiv1.Decision {
157157
TaskStartToCloseTimeout: secondsToDuration(attr.TaskStartToCloseTimeoutSeconds),
158158
ParentClosePolicy: ParentClosePolicy(attr.ParentClosePolicy),
159159
Control: attr.Control,
160-
WorkflowIdReusePolicy: WorkflowIdReusePolicy(attr.WorkflowIdReusePolicy),
160+
WorkflowIdReusePolicy: WorkflowIDReusePolicy(attr.WorkflowIdReusePolicy),
161161
RetryPolicy: RetryPolicy(attr.RetryPolicy),
162162
CronSchedule: attr.GetCronSchedule(),
163163
Header: Header(attr.Header),

‎internal/compatibility/proto/enum.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func ContinueAsNewInitiator(t *shared.ContinueAsNewInitiator) apiv1.ContinueAsNe
106106
panic("unexpected enum value")
107107
}
108108

109-
func WorkflowIdReusePolicy(t *shared.WorkflowIdReusePolicy) apiv1.WorkflowIdReusePolicy {
109+
func WorkflowIDReusePolicy(t *shared.WorkflowIdReusePolicy) apiv1.WorkflowIdReusePolicy {
110110
if t == nil {
111111
return apiv1.WorkflowIdReusePolicy_WORKFLOW_ID_REUSE_POLICY_INVALID
112112
}

‎internal/compatibility/proto/history.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ func StartChildWorkflowExecutionInitiatedEventAttributes(t *shared.StartChildWor
534534
ParentClosePolicy: ParentClosePolicy(t.ParentClosePolicy),
535535
Control: t.Control,
536536
DecisionTaskCompletedEventId: t.GetDecisionTaskCompletedEventId(),
537-
WorkflowIdReusePolicy: WorkflowIdReusePolicy(t.WorkflowIdReusePolicy),
537+
WorkflowIdReusePolicy: WorkflowIDReusePolicy(t.WorkflowIdReusePolicy),
538538
RetryPolicy: RetryPolicy(t.RetryPolicy),
539539
CronSchedule: t.GetCronSchedule(),
540540
Header: Header(t.Header),

‎internal/compatibility/proto/request.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ func QueryWorkflowRequest(t *shared.QueryWorkflowRequest) *apiv1.QueryWorkflowRe
188188
}
189189
}
190190

191-
func RecordActivityTaskHeartbeatByIdRequest(t *shared.RecordActivityTaskHeartbeatByIDRequest) *apiv1.RecordActivityTaskHeartbeatByIDRequest {
191+
func RecordActivityTaskHeartbeatByIDRequest(t *shared.RecordActivityTaskHeartbeatByIDRequest) *apiv1.RecordActivityTaskHeartbeatByIDRequest {
192192
if t == nil {
193193
return nil
194194
}
@@ -269,7 +269,7 @@ func ResetWorkflowExecutionRequest(t *shared.ResetWorkflowExecutionRequest) *api
269269
}
270270
}
271271

272-
func RespondActivityTaskCanceledByIdRequest(t *shared.RespondActivityTaskCanceledByIDRequest) *apiv1.RespondActivityTaskCanceledByIDRequest {
272+
func RespondActivityTaskCanceledByIDRequest(t *shared.RespondActivityTaskCanceledByIDRequest) *apiv1.RespondActivityTaskCanceledByIDRequest {
273273
if t == nil {
274274
return nil
275275
}
@@ -293,7 +293,7 @@ func RespondActivityTaskCanceledRequest(t *shared.RespondActivityTaskCanceledReq
293293
}
294294
}
295295

296-
func RespondActivityTaskCompletedByIdRequest(t *shared.RespondActivityTaskCompletedByIDRequest) *apiv1.RespondActivityTaskCompletedByIDRequest {
296+
func RespondActivityTaskCompletedByIDRequest(t *shared.RespondActivityTaskCompletedByIDRequest) *apiv1.RespondActivityTaskCompletedByIDRequest {
297297
if t == nil {
298298
return nil
299299
}
@@ -317,7 +317,7 @@ func RespondActivityTaskCompletedRequest(t *shared.RespondActivityTaskCompletedR
317317
}
318318
}
319319

320-
func RespondActivityTaskFailedByIdRequest(t *shared.RespondActivityTaskFailedByIDRequest) *apiv1.RespondActivityTaskFailedByIDRequest {
320+
func RespondActivityTaskFailedByIDRequest(t *shared.RespondActivityTaskFailedByIDRequest) *apiv1.RespondActivityTaskFailedByIDRequest {
321321
if t == nil {
322322
return nil
323323
}
@@ -413,7 +413,7 @@ func SignalWithStartWorkflowExecutionRequest(t *shared.SignalWithStartWorkflowEx
413413
TaskStartToCloseTimeout: secondsToDuration(t.TaskStartToCloseTimeoutSeconds),
414414
Identity: t.GetIdentity(),
415415
RequestId: t.GetRequestId(),
416-
WorkflowIdReusePolicy: WorkflowIdReusePolicy(t.WorkflowIdReusePolicy),
416+
WorkflowIdReusePolicy: WorkflowIDReusePolicy(t.WorkflowIdReusePolicy),
417417
RetryPolicy: RetryPolicy(t.RetryPolicy),
418418
CronSchedule: t.GetCronSchedule(),
419419
Memo: Memo(t.Memo),
@@ -468,7 +468,7 @@ func StartWorkflowExecutionRequest(t *shared.StartWorkflowExecutionRequest) *api
468468
TaskStartToCloseTimeout: secondsToDuration(t.TaskStartToCloseTimeoutSeconds),
469469
Identity: t.GetIdentity(),
470470
RequestId: t.GetRequestId(),
471-
WorkflowIdReusePolicy: WorkflowIdReusePolicy(t.WorkflowIdReusePolicy),
471+
WorkflowIdReusePolicy: WorkflowIDReusePolicy(t.WorkflowIdReusePolicy),
472472
RetryPolicy: RetryPolicy(t.RetryPolicy),
473473
CronSchedule: t.GetCronSchedule(),
474474
Memo: Memo(t.Memo),

‎internal/compatibility/proto/response.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ func QueryWorkflowResponse(t *shared.QueryWorkflowResponse) *apiv1.QueryWorkflow
249249
}
250250
}
251251

252-
func RecordActivityTaskHeartbeatByIdResponse(t *shared.RecordActivityTaskHeartbeatResponse) *apiv1.RecordActivityTaskHeartbeatByIDResponse {
252+
func RecordActivityTaskHeartbeatByIDResponse(t *shared.RecordActivityTaskHeartbeatResponse) *apiv1.RecordActivityTaskHeartbeatByIDResponse {
253253
if t == nil {
254254
return nil
255255
}

‎internal/compatibility/proto/types.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,13 @@ func WorkflowExecution(t *shared.WorkflowExecution) *apiv1.WorkflowExecution {
5858
}
5959
}
6060

61-
func WorkflowRunPair(workflowId, runId string) *apiv1.WorkflowExecution {
62-
if workflowId == "" && runId == "" {
61+
func WorkflowRunPair(workflowID, runID string) *apiv1.WorkflowExecution {
62+
if workflowID == "" && runID == "" {
6363
return nil
6464
}
6565
return &apiv1.WorkflowExecution{
66-
WorkflowId: workflowId,
67-
RunId: runId,
66+
WorkflowId: workflowID,
67+
RunId: runID,
6868
}
6969
}
7070

@@ -374,11 +374,11 @@ func TaskListStatus(t *shared.TaskListStatus) *apiv1.TaskListStatus {
374374
ReadLevel: t.GetReadLevel(),
375375
AckLevel: t.GetAckLevel(),
376376
RatePerSecond: t.GetRatePerSecond(),
377-
TaskIdBlock: TaskIdBlock(t.TaskIDBlock),
377+
TaskIdBlock: TaskIDBlock(t.TaskIDBlock),
378378
}
379379
}
380380

381-
func TaskIdBlock(t *shared.TaskIDBlock) *apiv1.TaskIDBlock {
381+
func TaskIDBlock(t *shared.TaskIDBlock) *apiv1.TaskIDBlock {
382382
if t == nil {
383383
return nil
384384
}

0 commit comments

Comments
 (0)