update idl, fix unit test

timl3136 · timl3136 · commit fa0418d76c7d · 2025-06-25T14:01:57.000-07:00
diff --git a/go.mod b/go.mod
@@ -15,7 +15,7 @@ require (
 	github.com/robfig/cron v1.2.0
 	github.com/stretchr/testify v1.9.0
 	github.com/uber-go/tally v3.3.15+incompatible
-	github.com/uber/cadence-idl v0.0.0-20250604213822-24397860b164
+	github.com/uber/cadence-idl v0.0.0-20250616185004-cc6f52f87bc6
 	github.com/uber/jaeger-client-go v2.22.1+incompatible
 	github.com/uber/tchannel-go v1.32.1
 	go.uber.org/atomic v1.11.0
diff --git a/go.sum b/go.sum
@@ -203,6 +203,8 @@ github.com/uber-go/tally v3.3.15+incompatible h1:9hLSgNBP28CjIaDmAuRTq9qV+UZY+9P
 github.com/uber-go/tally v3.3.15+incompatible/go.mod h1:YDTIBxdXyOU/sCWilKB4bgyufu1cEi0jdVnRdxvjnmU=
 github.com/uber/cadence-idl v0.0.0-20250604213822-24397860b164 h1:Awn9X7dqzz3xH7N5ydEsrFrnlm9/tDW4srT9Sl+PISs=
 github.com/uber/cadence-idl v0.0.0-20250604213822-24397860b164/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
+github.com/uber/cadence-idl v0.0.0-20250616185004-cc6f52f87bc6 h1:YJlEu9Unzifwdn6SuE4rrl4zJ5lop5gBfSX8AyodTww=
+github.com/uber/cadence-idl v0.0.0-20250616185004-cc6f52f87bc6/go.mod h1:oyUK7GCNCRHCCyWyzifSzXpVrRYVBbAMHAzF5dXiKws=
 github.com/uber/jaeger-client-go v2.22.1+incompatible h1:NHcubEkVbahf9t3p75TOCR83gdUHXjRJvjoBh1yACsM=
 github.com/uber/jaeger-client-go v2.22.1+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
 github.com/uber/jaeger-lib v2.2.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
diff --git a/idls b/idls
@@ -1 +1 @@
-Subproject commit 24397860b1644c22d79cb88e05e9c32a6b479293
+Subproject commit cc6f52f87bc6e3b78906f518e3a993bcb88c51b5
diff --git a/internal/common/auth/service_wrapper.go b/internal/common/auth/service_wrapper.go
@@ -511,3 +511,8 @@ func (w *workflowServiceAuthWrapper) RestartWorkflowExecution(ctx context.Contex
 	opts = append(opts, *tokenHeader)
 	return w.service.RestartWorkflowExecution(ctx, request, opts...)
 }
+
+func (w *workflowServiceAuthWrapper) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
+	//TODO implement me
+	return nil
+}
diff --git a/internal/common/isolationgroup/service_wrapper.go b/internal/common/isolationgroup/service_wrapper.go
@@ -311,3 +311,8 @@ func (w *workflowServiceIsolationGroupWrapper) RestartWorkflowExecution(ctx cont
 	opts = append(opts, w.getIsolationGroupIdentifier())
 	return w.service.RestartWorkflowExecution(ctx, request, opts...)
 }
+
+func (w *workflowServiceIsolationGroupWrapper) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
+	//TODO implement me
+	return nil
+}
diff --git a/internal/common/metrics/service_wrapper.go b/internal/common/metrics/service_wrapper.go
@@ -93,6 +93,7 @@ const (
 	scopeRefreshWorkflowTasks                      = CadenceMetricsPrefix + "RefreshWorkflowTasks"
 	scopeNameGetTaskListsByDomain                  = CadenceMetricsPrefix + "GetTaskListsByDomain"
 	scopeRestartWorkflowExecution                  = CadenceMetricsPrefix + "RestartWorkflowExecution"
+	scopeDeleteDomain                              = CadenceMetricsPrefix + "DeleteDomain"
 )
 
 // NewWorkflowServiceWrapper creates a new wrapper to WorkflowService that will emit metrics for each service call.
@@ -444,3 +445,11 @@ func (w *workflowServiceMetricsWrapper) RestartWorkflowExecution(ctx context.Con
 	scope.handleError(err)
 	return resp, err
 }
+
+func (w *workflowServiceMetricsWrapper) DeleteDomain(ctx context.Context, request *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
+	//TODO implement me
+	scope := w.getOperationScope(scopeDeleteDomain)
+	err := w.service.DeleteDomain(ctx, request, opts...)
+	scope.handleError(err)
+	return err
+}
diff --git a/internal/compatibility/adapter.go b/internal/compatibility/adapter.go
@@ -268,6 +268,11 @@ func (a thrift2protoAdapter) RestartWorkflowExecution(ctx context.Context, reque
 	return thrift.RestartWorkflowExecutionResponse(response), proto.Error(err)
 }
 
+func (a thrift2protoAdapter) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
+	//TODO implement me
+	return nil
+}
+
 type domainAPIthriftAdapter struct {
 	service workflowserviceclient.Interface
 }
diff --git a/internal/internal_workflow_client_test.go b/internal/internal_workflow_client_test.go
@@ -2539,6 +2539,7 @@ func TestGetWorkflowStartRequest(t *testing.T) {
 				DecisionTaskStartToCloseTimeout: 5 * time.Second,
 				DelayStart:                      0 * time.Second,
 				JitterStart:                     0 * time.Second,
+				CronOverlapPolicy:               shared.CronOverlapPolicyBufferone,
 			},
 			workflowFunc: func(ctx Context) {},
 			wantRequest: &shared.StartWorkflowExecutionRequest{
@@ -2558,6 +2559,7 @@ func TestGetWorkflowStartRequest(t *testing.T) {
 				CronSchedule:                        common.StringPtr(""),
 				Header:                              &shared.Header{Fields: map[string][]byte{}},
 				WorkflowIdReusePolicy:               shared.WorkflowIdReusePolicyAllowDuplicateFailedOnly.Ptr(),
+				CronOverlapPolicy:                   shared.CronOverlapPolicyBufferone.Ptr(),
 			},
 		},
 		{

Original file line number	Diff line number	Diff line change
`@@ -511,3 +511,8 @@ func (w *workflowServiceAuthWrapper) RestartWorkflowExecution(ctx context.Contex`
`511`	`511`	`opts = append(opts, *tokenHeader)`
`512`	`512`	`return w.service.RestartWorkflowExecution(ctx, request, opts...)`
`513`	`513`	`}`
	`514`	`+`
	`515`	`+func (w workflowServiceAuthWrapper) DeleteDomain(ctx context.Context, DeleteRequest shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {`
	`516`	`+ //TODO implement me`
	`517`	`+ return nil`
	`518`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -311,3 +311,8 @@ func (w *workflowServiceIsolationGroupWrapper) RestartWorkflowExecution(ctx cont`
`311`	`311`	`opts = append(opts, w.getIsolationGroupIdentifier())`
`312`	`312`	`return w.service.RestartWorkflowExecution(ctx, request, opts...)`
`313`	`313`	`}`
	`314`	`+`
	`315`	`+func (w workflowServiceIsolationGroupWrapper) DeleteDomain(ctx context.Context, DeleteRequest shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {`
	`316`	`+ //TODO implement me`
	`317`	`+ return nil`
	`318`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -268,6 +268,11 @@ func (a thrift2protoAdapter) RestartWorkflowExecution(ctx context.Context, reque`
`268`	`268`	`return thrift.RestartWorkflowExecutionResponse(response), proto.Error(err)`
`269`	`269`	`}`
`270`	`270`
	`271`	`+func (a thrift2protoAdapter) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {`
	`272`	`+ //TODO implement me`
	`273`	`+ return nil`
	`274`	`+}`
	`275`	`+`
`271`	`276`	`type domainAPIthriftAdapter struct {`
`272`	`277`	`service workflowserviceclient.Interface`
`273`	`278`	`}`