unit tests

Author: timl3136

internal/common/auth/service_wrapper.go

@@ -513,6 +513,11 @@ func (w *workflowServiceAuthWrapper) RestartWorkflowExecution(ctx context.Contex
 }
 
 func (w *workflowServiceAuthWrapper) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
-	//TODO implement me
-	return nil
+	tokenHeader, err := w.getYarpcJWTHeader()
+	if err != nil {
+		return err
+	}
+	opts = append(opts, *tokenHeader)
+	err = w.service.DeleteDomain(ctx, DeleteRequest, opts...)
+	return err
 }

internal/common/auth/service_wrapper_test.go

@@ -731,3 +731,19 @@ func (s *serviceWrapperSuite) TestGetClusterInfoInvalidToken() {
 	_, err := sw.GetClusterInfo(ctx)
 	s.EqualError(err, "error")
 }
+
+func (s *serviceWrapperSuite) TestDeleteDomainValidToken() {
+	s.Service.EXPECT().DeleteDomain(gomock.Any(), gomock.Any(), gomock.Any()).Times(1)
+	sw := NewWorkflowServiceWrapper(s.Service, s.AuthProvider)
+	ctx, _ := thrift.NewContext(time.Minute)
+	err := sw.DeleteDomain(ctx, &shared.DeleteDomainRequest{})
+	s.NoError(err)
+}
+
+func (s *serviceWrapperSuite) TestDeleteDomainInvalidToken() {
+	s.AuthProvider = newJWTAuthIncorrect()
+	sw := NewWorkflowServiceWrapper(s.Service, s.AuthProvider)
+	ctx, _ := thrift.NewContext(time.Minute)
+	err := sw.DeleteDomain(ctx, &shared.DeleteDomainRequest{})
+	s.EqualError(err, "error")
+}

internal/common/convert_test.go

@@ -49,6 +49,7 @@ func TestPtrHelpers(t *testing.T) {
 	assert.Equal(t, s.QueryTaskCompletedTypeCompleted, *QueryTaskCompletedTypePtr(s.QueryTaskCompletedTypeCompleted))
 	assert.Equal(t, s.TaskListKindNormal, *TaskListKindPtr(s.TaskListKindNormal))
 	assert.Equal(t, s.QueryResultTypeFailed, *QueryResultTypePtr(s.QueryResultTypeFailed))
+	assert.Equal(t, s.CronOverlapPolicyBufferone, *CronOverlapPolicyPtr(s.CronOverlapPolicyBufferone))
 }
 
 func TestCeilHelpers(t *testing.T) {

internal/common/isolationgroup/service_wrapper.go

@@ -313,6 +313,6 @@ func (w *workflowServiceIsolationGroupWrapper) RestartWorkflowExecution(ctx cont
 }
 
 func (w *workflowServiceIsolationGroupWrapper) DeleteDomain(ctx context.Context, DeleteRequest *shared.DeleteDomainRequest, opts ...yarpc.CallOption) error {
-	//TODO implement me
-	return nil
+	opts = append(opts, w.getIsolationGroupIdentifier())
+	return w.service.DeleteDomain(ctx, DeleteRequest, opts...)
 }

internal/common/isolationgroup/service_wrapper_test.go

@@ -398,6 +398,14 @@ func TestAPICalls(t *testing.T) {
 			},
 			expectedResponse: &shared.ClusterInfo{},
 		},
+		"DeleteDomain": {
+			action: func(ctx context.Context, sw workflowserviceclient.Interface) (interface{}, error) {
+				return nil, sw.DeleteDomain(ctx, &shared.DeleteDomainRequest{})
+			},
+			affordance: func(m *workflowservicetest.MockClient) {
+				m.EXPECT().DeleteDomain(gomock.Any(), &shared.DeleteDomainRequest{}, gomock.Any()).Times(1).Return(nil)
+			},
+		},
 	}
 
 	for name, td := range tests {