Skip to content

Commit fcf7c77

Browse files
fix
1 parent 094d4cb commit fcf7c77

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/replaytests/replay_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func TestGreetingsWorkflow(t *testing.T) {
7373
}
7474

7575
// Should have failed but passed. Maybe, because the result recorded in history still matches the return type of the workflow.
76-
// TODO(remove comment): Passes now
76+
// TODO(remove comment): Debug why is this still missed
7777
func TestGreetingsWorkflow3(t *testing.T) {
7878
replayer := worker.NewWorkflowReplayer()
7979
replayer.RegisterActivityWithOptions(getNameActivity3, activity.RegisterOptions{Name: "main.getNameActivity", DisableAlreadyRegisteredCheck: true})
@@ -153,7 +153,8 @@ func TestBranchWorkflowWithExtraBranch(t *testing.T) {
153153
assert.ErrorContains(t, err, "nondeterministic workflow")
154154
}
155155

156-
// ####### my test
156+
// TestSequentialStepsWorkflow replays a history with 2 sequential activity calls and runs it against new version of the workflow code which only calls 1 activity.
157+
// This should be considered as non-determinism error.
157158
func TestSequentialStepsWorkflow(t *testing.T) {
158159
replayer := worker.NewWorkflowReplayer()
159160

0 commit comments

Comments
 (0)