Skip to content

Commit ffdfc41

Browse files
committed
changed metrics to histogram
1 parent b467b01 commit ffdfc41

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

internal/worker/concurrency_auto_scaler.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ const (
5858
metricsPollerWaitTime = "poller-wait-time"
5959
)
6060

61+
var (
62+
metricsPollerQuotaBuckets = tally.MustMakeExponentialValueBuckets(1, 2, 10) // 1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024
63+
metricsPollerWaitTimeBuckets = tally.MustMakeExponentialDurationBuckets(1*time.Millisecond, 2, 14) // 1ms, 2ms, 4ms, 8ms, 16ms, 32ms, 64ms, 128ms, 256ms, 512ms, 1024ms, 2048ms, 4096ms, 8192ms, 16384ms
64+
)
65+
6166
type (
6267
ConcurrencyAutoScaler struct {
6368
shutdownChan chan struct{}
@@ -202,8 +207,8 @@ func (c *ConcurrencyAutoScaler) logEvent(event autoScalerEvent) {
202207
} else {
203208
c.scope.Counter(metricsDisabled).Inc(1)
204209
}
205-
c.scope.Gauge(metricsPollerQuota).Update(float64(c.concurrency.PollerPermit.Quota()))
206-
c.scope.Timer(metricsPollerWaitTime).Record(c.pollerWaitTime.Average())
210+
c.scope.Histogram(metricsPollerQuota, metricsPollerQuotaBuckets).RecordValue(float64(c.concurrency.PollerPermit.Quota()))
211+
c.scope.Histogram(metricsPollerWaitTime, metricsPollerWaitTimeBuckets).RecordDuration(c.pollerWaitTime.Average())
207212
c.log.Debug(autoScalerEventLogMsg,
208213
zap.Time("time", c.clock.Now()),
209214
zap.String("event", string(event)),

0 commit comments

Comments
 (0)