Switched to revive, goimports, re-formatted everything #1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works pretty well! Using latest tools/go.mod versions (except thrift), and using the server's revive.toml for starting out. Revive is a bit noisy due to some `Id` -> `ID` recommendations, but we probably should actually do that for v2.
…ore nicely Somewhat surprisingly, goimports does not have a way to forcefully merge groups into its 3-tier structure. Personally I'd like to do that for consistency, allowing separate groups only if documented. But meh. They're kinda unlikely to degrade, and it doesn't really matter if they do.
davidporter-id-au
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works pretty well!
This is using the latest versions of everything in internal/tools/go.mod (except thrift), and using the server's revive.toml as a base.
Revive is a bit noisy due to some
Id->IDrecommendations, but we probably should actually do that for v2.