Add debugger interface to allow extracting the workerStats from Worker #1363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsiambaku
requested review from
3vilhamster,
Groxx,
demirkayaender,
dkrotx,
jakobht,
shijiesheng and
taylanisikdemir
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dkrotx
approved these changes
Sep 2, 2024
mrombout
pushed a commit
to softsense/cadence-client
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds a debugger interface to the debug package
Why?
Currently the WorkerStats struct is injected in the client by passing it as a worker options however there is no way of retrieving the WorkerStats or its fields from a Worker instance unless we keep track of Trackers instances that were constructed and passed as options seperately. In this PR, we make improvement to the design by adding a debugger interface. The internal worker implementation implements Debugger and allow consumers to retrieve the WorkerStats
How did you test it?
Unit tests
Local Test
Potential risks