Skip to content

Commit 1200cd3

Browse files
committed
switch to VisibleForTesting instead of hacky setAccessible
1 parent 5999bdc commit 1200cd3

File tree

4 files changed

+203
-208
lines changed

4 files changed

+203
-208
lines changed

src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import static com.uber.cadence.worker.NonDeterministicWorkflowPolicy.FailWorkflow;
2121

22+
import com.google.common.annotations.VisibleForTesting;
2223
import com.uber.cadence.EventType;
2324
import com.uber.cadence.GetWorkflowExecutionHistoryRequest;
2425
import com.uber.cadence.GetWorkflowExecutionHistoryResponse;
@@ -634,6 +635,7 @@ private Duration decisionTaskRemainingTime() {
634635
private Iterator<HistoryEvent> current;
635636
private byte[] nextPageToken;
636637

638+
@VisibleForTesting
637639
DecisionTaskWithHistoryIteratorImpl(
638640
PollForDecisionTaskResponse task, Duration decisionTaskStartToCloseTimeout) {
639641
this.task = Objects.requireNonNull(task);

src/main/java/com/uber/cadence/internal/sync/TestActivityEnvironmentInternal.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
package com.uber.cadence.internal.sync;
1919

20+
import com.google.common.annotations.VisibleForTesting;
2021
import com.google.common.base.Defaults;
2122
import com.uber.cadence.*;
2223
import com.uber.cadence.GetTaskListsByDomainRequest;
@@ -133,6 +134,7 @@ private class TestActivityExecutor extends WorkflowInterceptorBase {
133134
@SuppressWarnings("UnusedVariable")
134135
private final IWorkflowService workflowService;
135136

137+
@VisibleForTesting
136138
TestActivityExecutor(IWorkflowService workflowService, WorkflowInterceptorBase next) {
137139
super(next);
138140
this.workflowService = workflowService;
@@ -334,6 +336,7 @@ public CompletableFuture<Boolean> isHealthy() {
334336
return impl.isHealthy();
335337
}
336338

339+
@VisibleForTesting
337340
private WorkflowServiceWrapper(IWorkflowService impl) {
338341
if (impl == null) {
339342
// Create empty implementation that just ignores all requests.

0 commit comments

Comments
 (0)