Skip to content

Commit 1a72d9f

Browse files
authored
make test more stable (#225)
1 parent e0844d1 commit 1a72d9f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/test/java/com/uber/cadence/internal/replay/ReplayDeciderCacheTests.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public void whenHistoryIsPartialCachedEntryIsReturned() throws Exception {
9393
.build();
9494
StatsReporter reporter = mock(StatsReporter.class);
9595
Scope scope =
96-
new RootScopeBuilder().reporter(reporter).reportEvery(Duration.ofMillis(300)).tagged(tags);
96+
new RootScopeBuilder().reporter(reporter).reportEvery(Duration.ofMillis(500)).tagged(tags);
9797

9898
DeciderCache replayDeciderCache = new DeciderCache(10, scope);
9999
TestWorkflowService service = new TestWorkflowService();
@@ -106,14 +106,14 @@ public void whenHistoryIsPartialCachedEntryIsReturned() throws Exception {
106106
assertEquals(decider, replayDeciderCache.getUnchecked(runId));
107107

108108
// Act
109-
decisionTask =
109+
PollForDecisionTaskResponse decisionTask2 =
110110
HistoryUtils.generateDecisionTaskWithPartialHistoryFromExistingTask(
111111
decisionTask, "domain", "stickyTaskList", service);
112-
Decider decider2 = replayDeciderCache.getOrCreate(decisionTask, this::createFakeDecider);
112+
Decider decider2 = replayDeciderCache.getOrCreate(decisionTask2, this::createFakeDecider);
113113

114114
// Assert
115115
// Wait for reporter
116-
Thread.sleep(600);
116+
Thread.sleep(1000);
117117
verify(reporter, times(1)).reportCounter(MetricsType.STICKY_CACHE_HIT, tags, 2);
118118
assertEquals(decider2, replayDeciderCache.getUnchecked(runId));
119119
assertEquals(decider2, decider);

src/test/java/com/uber/cadence/testUtils/HistoryUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ public static PollForDecisionTaskResponse generateDecisionTaskWithPartialHistory
7272
TestWorkflowService service)
7373
throws Exception {
7474

75-
respondDecisionTaskCompletedWithSticky(response.taskToken, stickyTaskListName, service);
7675
signalWorkflow(response.workflowExecution, domain, service);
76+
respondDecisionTaskCompletedWithSticky(response.taskToken, stickyTaskListName, service);
7777
return pollForDecisionTask(domain, createStickyTaskList(stickyTaskListName), service);
7878
}
7979
}

0 commit comments

Comments
 (0)