Skip to content

Commit 317135c

Browse files
Allow using other tags in metric reporter (#648)
1 parent cff6b0f commit 317135c

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

src/main/java/com/uber/cadence/reporter/CadenceClientStatsReporter.java

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.uber.m3.util.Duration;
3030
import io.micrometer.core.instrument.Metrics;
3131
import io.micrometer.core.instrument.Tag;
32+
import java.util.HashMap;
3233
import java.util.Map;
3334
import java.util.concurrent.ConcurrentHashMap;
3435
import java.util.concurrent.TimeUnit;
@@ -98,10 +99,18 @@ public void reportHistogramDurationSamples(
9899
}
99100

100101
private Iterable<Tag> getTags(Map<String, String> tags) {
101-
return ImmutableList.of(
102-
Tag.of(MetricsTag.ACTIVITY_TYPE, Strings.nullToEmpty(tags.get(MetricsTag.ACTIVITY_TYPE))),
103-
Tag.of(MetricsTag.DOMAIN, Strings.nullToEmpty(tags.get(MetricsTag.DOMAIN))),
104-
Tag.of(MetricsTag.TASK_LIST, Strings.nullToEmpty(tags.get(MetricsTag.TASK_LIST))),
105-
Tag.of(MetricsTag.WORKFLOW_TYPE, Strings.nullToEmpty(tags.get(MetricsTag.WORKFLOW_TYPE))));
102+
// TODO: not sure why we have to fill empty values, maybe we can remove them
103+
final HashMap<String, String> tmpMap = new HashMap<>(tags);
104+
tmpMap.put(MetricsTag.ACTIVITY_TYPE, Strings.nullToEmpty(tags.get(MetricsTag.ACTIVITY_TYPE)));
105+
tmpMap.put(MetricsTag.DOMAIN, Strings.nullToEmpty(tags.get(MetricsTag.DOMAIN)));
106+
tmpMap.put(MetricsTag.TASK_LIST, Strings.nullToEmpty(tags.get(MetricsTag.TASK_LIST)));
107+
tmpMap.put(MetricsTag.WORKFLOW_TYPE, Strings.nullToEmpty(tags.get(MetricsTag.WORKFLOW_TYPE)));
108+
109+
final ImmutableList.Builder<Tag> builder = ImmutableList.<Tag>builder();
110+
for (Map.Entry<String, String> entry : tmpMap.entrySet()) {
111+
final Tag tag = Tag.of(entry.getKey(), entry.getValue());
112+
builder.add(tag);
113+
}
114+
return builder.build();
106115
}
107116
}

0 commit comments

Comments
 (0)