Skip to content

Commit 46edfe6

Browse files
committed
remove excess comment
1 parent 1d77cea commit 46edfe6

File tree

3 files changed

+0
-5
lines changed

3 files changed

+0
-5
lines changed

src/main/java/com/uber/cadence/internal/compatibility/proto/DecisionMapper.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ static Decision decision(com.uber.cadence.Decision d) {
194194
if (attr.getCronSchedule() != null) {
195195
builder.setCronSchedule(attr.getCronSchedule());
196196
}
197-
// cronOverlapPolicy not mapped in proto path yet
198197
decision.setContinueAsNewWorkflowExecutionDecisionAttributes(builder);
199198
}
200199
break;
@@ -227,7 +226,6 @@ static Decision decision(com.uber.cadence.Decision d) {
227226
if (attr.getCronSchedule() != null) {
228227
builder.setCronSchedule(attr.getCronSchedule());
229228
}
230-
// cronOverlapPolicy not mapped in proto path yet
231229
decision.setStartChildWorkflowExecutionDecisionAttributes(builder);
232230
}
233231
break;

src/main/java/com/uber/cadence/internal/compatibility/proto/RequestMapper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,6 @@ public static StartWorkflowExecutionRequest startWorkflowExecutionRequest(
545545
if (t.getCronSchedule() != null) {
546546
request.setCronSchedule(t.getCronSchedule());
547547
}
548-
// cronOverlapPolicy not mapped in proto path yet
549548
if (t.getIdentity() != null) {
550549
request.setIdentity(t.getIdentity());
551550
}

src/main/java/com/uber/cadence/internal/external/GenericWorkflowClientExternalImpl.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,6 @@ private StartWorkflowExecutionRequest getStartRequest(
275275
if (!Strings.isNullOrEmpty(startParameters.getCronSchedule())) {
276276
request.setCronSchedule(startParameters.getCronSchedule());
277277
}
278-
// cronOverlapPolicy not supported in thrift request yet
279278
request.setMemo(toMemoThrift(startParameters.getMemo()));
280279
request.setSearchAttributes(toSearchAttributesThrift(startParameters.getSearchAttributes()));
281280
request.setHeader(toHeaderThrift(startParameters.getContext()));
@@ -505,7 +504,6 @@ private SignalWithStartWorkflowExecutionRequest createSignalWithStartRequest(
505504
if (!Strings.isNullOrEmpty(startParameters.getCronSchedule())) {
506505
request.setCronSchedule(startParameters.getCronSchedule());
507506
}
508-
// cronOverlapPolicy not supported in thrift request yet
509507
if (startParameters.getDelayStart() != null) {
510508
request.setDelayStartSeconds((int) startParameters.getDelayStart().getSeconds());
511509
}

0 commit comments

Comments
 (0)