Updated google formater version to 1.5 (#144)

Author: mfateev

build.gradle

@@ -24,7 +24,7 @@ apply plugin: 'maven-publish'
 apply plugin: 'com.github.sherter.google-java-format'
 
 googleJavaFormat {
-    toolVersion '1.3'
+    toolVersion '1.5'
     include '**/*.java'
     exclude '**/generated-sources/*'
 }

src/main/java/com/uber/cadence/converter/JsonDataConverter.java

@@ -242,8 +242,10 @@ public T read(JsonReader jsonReader) throws IOException {
                     gson.getDelegateAdapter(
                         ThrowableTypeAdapterFactory.this, TypeToken.get(classType));
                 StackTraceElement[] stackTrace = parseStackTrace(object);
-                // This is important. Initially I tried configuring ExclusionStrategy to not deserialize the stackTrace field.
-                // But it left it null, which caused Thread.setStackTrace implementation to become silent noop.
+                // This is important. Initially I tried configuring ExclusionStrategy to not
+                // deserialize the stackTrace field.
+                // But it left it null, which caused Thread.setStackTrace implementation to become
+                // silent noop.
                 object.add("stackTrace", new JsonArray());
                 Throwable result = (Throwable) adapter.fromJsonTree(object);
                 result.setStackTrace(stackTrace);

src/main/java/com/uber/cadence/internal/common/WorkflowExecutionUtils.java

@@ -76,13 +76,13 @@
  */
 public class WorkflowExecutionUtils {
 
-
   /**
-   * Indentation for history and decisions pretty printing.
-   * Do not change it from 2 spaces. The gson pretty printer has it hardcoded and changing it
-   * breaks the indentation of exception stack traces.
+   * Indentation for history and decisions pretty printing. Do not change it from 2 spaces. The gson
+   * pretty printer has it hardcoded and changing it breaks the indentation of exception stack
+   * traces.
    */
   private static final String INDENTATION = "  ";
+
   private static RetryOptions retryParameters =
       new RetryOptions.Builder()
           .setBackoffCoefficient(2)
@@ -400,8 +400,10 @@ public static String getFailureCause(HistoryEvent historyEvent) {
                 .getStartChildWorkflowExecutionFailedEventAttributes()
                 .getCause()
                 .toString();
-        //            } else if (historyEvent.getEventType() == EventType.SignalExternalWorkflowExecutionFailed) {
-        //                failureCause = historyEvent.getSignalExternalWorkflowExecutionFailedEventAttributes().getCause();
+        //            } else if (historyEvent.getEventType() ==
+        // EventType.SignalExternalWorkflowExecutionFailed) {
+        //                failureCause =
+        // historyEvent.getSignalExternalWorkflowExecutionFailedEventAttributes().getCause();
       } else {
         failureCause = "Cannot extract failure cause from " + historyEvent.getEventType();
       }

src/main/java/com/uber/cadence/internal/replay/ActivityDecisionContext.java

@@ -92,7 +92,8 @@ Consumer<Exception> scheduleActivityTask(
     attributes.setScheduleToStartTimeoutSeconds(
         (int) parameters.getScheduleToStartTimeoutSeconds());
     attributes.setStartToCloseTimeoutSeconds((int) parameters.getStartToCloseTimeoutSeconds());
-    //        attributes.setTaskPriority(InternalUtils.taskPriorityToString(parameters.getTaskPriority()));
+    //
+    // attributes.setTaskPriority(InternalUtils.taskPriorityToString(parameters.getTaskPriority()));
     String activityId = parameters.getActivityId();
     if (activityId == null) {
       activityId = String.valueOf(decisions.getNextId());
@@ -123,7 +124,8 @@ void handleActivityTaskCanceled(HistoryEvent event) {
       if (scheduled != null) {
         BiConsumer<byte[], Exception> completionHandle = scheduled.getCompletionCallback();
         // It is OK to fail with subclass of CancellationException when cancellation requested.
-        // It allows passing information about cancellation (details in this case) to the surrounding doCatch block
+        // It allows passing information about cancellation (details in this case) to the
+        // surrounding doCatch block
         completionHandle.accept(null, e);
       }
     }

src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java

@@ -348,12 +348,13 @@ private void decideImpl(Functions.Proc query) throws Throwable {
       // Buffer events until the next DecisionTaskStarted and then process them
       // setting current time to the time of DecisionTaskStarted event
       HistoryHelper.EventsIterator eventsIterator = historyHelper.getEvents();
-      // Processes history in batches. One batch per decision. The idea is to push all events to a workflow
-      // before running event loop. This way it can make decisions based on the complete information
-      // instead of a partial one. For example if workflow waits on two activities to proceed and takes
-      // different action if one of them is not ready it would behave differently if both activities
-      // are completed before the event loop or if the event loop runs after every activity event.
-      // Looks ahead to the DecisionTaskStarted event to get current time before calling eventLoop.
+      // Processes history in batches. One batch per decision. The idea is to push all events to a
+      // workflow before running event loop. This way it can make decisions based on the complete
+      // information instead of a partial one. For example if workflow waits on two activities to
+      // proceed and takes different action if one of them is not ready it would behave
+      // differently if both activities are completed before the event loop or if the event loop
+      // runs after every activity event. Looks ahead to the DecisionTaskStarted event to get
+      // current time before calling eventLoop.
       do {
         List<HistoryEvent> decisionCompletionToStartEvents = new ArrayList<>();
         while (eventsIterator.hasNext()) {

src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java

@@ -54,8 +54,8 @@ public DecisionTaskHandler.Result handleDecisionTask(
       return handleDecisionTaskImpl(decisionTaskIterator);
     } catch (Throwable e) {
       PollForDecisionTaskResponse decisionTask = decisionTaskIterator.getDecisionTask();
-      // Only fail decision on first attempt, subsequent failure on the same decision task will timeout.
-      // This is to avoid spin on the failed decision task.
+      // Only fail decision on first attempt, subsequent failure on the same decision task will
+      // timeout. This is to avoid spin on the failed decision task.
       if (decisionTask.getAttempt() > 0) {
         if (e instanceof Error) {
           throw (Error) e;

src/main/java/com/uber/cadence/internal/replay/WorkflowContext.java

@@ -79,17 +79,20 @@ void setContinueAsNewOnCompletion(ContinueAsNewWorkflowExecutionParameters conti
 
   // TODO: Implement as soon as WorkflowExecutionStartedEventAttributes have these fields added.
   ////    WorkflowExecution getParentWorkflowExecution() {
-  //        WorkflowExecutionStartedEventAttributes attributes = getWorkflowStartedEventAttributes();
+  //        WorkflowExecutionStartedEventAttributes attributes =
+  // getWorkflowStartedEventAttributes();
   //        return attributes.getParentWorkflowExecution();
   //    }
 
   ////    com.uber.cadence.ChildPolicy getChildPolicy() {
-  //        WorkflowExecutionStartedEventAttributes attributes = getWorkflowStartedEventAttributes();
+  //        WorkflowExecutionStartedEventAttributes attributes =
+  // getWorkflowStartedEventAttributes();
   //        return ChildPolicy.fromValue(attributes.getChildPolicy());
   //    }
 
   ////    String getContinuedExecutionRunId() {
-  //        WorkflowExecutionStartedEventAttributes attributes = getWorkflowStartedEventAttributes();
+  //        WorkflowExecutionStartedEventAttributes attributes =
+  // getWorkflowStartedEventAttributes();
   //        return attributes.getContinuedExecutionRunId();
   //    }
 

src/main/java/com/uber/cadence/internal/replay/WorkflowDecisionContext.java

@@ -132,7 +132,8 @@ Consumer<Exception> startChildWorkflow(
           (int) parameters.getTaskStartToCloseTimeoutSeconds());
     }
     if (parameters.getChildPolicy() == null) {
-      // TODO: Child policy from a parent as soon as it is available in the WorkflowExecutionStarted event
+      // TODO: Child policy from a parent as soon as it is available in the WorkflowExecutionStarted
+      // event
       // Or when server accepts null
       //            attributes.setChildPolicy(workflowContext.getChildPolicy());
       attributes.setChildPolicy(ChildPolicy.TERMINATE);

src/main/java/com/uber/cadence/internal/sync/ActivityExecutionContextImpl.java

@@ -67,7 +67,7 @@ class ActivityExecutionContextImpl implements ActivityExecutionContext {
    */
   @Override
   public void recordActivityHeartbeat(Object details) throws ActivityCompletionException {
-    //TODO: call service with the specified minimal interval (through @ActivityExecutionOptions)
+    // TODO: call service with the specified minimal interval (through @ActivityExecutionOptions)
     // allowing more frequent calls of this method.
     RecordActivityTaskHeartbeatRequest r = new RecordActivityTaskHeartbeatRequest();
     r.setTaskToken(task.getTaskToken());
@@ -90,7 +90,8 @@ public void recordActivityHeartbeat(Object details) throws ActivityCompletionExc
               + " of Workflow="
               + task.getWorkflowExecution(),
           e);
-      // Not rethrowing to not fail activity implementation on intermittent connection or Cadence errors.
+      // Not rethrowing to not fail activity implementation on intermittent connection or Cadence
+      // errors.
     }
   }
 

src/main/java/com/uber/cadence/internal/sync/SyncDecisionContext.java

@@ -125,7 +125,7 @@ private <T> Promise<T> executeActivityOnce(
   private Promise<byte[]> executeActivityOnce(String name, ActivityOptions options, byte[] input) {
     CompletablePromise<byte[]> result = Workflow.newPromise();
     ExecuteActivityParameters parameters = new ExecuteActivityParameters();
-    //TODO: Real task list
+    // TODO: Real task list
     String taskList = options.getTaskList();
     if (taskList == null) {
       taskList = context.getTaskList();