Skip to content

Commit c8cb440

Browse files
authored
fix nextPageToken in proto request mapper (#734)
1 parent 55205ee commit c8cb440

File tree

1 file changed

+59
-48
lines changed

1 file changed

+59
-48
lines changed

src/main/java/com/uber/cadence/internal/compatibility/proto/RequestMapper.java

Lines changed: 59 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -142,12 +142,15 @@ public static ListArchivedWorkflowExecutionsRequest listArchivedWorkflowExecutio
142142
if (t == null) {
143143
return null;
144144
}
145-
return ListArchivedWorkflowExecutionsRequest.newBuilder()
146-
.setDomain(t.getDomain())
147-
.setPageSize(t.getPageSize())
148-
.setNextPageToken(arrayToByteString(t.getNextPageToken()))
149-
.setQuery(t.getQuery())
150-
.build();
145+
ListArchivedWorkflowExecutionsRequest.Builder request =
146+
ListArchivedWorkflowExecutionsRequest.newBuilder()
147+
.setDomain(t.getDomain())
148+
.setPageSize(t.getPageSize())
149+
.setQuery(t.getQuery());
150+
if (t.getNextPageToken() != null) {
151+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
152+
}
153+
return request.build();
151154
}
152155

153156
public static RequestCancelWorkflowExecutionRequest requestCancelWorkflowExecutionRequest(
@@ -367,12 +370,15 @@ public static ScanWorkflowExecutionsRequest scanWorkflowExecutionsRequest(
367370
if (t == null) {
368371
return null;
369372
}
370-
return ScanWorkflowExecutionsRequest.newBuilder()
371-
.setDomain(t.getDomain())
372-
.setPageSize(t.getPageSize())
373-
.setNextPageToken(arrayToByteString(t.getNextPageToken()))
374-
.setQuery(t.getQuery())
375-
.build();
373+
ScanWorkflowExecutionsRequest.Builder request =
374+
ScanWorkflowExecutionsRequest.newBuilder()
375+
.setDomain(t.getDomain())
376+
.setPageSize(t.getPageSize())
377+
.setQuery(t.getQuery());
378+
if (t.getNextPageToken() != null) {
379+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
380+
}
381+
return request.build();
376382
}
377383

378384
public static DescribeWorkflowExecutionRequest describeWorkflowExecutionRequest(
@@ -552,10 +558,11 @@ public static ListDomainsRequest listDomainsRequest(com.uber.cadence.ListDomains
552558
if (t == null) {
553559
return null;
554560
}
555-
return ListDomainsRequest.newBuilder()
556-
.setPageSize(t.pageSize)
557-
.setNextPageToken(arrayToByteString(t.getNextPageToken()))
558-
.build();
561+
ListDomainsRequest.Builder request = ListDomainsRequest.newBuilder().setPageSize(t.pageSize);
562+
if (t.getNextPageToken() != null) {
563+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
564+
}
565+
return request.build();
559566
}
560567

561568
public static ListTaskListPartitionsRequest listTaskListPartitionsRequest(
@@ -574,12 +581,15 @@ public static ListWorkflowExecutionsRequest listWorkflowExecutionsRequest(
574581
if (t == null) {
575582
return null;
576583
}
577-
return ListWorkflowExecutionsRequest.newBuilder()
578-
.setDomain(t.getDomain())
579-
.setPageSize(t.getPageSize())
580-
.setNextPageToken(arrayToByteString(t.getNextPageToken()))
581-
.setQuery(t.getQuery())
582-
.build();
584+
ListWorkflowExecutionsRequest.Builder request =
585+
ListWorkflowExecutionsRequest.newBuilder()
586+
.setDomain(t.getDomain())
587+
.setPageSize(t.getPageSize())
588+
.setQuery(t.getQuery());
589+
if (t.getNextPageToken() != null) {
590+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
591+
}
592+
return request.build();
583593
}
584594

585595
public static PollForActivityTaskRequest pollForActivityTaskRequest(
@@ -652,9 +662,7 @@ public static RecordActivityTaskHeartbeatRequest recordActivityTaskHeartbeatRequ
652662
return null;
653663
}
654664
RecordActivityTaskHeartbeatRequest.Builder builder =
655-
RecordActivityTaskHeartbeatRequest.newBuilder()
656-
.setTaskToken(arrayToByteString(t.getTaskToken()))
657-
.setDetails(payload(t.getDetails()));
665+
RecordActivityTaskHeartbeatRequest.newBuilder().setDetails(payload(t.getDetails()));
658666
if (t.getTaskToken() != null) {
659667
builder.setTaskToken(arrayToByteString(t.getTaskToken()));
660668
}
@@ -771,47 +779,50 @@ public static UpdateDomainRequest updateDomainRequest(com.uber.cadence.UpdateDom
771779
}
772780

773781
public static ListClosedWorkflowExecutionsRequest listClosedWorkflowExecutionsRequest(
774-
com.uber.cadence.ListClosedWorkflowExecutionsRequest r) {
775-
if (r == null) {
782+
com.uber.cadence.ListClosedWorkflowExecutionsRequest t) {
783+
if (t == null) {
776784
return null;
777785
}
778786
ListClosedWorkflowExecutionsRequest.Builder request =
779787
ListClosedWorkflowExecutionsRequest.newBuilder()
780-
.setDomain(r.getDomain())
781-
.setPageSize(r.getMaximumPageSize())
782-
.setNextPageToken(arrayToByteString(r.getNextPageToken()))
783-
.setStartTimeFilter(startTimeFilter(r.StartTimeFilter));
788+
.setDomain(t.getDomain())
789+
.setPageSize(t.getMaximumPageSize())
790+
.setStartTimeFilter(startTimeFilter(t.StartTimeFilter));
784791

785-
if (r.getExecutionFilter() != null) {
786-
request.setExecutionFilter(workflowExecutionFilter(r.getExecutionFilter()));
792+
if (t.getExecutionFilter() != null) {
793+
request.setExecutionFilter(workflowExecutionFilter(t.getExecutionFilter()));
787794
}
788-
if (r.getTypeFilter() != null) {
789-
request.setTypeFilter(workflowTypeFilter(r.getTypeFilter()));
795+
if (t.getTypeFilter() != null) {
796+
request.setTypeFilter(workflowTypeFilter(t.getTypeFilter()));
790797
}
791-
if (r.getStatusFilter() != null) {
792-
request.setStatusFilter(statusFilter(r.getStatusFilter()));
798+
if (t.getStatusFilter() != null) {
799+
request.setStatusFilter(statusFilter(t.getStatusFilter()));
800+
}
801+
if (t.getNextPageToken() != null) {
802+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
793803
}
794-
795804
return request.build();
796805
}
797806

798807
public static ListOpenWorkflowExecutionsRequest listOpenWorkflowExecutionsRequest(
799-
com.uber.cadence.ListOpenWorkflowExecutionsRequest r) {
800-
if (r == null) {
808+
com.uber.cadence.ListOpenWorkflowExecutionsRequest t) {
809+
if (t == null) {
801810
return null;
802811
}
803812
ListOpenWorkflowExecutionsRequest.Builder request =
804813
ListOpenWorkflowExecutionsRequest.newBuilder()
805-
.setDomain(r.getDomain())
806-
.setPageSize(r.getMaximumPageSize())
807-
.setNextPageToken(arrayToByteString(r.getNextPageToken()))
808-
.setStartTimeFilter(startTimeFilter(r.StartTimeFilter));
814+
.setDomain(t.getDomain())
815+
.setPageSize(t.getMaximumPageSize())
816+
.setStartTimeFilter(startTimeFilter(t.StartTimeFilter));
809817

810-
if (r.getExecutionFilter() != null) {
811-
request.setExecutionFilter(workflowExecutionFilter(r.getExecutionFilter()));
818+
if (t.getExecutionFilter() != null) {
819+
request.setExecutionFilter(workflowExecutionFilter(t.getExecutionFilter()));
812820
}
813-
if (r.getTypeFilter() != null) {
814-
request.setTypeFilter(workflowTypeFilter(r.getTypeFilter()));
821+
if (t.getTypeFilter() != null) {
822+
request.setTypeFilter(workflowTypeFilter(t.getTypeFilter()));
823+
}
824+
if (t.getNextPageToken() != null) {
825+
request.setNextPageToken(arrayToByteString(t.getNextPageToken()));
815826
}
816827

817828
return request.build();

0 commit comments

Comments
 (0)