[BUG] ManualActivityCompletionClientImpl#fail does not set activityId which causes NPE

[arabczuk-equinix]

com.uber.cadence.internal.external.ManualActivityCompletionClientImpl#fail method does not set activityId on the instance of RespondActivityTaskFailedByIDRequest, which causes com.uber.cadence.internal.testservice.ActivityId#ActivityId(java.lang.String, com.uber.cadence.WorkflowExecution, java.lang.String) constructor to throw NullPointerException

[arabczuk-equinix]

any updates on the issue?

[longquanzheng]

I will take a look.

[aauramionak]

Hey, any updates on this?
it just requires setting activityId in 'else' section of fail() method

  public void fail(Throwable failure) {
  ...
      if (activityId == null) {
        throw new IllegalArgumentException("Either activity id or task token are required");
      }
      request.setActivityID(activityId);

[rzarzecki-equinix]

It has been three months now. Any update on the issue?

[natemort]

Fixed in #930