Added unit tests for all samples. (#14)

* Fixes due to API changes. Added Hello[Activity|Query]Test

* Added googleJavaFormat and updated license check in build.gradle

* Reformatted code by google format

* Added reference to internal Uber repo to README

* reformatted unit tests

* Added HelloSignalTest

* Added HelloActivityRetryTest

* Added HelloAsyncTest

* Added HelloAsyncActivityCompletionTest

* Added HelloAsyncLambda

* Added HelloChildTest

* Added HelloPeriodicTest

* Added FileProcessingTest

* Changed failure to a simulated timeout

* testEnv.close in case of unit test failure. Comments

* Comments PR fixes

Author: mfateev

README.md

@@ -1,3 +1,4 @@
+**If you work for Uber** use the internal _cadence-java-client-samples_ repository.
 # Java Cadence Samples
 These samples demonstrate various capabilities of Java Cadence client and server. You can learn more about Cadence at:
 * [Cadence Service](https://github.com/uber/cadence)

build.gradle

@@ -1,9 +1,18 @@
 plugins {
-    id "com.github.hierynomus.license" version "0.14.0"
+    id 'net.minecrell.licenser' version '0.3'
+    id "com.github.sherter.google-java-format" version "0.6"
+    id "net.ltgt.errorprone" version "0.0.13"
 }
 
 apply plugin: 'java'
 apply plugin: 'maven'
+apply plugin: 'com.github.sherter.google-java-format'
+
+googleJavaFormat {
+    toolVersion '1.5'
+    include '**/*.java'
+    exclude '**/generated-sources/*'
+}
 
 group = 'com.uber'
 version = '0.0.1'
@@ -29,6 +38,16 @@ dependencies {
     compile group: 'com.amazonaws', name: 'aws-java-sdk-s3', version: '1.11.274'
     compile group: 'commons-configuration', name: 'commons-configuration', version: '1.9'
     compile group: 'ch.qos.logback', name: 'logback-classic', version: '1.2.3'
+    testCompile group: 'junit', name: 'junit', version: '4.12'
+    testCompile group: 'org.mockito', name: 'mockito-all', version: '1.10.19'
+    testCompile group: 'org.powermock', name: 'powermock-api-mockito', version: '1.7.3'
+}
+
+compileJava {
+    dependsOn 'googleJavaFormat'
+    options.encoding = 'UTF-8'
+    options.compilerArgs << "-Xlint:unchecked" << "-Xlint:deprecation" << "-XepExcludedPaths:" +
+            ".*/generated-sources/.*"
 }
 
 task execute(type: JavaExec) {
@@ -38,7 +57,4 @@ task execute(type: JavaExec) {
 
 license {
     header rootProject.file('license-header.txt')
-    mapping {
-        java = 'SLASHSTAR_STYLE'
-    }
 }

src/main/java/com/uber/cadence/samples/common/QueryWorkflowExecution.java

@@ -14,47 +14,50 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.common;
 
 import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
 
 import com.uber.cadence.WorkflowExecution;
-import com.uber.cadence.client.UntypedWorkflowStub;
 import com.uber.cadence.client.WorkflowClient;
+import com.uber.cadence.client.WorkflowStub;
 import com.uber.cadence.serviceclient.IWorkflowService;
 import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
+import java.util.Optional;
 
 /**
- * Simple example utility to query workflow execution using Cadence query API.
- * Cadence redirects query to any currently running workflow worker for the workflow type
- * of the requested workflow execution.
+ * Queries a workflow execution using the Cadence query API. Cadence redirects a query to any
+ * currently running workflow worker for the workflow type of the requested workflow execution.
  *
  * @author fateev
  */
 public class QueryWorkflowExecution {
-    
-    public static void main(String[] args) throws Exception {
-        if (args.length < 2 || args.length > 3) {
-            System.err.println("Usage: java " + QueryWorkflowExecution.class.getName() +
-                    " <queryType> <workflowId> [<runId>]");
-            System.exit(1);
-        }
-        IWorkflowService cadenceService = new WorkflowServiceTChannel();
-
-        String queryType = args[0];
-
-        WorkflowExecution workflowExecution = new WorkflowExecution();
-        String workflowId = args[1];
-        workflowExecution.setWorkflowId(workflowId);
-        if (args.length == 3) {
-            String runId = args[1];
-            workflowExecution.setRunId(runId);
-        }
-        WorkflowClient client = WorkflowClient.newInstance(cadenceService, DOMAIN);
-        UntypedWorkflowStub workflow = client.newUntypedWorkflowStub(workflowExecution);
-        String result = workflow.query(queryType, String.class);
-
-        System.out.println("Query result for " + workflowExecution + ":");
-        System.out.println(result);
+
+  public static void main(String[] args) throws Exception {
+    if (args.length < 2 || args.length > 3) {
+      System.err.println(
+          "Usage: java "
+              + QueryWorkflowExecution.class.getName()
+              + " <queryType> <workflowId> [<runId>]");
+      System.exit(1);
+    }
+    IWorkflowService cadenceService = new WorkflowServiceTChannel();
+
+    String queryType = args[0];
+
+    WorkflowExecution workflowExecution = new WorkflowExecution();
+    String workflowId = args[1];
+    workflowExecution.setWorkflowId(workflowId);
+    if (args.length == 3) {
+      String runId = args[1];
+      workflowExecution.setRunId(runId);
     }
+    WorkflowClient client = WorkflowClient.newInstance(cadenceService, DOMAIN);
+    WorkflowStub workflow = client.newUntypedWorkflowStub(workflowExecution, Optional.empty());
+    String result = workflow.query(queryType, String.class);
+
+    System.out.println("Query result for " + workflowExecution + ":");
+    System.out.println(result);
+  }
 }

src/main/java/com/uber/cadence/samples/common/QueryWorkflowExecutionLocalReplay.java

@@ -14,6 +14,7 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.common;
 
 import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
@@ -24,36 +25,40 @@
 import com.uber.cadence.worker.Worker;
 
 /**
- * Query workflow execution by getting history from Cadence and executing it on a local worker.
- * Use this approach to debug workflow execution in a local environment.
- * 
+ * Queries a workflow execution by getting a history from the Cadence service and executing it on a
+ * local worker. Use this approach to debug a workflow execution in a local environment.
+ *
  * @author fateev
  */
 public class QueryWorkflowExecutionLocalReplay {
 
-    public static void main(String[] args) throws Exception {
-        if (args.length < 3) {
-            System.err.println("Usage: java " + QueryWorkflowExecutionLocalReplay.class.getName()
-                    + "<workflow implementation class> <workflowId> <runId> <queryType>");
-            System.exit(1);
-        }
-        IWorkflowService cadenceService = new WorkflowServiceTChannel();
+  public static void main(String[] args) throws Exception {
+    if (args.length < 3) {
+      System.err.println(
+          "Usage: java "
+              + QueryWorkflowExecutionLocalReplay.class.getName()
+              + "<workflow implementation class> <workflowId> <runId> <queryType>");
+      System.exit(1);
+    }
+    IWorkflowService cadenceService = new WorkflowServiceTChannel();
 
-        WorkflowExecution workflowExecution = new WorkflowExecution();
-        String workflowId = args[1];
-        workflowExecution.setWorkflowId(workflowId);
-        String runId = args[2];
-        workflowExecution.setRunId(runId);
-        String queryType = args[3];
+    WorkflowExecution workflowExecution = new WorkflowExecution();
+    String workflowId = args[1];
+    workflowExecution.setWorkflowId(workflowId);
+    String runId = args[2];
+    workflowExecution.setRunId(runId);
+    String queryType = args[3];
 
-        String implementationTypeName = args[0];
-        @SuppressWarnings("unchecked")
-        Class<Object> workflowImplementationType = (Class<Object>) Class.forName(implementationTypeName);
-        Worker replayer = new Worker(cadenceService, DOMAIN, null, null);
-        replayer.registerWorkflowImplementationTypes(workflowImplementationType);
-        System.out.println("Beginning query replay for " + workflowExecution);
-        String queryResult = replayer.queryWorkflowExecution(workflowExecution, queryType, String.class);
-        System.out.println("Done query replay for " + workflowExecution);
-        System.out.println("Query result:\n" + queryResult);
-    }
+    String implementationTypeName = args[0];
+    @SuppressWarnings("unchecked")
+    Class<Object> workflowImplementationType =
+        (Class<Object>) Class.forName(implementationTypeName);
+    Worker replayer = new Worker(cadenceService, DOMAIN, null, null);
+    replayer.registerWorkflowImplementationTypes(workflowImplementationType);
+    System.out.println("Beginning query replay for " + workflowExecution);
+    String queryResult =
+        replayer.queryWorkflowExecution(workflowExecution, queryType, String.class);
+    System.out.println("Done query replay for " + workflowExecution);
+    System.out.println("Query result:\n" + queryResult);
+  }
 }

src/main/java/com/uber/cadence/samples/common/RegisterDomain.java

@@ -14,6 +14,7 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.common;
 
 import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
@@ -26,26 +27,30 @@
 import org.apache.thrift.TException;
 
 /**
- * Simple example utility to pretty print workflow execution history.
+ * Registers the "sample" domain with the Cadence service.
  *
  * @author fateev
  */
 public class RegisterDomain {
 
-    public static void main(String[] args) throws TException, IOException {
-        IWorkflowService cadenceService = new WorkflowServiceTChannel();
-        RegisterDomainRequest request = new RegisterDomainRequest();
-        request.setDescription("Java Samples");
-        request.setEmitMetric(false);
-        request.setName(DOMAIN);
-        int retentionPeriodInDays = 1;
-        request.setWorkflowExecutionRetentionPeriodInDays(retentionPeriodInDays);
-        try {
-            cadenceService.RegisterDomain(request);
-            System.out.println("Successfully registered domain \"" + DOMAIN + "\" with retentionDays=" + retentionPeriodInDays);
-        } catch (DomainAlreadyExistsError e) {
-            System.out.println("Domain \"" + DOMAIN + "\" is already registered");
-        }
-        System.exit(0);
+  public static void main(String[] args) throws TException, IOException {
+    IWorkflowService cadenceService = new WorkflowServiceTChannel();
+    RegisterDomainRequest request = new RegisterDomainRequest();
+    request.setDescription("Java Samples");
+    request.setEmitMetric(false);
+    request.setName(DOMAIN);
+    int retentionPeriodInDays = 1;
+    request.setWorkflowExecutionRetentionPeriodInDays(retentionPeriodInDays);
+    try {
+      cadenceService.RegisterDomain(request);
+      System.out.println(
+          "Successfully registered domain \""
+              + DOMAIN
+              + "\" with retentionDays="
+              + retentionPeriodInDays);
+    } catch (DomainAlreadyExistsError e) {
+      System.out.println("Domain \"" + DOMAIN + "\" is already registered");
     }
+    System.exit(0);
+  }
 }

src/main/java/com/uber/cadence/samples/common/SampleConstants.java

@@ -14,8 +14,9 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.common;
 
 public class SampleConstants {
-    public static final String DOMAIN = "sample";
+  public static final String DOMAIN = "sample";
 }

src/main/java/com/uber/cadence/samples/common/WorkflowExecutionHistoryPrinter.java

@@ -14,6 +14,7 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.common;
 
 import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
@@ -24,23 +25,27 @@
 import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
 
 /**
- * Simple example utility to pretty print workflow execution history.
+ * Prints a workflow execution history to the console.
  *
  * @author fateev
  */
 public class WorkflowExecutionHistoryPrinter {
 
-    public static void main(String[] args) throws Exception {
-        if (args.length < 2) {
-            System.err.println("Usage: java " + WorkflowExecutionHistoryPrinter.class.getName() + " <workflowId> <runId>");
-            System.exit(1);
-        }
-        IWorkflowService cadenceService = new WorkflowServiceTChannel();
-        WorkflowExecution workflowExecution = new WorkflowExecution();
-        String workflowId = args[0];
-        workflowExecution.setWorkflowId(workflowId);
-        String runId = args[1];
-        workflowExecution.setRunId(runId);
-        System.out.println(WorkflowExecutionUtils.prettyPrintHistory(cadenceService, DOMAIN, workflowExecution, true));
+  public static void main(String[] args) throws Exception {
+    if (args.length < 2) {
+      System.err.println(
+          "Usage: java "
+              + WorkflowExecutionHistoryPrinter.class.getName()
+              + " <workflowId> <runId>");
+      System.exit(1);
     }
+    IWorkflowService cadenceService = new WorkflowServiceTChannel();
+    WorkflowExecution workflowExecution = new WorkflowExecution();
+    String workflowId = args[0];
+    workflowExecution.setWorkflowId(workflowId);
+    String runId = args[1];
+    workflowExecution.setRunId(runId);
+    System.out.println(
+        WorkflowExecutionUtils.prettyPrintHistory(cadenceService, DOMAIN, workflowExecution, true));
+  }
 }

src/main/java/com/uber/cadence/samples/fileprocessing/FileProcessingStarter.java

@@ -14,38 +14,38 @@
  *  express or implied. See the License for the specific language governing
  *  permissions and limitations under the License.
  */
+
 package com.uber.cadence.samples.fileprocessing;
 
 import static com.uber.cadence.samples.common.SampleConstants.DOMAIN;
 
 import com.uber.cadence.client.WorkflowClient;
 import java.net.URL;
 
-/**
- * This is used for launching a Workflow instance of file processing sample.
- */
+/** Starts a file processing sample workflow. */
 public class FileProcessingStarter {
 
-    public static void main(String[] args) throws Exception {
-        // Start Workflow instance
-        WorkflowClient workflowClient = WorkflowClient.newInstance(DOMAIN);
-        FileProcessingWorkflow workflow = workflowClient.newWorkflowStub(FileProcessingWorkflow.class);
-
-        System.out.println("Executing FileProcessingWorkflow");
-
-        URL source = new URL("http://www.google.com/");
-        URL destination = new URL("http://dummy");
-
-        // This is going to block until the workflow completion.
-        // This is rarely used in production. Use the commented code below for async start version.
-        workflow.processFile(source, destination);
-        System.out.println("FileProcessingWorkflow completed");
-
-        // Use this code instead of the above blocking call to start workflow asynchronously.
-//        WorkflowExecution workflowExecution = WorkflowClient.start(workflow::processFile, source, destination);
-//        System.out.println("Started periodic workflow with workflowId=\"" + workflowExecution.getWorkflowId()
-//                + "\" and runId=\"" + workflowExecution.getRunId() + "\"");
-//
-        System.exit(0);
-    }
+  public static void main(String[] args) throws Exception {
+    WorkflowClient workflowClient = WorkflowClient.newInstance(DOMAIN);
+    FileProcessingWorkflow workflow = workflowClient.newWorkflowStub(FileProcessingWorkflow.class);
+
+    System.out.println("Executing FileProcessingWorkflow");
+
+    URL source = new URL("http://www.google.com/");
+    URL destination = new URL("http://dummy");
+
+    // This is going to block until the workflow completes.
+    // This is rarely used in production. Use the commented code below for async start version.
+    workflow.processFile(source, destination);
+    System.out.println("FileProcessingWorkflow completed");
+
+    // Use this code instead of the above blocking call to start workflow asynchronously.
+    //        WorkflowExecution workflowExecution = WorkflowClient.start(workflow::processFile,
+    // source, destination);
+    //        System.out.println("Started periodic workflow with workflowId=\"" +
+    // workflowExecution.getWorkflowId()
+    //                + "\" and runId=\"" + workflowExecution.getRunId() + "\"");
+    //
+    System.exit(0);
+  }
 }