remove historyHelper

Signed-off-by: Tim Li <[email protected]>

Author: timl3136

cadence/_internal/workflow/decision_events_iterator.py

@@ -240,56 +240,6 @@ async def __anext__(self) -> DecisionEvents:
         return await self.next_decision_events()
 
 
-class HistoryHelper:
-    """
-    Main helper class for processing workflow history events.
-    
-    Provides the primary interface for iterating through decision events
-    and managing workflow history processing.
-    """
-    
-    def __init__(self, decision_task: PollForDecisionTaskResponse, client: Client):
-        self._decision_task = decision_task
-        self._client = client
-        self._decision_events_iterator: Optional[DecisionEventsIterator] = None
-    
-    async def get_decision_events_iterator(self) -> DecisionEventsIterator:
-        """Get the decision events iterator for this history."""
-        if self._decision_events_iterator is None:
-            self._decision_events_iterator = DecisionEventsIterator(
-                self._decision_task, self._client
-            )
-            await self._decision_events_iterator._ensure_initialized()
-        
-        return self._decision_events_iterator
-    
-    async def get_all_decision_events(self) -> List[DecisionEvents]:
-        """Get all decision events as a list."""
-        iterator = await self.get_decision_events_iterator()
-        all_decision_events = []
-        
-        while await iterator.has_next_decision_events():
-            decision_events = await iterator.next_decision_events()
-            all_decision_events.append(decision_events)
-        
-        return all_decision_events
-    
-    def get_workflow_execution(self):
-        """Get the workflow execution from the decision task."""
-        return self._decision_task.workflow_execution
-    
-    def get_workflow_type(self):
-        """Get the workflow type from the decision task."""
-        return self._decision_task.workflow_type
-
-
-# Factory function for easy creation
-async def create_history_helper(
-    decision_task: PollForDecisionTaskResponse, 
-    client: Client
-) -> HistoryHelper:
-    """Create a HistoryHelper instance."""
-    return HistoryHelper(decision_task, client)
 
 
 # Utility functions

tests/cadence/_internal/workflow/test_decision_events_iterator.py

@@ -17,7 +17,6 @@
 from cadence._internal.workflow.decision_events_iterator import (
     DecisionEvents,
     DecisionEventsIterator,
-    HistoryHelper,
     is_decision_event,
     is_marker_event,
     extract_event_timestamp_millis
@@ -247,42 +246,6 @@ async def test_iterator_protocol(self, mock_client):
         assert len(decision_events_list) == 2
 
 
-class TestHistoryHelper:
-    """Test the HistoryHelper class."""
-    
-    @pytest.mark.asyncio
-    async def test_history_helper_creation(self, mock_client):
-        """Test HistoryHelper creation and basic functionality."""
-        events = [
-            create_mock_history_event(1, "decision_task_started"),
-            create_mock_history_event(2, "decision_task_completed")
-        ]
-        
-        decision_task = create_mock_decision_task(events)
-        helper = HistoryHelper(decision_task, mock_client)
-        
-        assert helper.get_workflow_execution() == decision_task.workflow_execution
-        assert helper.get_workflow_type() == decision_task.workflow_type
-    
-    @pytest.mark.asyncio
-    async def test_get_all_decision_events(self, mock_client):
-        """Test getting all decision events as a list."""
-        events = [
-            create_mock_history_event(1, "decision_task_started"),
-            create_mock_history_event(2, "decision_task_completed"),
-            create_mock_history_event(3, "decision_task_started"),
-            create_mock_history_event(4, "decision_task_completed")
-        ]
-        
-        decision_task = create_mock_decision_task(events)
-        helper = HistoryHelper(decision_task, mock_client)
-        
-        all_decision_events = await helper.get_all_decision_events()
-        
-        assert len(all_decision_events) == 2
-        for decision_events in all_decision_events:
-            assert isinstance(decision_events, DecisionEvents)
-            assert len(decision_events.get_events()) == 2
 
 
 class TestUtilityFunctions:
@@ -360,9 +323,11 @@ async def test_complex_workflow_scenario(self, mock_client):
         ]
 
         decision_task = create_mock_decision_task(events)
-        helper = HistoryHelper(decision_task, mock_client)
+        iterator = DecisionEventsIterator(decision_task, mock_client)
 
-        all_decisions = await helper.get_all_decision_events()
+        all_decisions = []
+        async for decision_events in iterator:
+            all_decisions.append(decision_events)
 
         assert len(all_decisions) == 2