lint

Signed-off-by: Tim Li <[email protected]>

Author: timl3136

cadence/_internal/workflow/workflow_engine.py

@@ -1,4 +1,5 @@
 from dataclasses import dataclass
+from typing import Optional, Callable, Any
 
 from cadence._internal.workflow.context import Context
 from cadence.api.v1.decision_pb2 import Decision
@@ -10,12 +11,15 @@
 @dataclass
 class DecisionResult:
     decisions: list[Decision]
+    force_create_new_decision_task: bool = False
+    query_results: Optional[dict] = None
 
 class WorkflowEngine:
-    def __init__(self, info: WorkflowInfo, client: Client):
+    def __init__(self, info: WorkflowInfo, client: Client, workflow_func: Optional[Callable[..., Any]] = None):
         self._context = Context(client, info)
+        self._workflow_func = workflow_func
 
     # TODO: Implement this
-    def process_decision(self, decision_task: PollForDecisionTaskResponse) -> DecisionResult:
+    async def process_decision(self, decision_task: PollForDecisionTaskResponse) -> DecisionResult:
         with self._context._activate():
             return DecisionResult(decisions=[])

cadence/worker/_base_task_handler.py

@@ -1,6 +1,6 @@
 import logging
 from abc import ABC, abstractmethod
-from typing import TypeVar, Generic
+from typing import Any, Dict, TypeVar, Generic
 
 logger = logging.getLogger(__name__)
 

cadence/worker/_decision_task_handler.py

@@ -1,5 +1,5 @@
 import logging
-from typing import Dict, Any
+from typing import Dict
 
 from cadence.api.v1.common_pb2 import Payload
 from cadence.api.v1.service_worker_pb2 import (

tests/cadence/worker/test_base_task_handler.py

@@ -4,8 +4,7 @@
 """
 
 import pytest
-from unittest.mock import Mock, AsyncMock, patch
-from typing import Any
+from unittest.mock import Mock
 
 from cadence.worker._base_task_handler import BaseTaskHandler
 

tests/cadence/worker/test_decision_task_handler.py

@@ -5,20 +5,17 @@
 
 import pytest
 from unittest.mock import Mock, AsyncMock, patch, PropertyMock
-from typing import Dict, Any
 
 from cadence.api.v1.common_pb2 import Payload
 from cadence.api.v1.service_worker_pb2 import (
     PollForDecisionTaskResponse,
-    RespondDecisionTaskCompletedRequest,
-    RespondDecisionTaskFailedRequest
+    RespondDecisionTaskCompletedRequest
 )
 from cadence.api.v1.workflow_pb2 import DecisionTaskFailedCause
 from cadence.api.v1.decision_pb2 import Decision
 from cadence.client import Client
 from cadence.worker._decision_task_handler import DecisionTaskHandler
 from cadence.worker._registry import Registry
-from cadence.workflow import WorkflowInfo
 from cadence._internal.workflow.workflow_engine import WorkflowEngine, DecisionResult
 
 
@@ -268,8 +265,8 @@ async def test_respond_decision_task_completed_success(self, handler, sample_dec
         assert isinstance(call_args, RespondDecisionTaskCompletedRequest)
         assert call_args.task_token == sample_decision_task.task_token
         assert call_args.identity == handler._identity
-        assert call_args.return_new_decision_task == True
-        assert call_args.force_create_new_decision_task == True
+        assert call_args.return_new_decision_task
+        assert call_args.force_create_new_decision_task
         assert len(call_args.decisions) == 2
         # query_results should not be set when None
         assert not hasattr(call_args, 'query_results') or len(call_args.query_results) == 0
@@ -285,8 +282,8 @@ async def test_respond_decision_task_completed_no_query_results(self, handler, s
         await handler._respond_decision_task_completed(sample_decision_task, decision_result)
 
         call_args = handler._client.worker_stub.RespondDecisionTaskCompleted.call_args[0][0]
-        assert call_args.return_new_decision_task == False
-        assert call_args.force_create_new_decision_task == False
+        assert not call_args.return_new_decision_task
+        assert not call_args.force_create_new_decision_task
         assert len(call_args.decisions) == 0
         # query_results should not be set when None
         assert not hasattr(call_args, 'query_results') or len(call_args.query_results) == 0