minor change

Signed-off-by: Tim Li <[email protected]>

Author: timl3136

cadence/client.py

@@ -23,29 +23,6 @@
 from cadence.metrics import MetricsEmitter, NoOpMetricsEmitter
 
 
-@dataclass
-class WorkflowRun:
-    """Represents a workflow run that can be used to get results."""
-    execution: WorkflowExecution
-    client: 'Client'
-
-    @property
-    def workflow_id(self) -> str:
-        """Get the workflow ID."""
-        return self.execution.workflow_id
-
-    @property
-    def run_id(self) -> str:
-        """Get the run ID."""
-        return self.execution.run_id
-
-    async def get_result(self, result_type: Optional[type] = None) -> Any:  # noqa: ARG002
-        """Wait for workflow completion and return result."""
-        # TODO: Implement workflow result retrieval
-        # This would involve polling GetWorkflowExecutionHistory until completion
-        # and extracting the result from the final event
-        raise NotImplementedError("get_result not yet implemented")
-
 
 @dataclass
 class StartWorkflowOptions:
@@ -246,28 +223,25 @@ async def execute_workflow(
         workflow: Union[str, Callable],
         *args,
         **options_kwargs
-    ) -> WorkflowRun:
+    ) -> WorkflowExecution:
         """
-        Start a workflow execution and return a handle to get the result.
+        Start a workflow execution and return the execution handle.
 
         Args:
             workflow: Workflow function or workflow type name string
             *args: Arguments to pass to the workflow
             **options_kwargs: StartWorkflowOptions as keyword arguments
 
         Returns:
-            WorkflowRun that can be used to get the workflow result
+            WorkflowExecution that contains workflow_id and run_id
 
         Raises:
             ValueError: If required parameters are missing or invalid
             Exception: If the gRPC call fails
         """
-        execution = await self.start_workflow(workflow, *args, **options_kwargs)
+        return await self.start_workflow(workflow, *args, **options_kwargs)
+
 
-        return WorkflowRun(
-            execution=execution,
-            client=self
-        )
 
 def _validate_and_copy_defaults(options: ClientOptions) -> ClientOptions:
     if "target" not in options:

tests/cadence/test_client_workflow.py

@@ -6,7 +6,7 @@
 from cadence.api.v1.common_pb2 import WorkflowExecution
 from cadence.api.v1.service_workflow_pb2 import StartWorkflowExecutionRequest, StartWorkflowExecutionResponse
 from cadence.api.v1.workflow_pb2 import WorkflowIdReusePolicy
-from cadence.client import Client, StartWorkflowOptions, WorkflowRun
+from cadence.client import Client, StartWorkflowOptions
 from cadence.data_converter import DefaultDataConverter
 
 
@@ -64,32 +64,6 @@ def test_custom_values(self):
         assert options.search_attributes == {"attr": "value"}
 
 
-class TestWorkflowRun:
-    """Test WorkflowRun class."""
-
-    def test_properties(self, mock_client):
-        """Test WorkflowRun properties."""
-        execution = WorkflowExecution()
-        execution.workflow_id = "test-workflow-id"
-        execution.run_id = "test-run-id"
-
-        workflow_run = WorkflowRun(execution=execution, client=mock_client)
-
-        assert workflow_run.workflow_id == "test-workflow-id"
-        assert workflow_run.run_id == "test-run-id"
-        assert workflow_run.client is mock_client
-
-    @pytest.mark.asyncio
-    async def test_get_result_not_implemented(self, mock_client):
-        """Test that get_result raises NotImplementedError."""
-        execution = WorkflowExecution()
-        execution.workflow_id = "test-workflow-id"
-        execution.run_id = "test-run-id"
-
-        workflow_run = WorkflowRun(execution=execution, client=mock_client)
-
-        with pytest.raises(NotImplementedError, match="get_result not yet implemented"):
-            await workflow_run.get_result()
 
 
 class TestClientBuildStartWorkflowRequest:
@@ -316,17 +290,16 @@ async def test_execute_workflow_success(self, mock_client):
         client = Client(domain="test-domain", target="localhost:7933")
         client.start_workflow = AsyncMock(return_value=execution)
 
-        workflow_run = await client.execute_workflow(
+        result_execution = await client.execute_workflow(
             "TestWorkflow",
             "arg1", "arg2",
             task_list="test-task-list"
         )
 
-        assert isinstance(workflow_run, WorkflowRun)
-        assert workflow_run.execution is execution
-        assert workflow_run.client is client
-        assert workflow_run.workflow_id == "test-workflow-id"
-        assert workflow_run.run_id == "test-run-id"
+        assert isinstance(result_execution, WorkflowExecution)
+        assert result_execution is execution
+        assert result_execution.workflow_id == "test-workflow-id"
+        assert result_execution.run_id == "test-run-id"
 
         # Verify start_workflow was called with correct arguments
         client.start_workflow.assert_called_once_with(
@@ -361,7 +334,7 @@ async def test_integration_workflow_invocation():
     client._workflow_stub.StartWorkflowExecution = AsyncMock(return_value=response)
 
     # Test the complete flow
-    workflow_run = await client.execute_workflow(
+    execution = await client.execute_workflow(
         "IntegrationTestWorkflow",
         "test-arg",
         42,
@@ -372,8 +345,8 @@ async def test_integration_workflow_invocation():
     )
 
     # Verify result
-    assert workflow_run.workflow_id == "integration-workflow-id"
-    assert workflow_run.run_id == "integration-run-id"
+    assert execution.workflow_id == "integration-workflow-id"
+    assert execution.run_id == "integration-run-id"
 
     # Verify the gRPC call was made with proper request
     client._workflow_stub.StartWorkflowExecution.assert_called_once()