fix: Verify all samples run end-to-end and fix heartbeat timeout bug

zawadzkidiana · zawadzkidiana · commit d0152f891970 · 2025-12-02T16:05:38.000-08:00
Ran all 7 samples against Cadence server to verify they work:
- greetings, timer, branch, choice, pickfirst, activities, operations

Discovered bug: Activities without heartbeating were failing with
ActivityTaskTimedOut (HEARTBEAT) because HeartbeatTimeout was set
but the activities never called activity.RecordHeartbeat().

Fix: Removed HeartbeatTimeout from simple activities (greetings,
branch, choice) that complete quickly and don't need heartbeating.

Signed-off-by: Diana Zawadzki &lt;dzawa@live.de&gt;
diff --git a/new_samples/branch/branch_workflow.go b/new_samples/branch/branch_workflow.go
@@ -17,7 +17,6 @@ func BranchWorkflow(ctx workflow.Context) error {
 	ao := workflow.ActivityOptions{
 		ScheduleToStartTimeout: time.Minute,
 		StartToCloseTimeout:    time.Minute,
-		HeartbeatTimeout:       time.Second * 20,
 	}
 	ctx = workflow.WithActivityOptions(ctx, ao)
 
@@ -52,7 +51,6 @@ func ParallelWorkflow(ctx workflow.Context) error {
 	ao := workflow.ActivityOptions{
 		ScheduleToStartTimeout: time.Minute,
 		StartToCloseTimeout:    time.Minute,
-		HeartbeatTimeout:       time.Second * 20,
 	}
 	ctx = workflow.WithActivityOptions(ctx, ao)
 
diff --git a/new_samples/choice/choice_workflow.go b/new_samples/choice/choice_workflow.go
@@ -24,7 +24,6 @@ func ChoiceWorkflow(ctx workflow.Context) error {
 	ao := workflow.ActivityOptions{
 		ScheduleToStartTimeout: time.Minute,
 		StartToCloseTimeout:    time.Minute,
-		HeartbeatTimeout:       time.Second * 20,
 	}
 	ctx = workflow.WithActivityOptions(ctx, ao)
 
diff --git a/new_samples/greetings/greetings_workflow.go b/new_samples/greetings/greetings_workflow.go
@@ -14,7 +14,6 @@ func GreetingsWorkflow(ctx workflow.Context) error {
 	ao := workflow.ActivityOptions{
 		ScheduleToStartTimeout: time.Minute,
 		StartToCloseTimeout:    time.Minute,
-		HeartbeatTimeout:       time.Second * 20,
 	}
 	ctx = workflow.WithActivityOptions(ctx, ao)
 

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@ func BranchWorkflow(ctx workflow.Context) error {`
`17`	`17`	`ao := workflow.ActivityOptions{`
`18`	`18`	`ScheduleToStartTimeout: time.Minute,`
`19`	`19`	`StartToCloseTimeout: time.Minute,`
`20`		`- HeartbeatTimeout: time.Second * 20,`
`21`	`20`	`}`
`22`	`21`	`ctx = workflow.WithActivityOptions(ctx, ao)`
`23`	`22`
`@@ -52,7 +51,6 @@ func ParallelWorkflow(ctx workflow.Context) error {`
`52`	`51`	`ao := workflow.ActivityOptions{`
`53`	`52`	`ScheduleToStartTimeout: time.Minute,`
`54`	`53`	`StartToCloseTimeout: time.Minute,`
`55`		`- HeartbeatTimeout: time.Second * 20,`
`56`	`54`	`}`
`57`	`55`	`ctx = workflow.WithActivityOptions(ctx, ao)`
`58`	`56`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ func ChoiceWorkflow(ctx workflow.Context) error {`
`24`	`24`	`ao := workflow.ActivityOptions{`
`25`	`25`	`ScheduleToStartTimeout: time.Minute,`
`26`	`26`	`StartToCloseTimeout: time.Minute,`
`27`		`- HeartbeatTimeout: time.Second * 20,`
`28`	`27`	`}`
`29`	`28`	`ctx = workflow.WithActivityOptions(ctx, ao)`
`30`	`29`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ func GreetingsWorkflow(ctx workflow.Context) error {`
`14`	`14`	`ao := workflow.ActivityOptions{`
`15`	`15`	`ScheduleToStartTimeout: time.Minute,`
`16`	`16`	`StartToCloseTimeout: time.Minute,`
`17`		`- HeartbeatTimeout: time.Second * 20,`
`18`	`17`	`}`
`19`	`18`	`ctx = workflow.WithActivityOptions(ctx, ao)`
`20`	`19`