Add configuration file (#573)

 Add configuration file under the server/ directory

Author: mantas-sidlauskas

server/config/config.js

@@ -0,0 +1,46 @@
+// Copyright (c) 2024 Uber Technologies Inc.
+//
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
+const {
+  PEERS_DEFAULT,
+  REQUEST_RETRY_FLAGS_DEFAULT,
+  REQUEST_RETRY_LIMIT_DEFAULT,
+  REQUEST_TIMEOUT_DEFAULT,
+  SERVICE_NAME_DEFAULT,
+  TRANSPORT_CLIENT_TYPE_DEFAULT,
+} = require('../constants');
+
+module.exports = {
+  peers: process.env.CADENCE_TCHANNEL_PEERS || PEERS_DEFAULT,
+  transportClientType:
+    process.env.TRANSPORT_CLIENT_TYPE || TRANSPORT_CLIENT_TYPE_DEFAULT,
+  useWebpack: process.env.NODE_ENV !== 'production',
+  enableAuth: process.env.ENABLE_AUTH === 'true',
+  authType: process.env.AUTH_TYPE,
+  authAdminJwtPrivateKey: process.env.AUTH_ADMIN_JWT_PRIVATE_KEY,
+  requestConfig: {
+    retryFlags: REQUEST_RETRY_FLAGS_DEFAULT,
+    retryLimit:
+      process.env.CADENCE_TCHANNEL_RETRY_LIMIT || REQUEST_RETRY_LIMIT_DEFAULT,
+    serviceName: process.env.CADENCE_TCHANNEL_SERVICE || SERVICE_NAME_DEFAULT,
+    timeout: REQUEST_TIMEOUT_DEFAULT,
+  },
+};

server/index.js

@@ -29,20 +29,11 @@ const koaStatic = require('koa-static');
 const koaWebpack = require('koa-webpack');
 const webpack = require('webpack');
 const jwt = require('jsonwebtoken');
-
 const webpackConfig = require('../webpack.config');
 const grpcClient = require('./middleware/grpc-client');
 const tchannelClient = require('./middleware/tchannel-client');
 const router = require('./router');
-const {
-  PEERS_DEFAULT,
-  REQUEST_RETRY_FLAGS_DEFAULT,
-  REQUEST_RETRY_LIMIT_DEFAULT,
-  REQUEST_TIMEOUT_DEFAULT,
-  SERVICE_NAME_DEFAULT,
-  TRANSPORT_CLIENT_TYPE_DEFAULT,
-} = require('./constants');
-
+const config = require('./config/config');
 const staticRoot = path.join(__dirname, '../dist');
 const app = new Koa();
 const transportClients = {
@@ -54,18 +45,16 @@ app.webpackConfig = webpackConfig;
 
 app.init = function({
   logErrors,
-  peers = process.env.CADENCE_TCHANNEL_PEERS || PEERS_DEFAULT,
-  retryFlags = REQUEST_RETRY_FLAGS_DEFAULT,
-  retryLimit = process.env.CADENCE_TCHANNEL_RETRY_LIMIT ||
-    REQUEST_RETRY_LIMIT_DEFAULT,
-  serviceName = process.env.CADENCE_TCHANNEL_SERVICE || SERVICE_NAME_DEFAULT,
-  timeout = REQUEST_TIMEOUT_DEFAULT,
-  transportClientType = process.env.TRANSPORT_CLIENT_TYPE ||
-    TRANSPORT_CLIENT_TYPE_DEFAULT, // 'tchannel', 'grpc'
-  useWebpack = process.env.NODE_ENV !== 'production',
-  enableAuth = process.env.ENABLE_AUTH === 'true',
-  authType = process.env.AUTH_TYPE,
-  authAdminJwtPrivateKey = process.env.AUTH_ADMIN_JWT_PRIVATE_KEY,
+  peers = config.peers,
+  retryFlags = config.requestConfig.retryFlags,
+  retryLimit = config.requestConfig.retryLimit,
+  serviceName = config.requestConfig.serviceName,
+  timeout = config.requestConfig.timeout,
+  transportClientType = config.transportClientType,
+  useWebpack = config.useWebpack,
+  enableAuth = config.enableAuth,
+  authType = config.authType,
+  authAdminJwtPrivateKey = config.authAdminJwtPrivateKey,
 } = {}) {
   const requestConfig = {
     retryFlags,