Skip to content

Commit 1aed63f

Browse files
Increase default workflow listing time from 7 days to 30 days (#924)
* Increase default workflow listing time (for basic and advanced visibility) from 7 days to 30 days, to allow listing more workflows for domains with a higher retention period * Add new prop to expand filters by default
1 parent abb5192 commit 1aed63f

File tree

6 files changed

+25
-6
lines changed

6 files changed

+25
-6
lines changed

src/views/domain-page/config/domain-page-query-params.config.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ const domainPageQueryParamsConfig: [
6262
{
6363
key: 'timeRangeStart',
6464
queryParamKey: 'start',
65-
defaultValue: 'now-7d',
66-
parseValue: (v) => parseDateFilterValue(v, 'now-7d'),
65+
defaultValue: 'now-30d',
66+
parseValue: (v) => parseDateFilterValue(v, 'now-30d'),
6767
},
6868
{
6969
key: 'timeRangeEnd',
@@ -103,8 +103,8 @@ const domainPageQueryParamsConfig: [
103103
{
104104
key: 'timeRangeStartBasic',
105105
queryParamKey: 'start',
106-
defaultValue: 'now-7d',
107-
parseValue: (v) => parseDateFilterValue(v, 'now-7d'),
106+
defaultValue: 'now-30d',
107+
parseValue: (v) => parseDateFilterValue(v, 'now-30d'),
108108
},
109109
{
110110
key: 'timeRangeEndBasic',

src/views/domain-workflows-archival/domain-workflows-archival-header/domain-workflows-archival-header.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ export default function DomainWorkflowsArchivalHeader({
4242
queryStringQueryParamKey="queryArchival"
4343
refetchQuery={refetch}
4444
isQueryRunning={isFetching}
45+
expandFiltersByDefault={true}
4546
/>
4647
);
4748
}

src/views/domain-workflows/domain-workflows-header/domain-workflows-header.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ export default function DomainWorkflowsHeader({
4141
queryStringQueryParamKey="query"
4242
refetchQuery={refetch}
4343
isQueryRunning={isFetching}
44+
expandFiltersByDefault={true}
4445
/>
4546
);
4647
}

src/views/shared/workflows-header/__tests__/workflows-header.test.tsx

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,21 @@ describe(WorkflowsHeader.name, () => {
108108

109109
expect(mockSetQueryParams).toHaveBeenCalledWith({ inputType: 'query' });
110110
});
111+
112+
it('shows filters by default when expandFiltersByDefault is true', async () => {
113+
setup({ expandFiltersByDefault: true });
114+
115+
expect(await screen.findByText('Filter fields')).toBeInTheDocument();
116+
});
111117
});
112118

113-
function setup({ isQueryRunning }: { isQueryRunning?: boolean }) {
119+
function setup({
120+
isQueryRunning,
121+
expandFiltersByDefault,
122+
}: {
123+
isQueryRunning?: boolean;
124+
expandFiltersByDefault?: boolean;
125+
}) {
114126
const user = userEvent.setup();
115127
const renderResult = render(
116128
<WorkflowsHeader
@@ -121,6 +133,7 @@ function setup({ isQueryRunning }: { isQueryRunning?: boolean }) {
121133
queryStringQueryParamKey="query"
122134
refetchQuery={jest.fn()}
123135
isQueryRunning={isQueryRunning ?? false}
136+
expandFiltersByDefault={expandFiltersByDefault}
124137
/>
125138
);
126139

src/views/shared/workflows-header/workflows-header.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,11 @@ export default function WorkflowsHeader<
3232
queryStringQueryParamKey,
3333
refetchQuery,
3434
isQueryRunning,
35+
expandFiltersByDefault,
3536
}: Props<P, I, S, Q>) {
36-
const [areFiltersShown, setAreFiltersShown] = useState(false);
37+
const [areFiltersShown, setAreFiltersShown] = useState(
38+
expandFiltersByDefault ?? false
39+
);
3740

3841
const { resetAllFilters, activeFiltersCount, queryParams, setQueryParams } =
3942
usePageFilters({

src/views/shared/workflows-header/workflows-header.types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,5 @@ export type Props<
2626
: never;
2727
refetchQuery: () => void;
2828
isQueryRunning: boolean;
29+
expandFiltersByDefault?: boolean;
2930
};

0 commit comments

Comments
 (0)