Skip to content

Commit 24e2c5c

Browse files
Return null parsingError instead of undefined from diagnoseWorkflow (#946)
Return null parsingError instead of undefined from diagnoseWorkflow, to allow Typescript to better infer the result type on the frontend.
1 parent 096d7d0 commit 24e2c5c

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

src/route-handlers/diagnose-workflow/__tests__/diagnose-workflow.node.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ describe(diagnoseWorkflow.name, () => {
7878
const responseJson = await res.json();
7979
expect(responseJson).toEqual({
8080
result: mockWorkflowDiagnosticsResult,
81+
parsingError: null,
8182
});
8283
});
8384

@@ -112,6 +113,7 @@ describe(diagnoseWorkflow.name, () => {
112113
const responseJson = await res.json();
113114
expect(responseJson).toEqual({
114115
result: mockWorkflowDiagnosticsResult,
116+
parsingError: null,
115117
});
116118
});
117119

src/route-handlers/diagnose-workflow/diagnose-workflow.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,12 @@ export async function diagnoseWorkflow(
7777
return NextResponse.json(
7878
(error
7979
? {
80-
parsingError: error,
8180
result: unparsedResult,
81+
parsingError: error,
8282
}
8383
: {
8484
result: parsedResult,
85+
parsingError: null,
8586
}) satisfies DiagnoseWorkflowResponse
8687
);
8788
} catch (e) {

src/route-handlers/diagnose-workflow/diagnose-workflow.types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export type WorkflowDiagnosticsResult = z.infer<
2222
export type DiagnoseWorkflowResponse =
2323
| {
2424
result: WorkflowDiagnosticsResult;
25+
parsingError: null;
2526
}
2627
| {
2728
result: any;

0 commit comments

Comments
 (0)