feature/pending decision tasks (#285)

* bump IDL

* adding decisions tab to list of filters. added pending decision to available pending tasks

* fixing integration test with cadence server API IDL update

Author: just-at-uber

client/containers/workflow-pending/component.vue

@@ -22,10 +22,16 @@
 
 import { DynamicScroller, DynamicScrollerItem } from 'vue-virtual-scroller';
 import { PendingTaskListItem } from './components';
+import { PENDING_TASK_FILTERS } from './constants';
 import { ButtonGroup, NoResults } from '~components';
 
 export default {
   name: 'workflow-pending',
+  data() {
+    return {
+      pendingTaskFilters: PENDING_TASK_FILTERS,
+    };
+  },
   props: {
     filter: {
       type: String,
@@ -58,7 +64,7 @@ export default {
   <div class="workflow-pending">
     <div class="top-navigation">
       <button-group
-        :items="['all', 'activities', 'children']"
+        :items="pendingTaskFilters"
         label="Filters"
         uppercase
         :value="filter"

client/containers/workflow-pending/constants.js

@@ -22,12 +22,39 @@
 import {
   PENDING_TASK_TYPE_ACTIVITY,
   PENDING_TASK_TYPE_CHILD_WORKFLOW,
+  PENDING_TASK_TYPE_DECISION,
 } from '../workflow/constants';
+import {
+  WORKFLOW_EXECUTION_PENDING_ACTIVITIES,
+  WORKFLOW_EXECUTION_PENDING_CHILDREN,
+  WORKFLOW_EXECUTION_PENDING_TASKS,
+  WORKFLOW_EXECUTION_PENDING_DECISIONS,
+} from '../workflow/getter-types';
+
+export const PENDING_TASK_FILTER_ALL = 'all';
+export const PENDING_TASK_FILTER_ACTIVITIES = 'activities';
+export const PENDING_TASK_FILTER_CHILDREN = 'children';
+export const PENDING_TASK_FILTER_DECISIONS = 'decisions';
+
+export const PENDING_TASK_FILTERS = [
+  PENDING_TASK_FILTER_ALL,
+  PENDING_TASK_FILTER_ACTIVITIES,
+  PENDING_TASK_FILTER_CHILDREN,
+  PENDING_TASK_FILTER_DECISIONS,
+];
 
 export const PENDING_TASK_FILTER_TO_EMPTY_MESSAGE_MAP = {
-  all: 'No pending tasks',
-  activities: 'No pending activities',
-  children: 'No pending child workflows',
+  [PENDING_TASK_FILTER_ALL]: 'No pending tasks',
+  [PENDING_TASK_FILTER_ACTIVITIES]: 'No pending activities',
+  [PENDING_TASK_FILTER_CHILDREN]: 'No pending child workflows',
+  [PENDING_TASK_FILTER_DECISIONS]: 'No pending decisions',
+};
+
+export const PENDING_TASK_FILTER_TO_GETTER_TYPE_MAP = {
+  [PENDING_TASK_FILTER_ALL]: WORKFLOW_EXECUTION_PENDING_TASKS,
+  [PENDING_TASK_FILTER_ACTIVITIES]: WORKFLOW_EXECUTION_PENDING_ACTIVITIES,
+  [PENDING_TASK_FILTER_CHILDREN]: WORKFLOW_EXECUTION_PENDING_CHILDREN,
+  [PENDING_TASK_FILTER_DECISIONS]: WORKFLOW_EXECUTION_PENDING_DECISIONS,
 };
 
 export const PENDING_TASK_KVPS_EXCLUDE_KEYS = [
@@ -39,9 +66,11 @@ export const PENDING_TASK_KVPS_EXCLUDE_KEYS = [
 export const PENDING_TASK_TYPE_TO_ID_MAP = {
   [PENDING_TASK_TYPE_ACTIVITY]: 'activityID',
   [PENDING_TASK_TYPE_CHILD_WORKFLOW]: 'initiatedID',
+  [PENDING_TASK_TYPE_DECISION]: 'scheduledTimestamp',
 };
 
 export const PENDING_TASK_TYPE_TO_DISPLAY_MAP = {
   [PENDING_TASK_TYPE_ACTIVITY]: 'PendingActivityTask',
   [PENDING_TASK_TYPE_CHILD_WORKFLOW]: 'PendingChildWorkflowTask',
+  [PENDING_TASK_TYPE_DECISION]: 'PendingDecisionTask',
 };

client/containers/workflow-pending/helpers/map-filter-to-getter-type.js

@@ -19,19 +19,9 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-import {
-  WORKFLOW_EXECUTION_PENDING_ACTIVITIES,
-  WORKFLOW_EXECUTION_PENDING_CHILDREN,
-  WORKFLOW_EXECUTION_PENDING_TASKS,
-} from '../../workflow/getter-types';
-
-const WORKFLOW_PENDING_FILTER_TO_GETTER_TYPE_MAP = {
-  activities: WORKFLOW_EXECUTION_PENDING_ACTIVITIES,
-  all: WORKFLOW_EXECUTION_PENDING_TASKS,
-  children: WORKFLOW_EXECUTION_PENDING_CHILDREN,
-};
+import { PENDING_TASK_FILTER_TO_GETTER_TYPE_MAP } from '../constants';
 
 const mapFilterToGetterType = filter =>
-  WORKFLOW_PENDING_FILTER_TO_GETTER_TYPE_MAP[filter] || '';
+  PENDING_TASK_FILTER_TO_GETTER_TYPE_MAP[filter] || '';
 
 export default mapFilterToGetterType;

client/containers/workflow/constants.js

@@ -22,5 +22,6 @@
 export const PENDING_TASK_TYPE_ACTIVITY = 'PENDING_TASK_TYPE_ACTIVITY';
 export const PENDING_TASK_TYPE_CHILD_WORKFLOW =
   'PENDING_TASK_TYPE_CHILD_WORKFLOW';
+export const PENDING_TASK_TYPE_DECISION = 'PENDING_TASK_TYPE_DECISION';
 export const RETRY_COUNT_MAX = 3;
 export const RETRY_TIMEOUT = 6000;

client/containers/workflow/getter-types.js

@@ -25,6 +25,8 @@ export const WORKFLOW_EXECUTION_PENDING_ACTIVITIES =
   'WORKFLOW_EXECUTION_PENDING_ACTIVITIES';
 export const WORKFLOW_EXECUTION_PENDING_CHILDREN =
   'WORKFLOW_EXECUTION_PENDING_CHILDREN';
+export const WORKFLOW_EXECUTION_PENDING_DECISIONS =
+  'WORKFLOW_EXECUTION_PENDING_DECISIONS';
 export const WORKFLOW_EXECUTION_PENDING_TASK_COUNT =
   'WORKFLOW_EXECUTION_PENDING_TASK_COUNT';
 export const WORKFLOW_EXECUTION_PENDING_TASKS =

client/containers/workflow/getters.js

@@ -23,12 +23,14 @@ import { get } from 'lodash-es';
 import {
   PENDING_TASK_TYPE_ACTIVITY,
   PENDING_TASK_TYPE_CHILD_WORKFLOW,
+  PENDING_TASK_TYPE_DECISION,
 } from './constants';
 import {
   WORKFLOW_EXECUTION,
   WORKFLOW_EXECUTION_IS_LOADING,
   WORKFLOW_EXECUTION_PENDING_ACTIVITIES,
   WORKFLOW_EXECUTION_PENDING_CHILDREN,
+  WORKFLOW_EXECUTION_PENDING_DECISIONS,
   WORKFLOW_EXECUTION_PENDING_TASK_COUNT,
   WORKFLOW_EXECUTION_PENDING_TASKS,
   WORKFLOW_EXECUTION_TASK_LIST_NAME,
@@ -48,11 +50,26 @@ const getters = {
       ...item,
       pendingTaskType: PENDING_TASK_TYPE_CHILD_WORKFLOW,
     })),
+  [WORKFLOW_EXECUTION_PENDING_DECISIONS]: state => {
+    const pendingDecision = get(state, 'workflow.execution.pendingDecision');
+
+    if (!pendingDecision) {
+      return [];
+    }
+
+    return [
+      {
+        ...pendingDecision,
+        pendingTaskType: PENDING_TASK_TYPE_DECISION,
+      },
+    ];
+  },
   [WORKFLOW_EXECUTION_PENDING_TASK_COUNT]: (_, getters) =>
     getters[WORKFLOW_EXECUTION_PENDING_TASKS].length,
   [WORKFLOW_EXECUTION_PENDING_TASKS]: (_, getters) => [
     ...getters[WORKFLOW_EXECUTION_PENDING_ACTIVITIES],
     ...getters[WORKFLOW_EXECUTION_PENDING_CHILDREN],
+    ...getters[WORKFLOW_EXECUTION_PENDING_DECISIONS],
   ],
   [WORKFLOW_EXECUTION_TASK_LIST_NAME]: state =>
     get(state, 'workflow.execution.executionConfiguration.taskList.name') || '',

package.json

@@ -128,7 +128,7 @@
     "webpack-hot-client": "^1.3.0"
   },
   "napa": {
-    "cadence-idl": "uber/cadence-idl#87b3154c204df27e6055a5a1cf840973b627877f"
+    "cadence-idl": "uber/cadence-idl#b1a9b9ede5fbd29a5b67cb8e082f602488ce0446"
   },
   "napa-config": {
     "cache": false

server/test/workflow-execution.test.js

@@ -46,6 +46,7 @@ describe('Workflow Execution', function() {
         workflowExecutionInfo: null,
         pendingChildren: null,
         pendingActivities: null,
+        pendingDecision: null,
       });
   });