Fix sorting for basic visibility (#849)

Change basic visibility workflow sorting to show all open workflows on top by default

Author: adhityamamallan

src/views/domain-workflows-basic/hooks/helpers/__tests__/compare-basic-visibility-workflows.test.ts

@@ -0,0 +1,66 @@
+import { type DomainWorkflow } from '@/views/domain-page/domain-page.types';
+
+import compareBasicVisibilityWorkflows from '../compare-basic-visibility-workflows';
+
+function createMockWorkflow(
+  startTime: number,
+  closeTime?: number
+): DomainWorkflow {
+  return {
+    workflowID: 'mock-id',
+    runID: 'mock-run-id',
+    workflowName: 'mock-name',
+    status: closeTime
+      ? 'WORKFLOW_EXECUTION_CLOSE_STATUS_COMPLETED'
+      : 'WORKFLOW_EXECUTION_CLOSE_STATUS_INVALID',
+    startTime,
+    closeTime,
+  };
+}
+
+describe('compareBasicVisibilityWorkflows', () => {
+  it('should pick workflow with later start time for running workflows', () => {
+    const firstWorkflow = createMockWorkflow(1741500000000);
+    const secondWorkflow = createMockWorkflow(1741600000000);
+
+    expect(compareBasicVisibilityWorkflows(firstWorkflow, secondWorkflow)).toBe(
+      1
+    );
+    expect(compareBasicVisibilityWorkflows(secondWorkflow, firstWorkflow)).toBe(
+      -1
+    );
+  });
+
+  it('should pick workflow with later close time for closed workflows', () => {
+    const firstWorkflow = createMockWorkflow(1741400000000, 1741600000000);
+    const secondWorkflow = createMockWorkflow(1741500000000, 1741700000000);
+
+    expect(compareBasicVisibilityWorkflows(firstWorkflow, secondWorkflow)).toBe(
+      1
+    );
+    expect(compareBasicVisibilityWorkflows(secondWorkflow, firstWorkflow)).toBe(
+      -1
+    );
+  });
+
+  it('should pick running workflows over closed workflows', () => {
+    const runningWorkflow = createMockWorkflow(1741500000000);
+    const closedWorkflow = createMockWorkflow(1741500000000, 1741600000000);
+
+    expect(
+      compareBasicVisibilityWorkflows(runningWorkflow, closedWorkflow)
+    ).toBe(-1);
+    expect(
+      compareBasicVisibilityWorkflows(closedWorkflow, runningWorkflow)
+    ).toBe(1);
+  });
+
+  it('should handle edge cases with same timestamps', () => {
+    const firstWorkflow = createMockWorkflow(1741500000000, 1741600000000);
+    const secondWorkflow = createMockWorkflow(1741500000000, 1741600000000);
+
+    expect(compareBasicVisibilityWorkflows(firstWorkflow, secondWorkflow)).toBe(
+      -1
+    );
+  });
+});

src/views/domain-workflows-basic/hooks/helpers/compare-basic-visibility-workflows.ts

@@ -0,0 +1,20 @@
+import { type DomainWorkflow } from '@/views/domain-page/domain-page.types';
+
+/**
+ * Since ListOpenWorkflows returns workflows sorted by their start time, and ListClosedWorkflows sorts them by their
+ * close time, we cannot merge them. Therefore, the sorting logic prioritizes open workflows over closed workflows.
+ */
+export default function compareBasicVisibilityWorkflows(
+  first: DomainWorkflow,
+  second: DomainWorkflow
+): number {
+  if (!first.closeTime && !second.closeTime) {
+    return second.startTime > first.startTime ? 1 : -1;
+  }
+
+  if (!first.closeTime || !second.closeTime) {
+    return !second.closeTime ? 1 : -1;
+  }
+
+  return second.closeTime > first.closeTime ? 1 : -1;
+}

src/views/domain-workflows-basic/hooks/use-list-workflows-basic.ts

@@ -10,6 +10,7 @@ import domainPageQueryParamsConfig from '@/views/domain-page/config/domain-page-
 import DOMAIN_WORKFLOWS_BASIC_PAGE_SIZE from '../config/domain-workflows-basic-page-size.config';
 import { type UseListWorkflowsBasicParams } from '../domain-workflows-basic.types';
 
+import compareBasicVisibilityWorkflows from './helpers/compare-basic-visibility-workflows';
 import getListWorkflowsBasicQueryOptions from './helpers/get-list-workflows-basic-query-options';
 
 export default function useListWorkflowsBasic({
@@ -85,6 +86,6 @@ export default function useListWorkflowsBasic({
     queries: queryConfigs,
     pageSize: DOMAIN_WORKFLOWS_BASIC_PAGE_SIZE,
     flattenResponse: (result) => result.workflows,
-    compare: (a, b) => (a.startTime > b.startTime ? -1 : 1),
+    compare: compareBasicVisibilityWorkflows,
   });
 }