Skip to content

Commit b302eb0

Browse files
authored
Merge pull request #53 from dmetzgar/master
Fixed some test issues
2 parents 76564f7 + 374b304 commit b302eb0

File tree

4 files changed

+40
-8
lines changed

4 files changed

+40
-8
lines changed

client/test/execution.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ describe('Execution', function() {
2020

2121
scenario.withFullHistory(opts.events)
2222

23-
var summaryEl = await scenario.render(opts.attach).waitUntilExists('section.execution section.execution-summary')
24-
return [summaryEl, scenario]
23+
var summaryEl = await scenario.render(opts.attach).waitUntilExists('section.execution section.execution-summary dl')
24+
return [summaryEl.parentElement, scenario]
2525
}
2626

2727
const closedWorkflowExecution = {
@@ -59,8 +59,8 @@ describe('Execution', function() {
5959
'/domain/ci-test/workflows/email-daily-summaries/emailRun1/stack-trace',
6060
'/domain/ci-test/workflows/email-daily-summaries/emailRun1/queries'
6161
])
62-
scenario.vm.$el.querySelector('section.execution > nav a.stack-trace').should.be.displayed
63-
scenario.vm.$el.querySelector('section.execution > nav a.queries').should.be.displayed
62+
scenario.vm.$el.querySelector('section.execution > nav a.stack-trace').should.not.have.property("display", "none")
63+
scenario.vm.$el.querySelector('section.execution > nav a.queries').should.not.have.property("display", "none")
6464
})
6565

6666
describe('Summary', function() {
@@ -79,7 +79,7 @@ describe('Execution', function() {
7979
summaryEl.should.not.have.descendant('.pending-activities')
8080
summaryEl.should.not.have.descendant('.parent-workflow')
8181
summaryEl.querySelector('.workflow-status dd').should.contain.text('running')
82-
summaryEl.querySelector('.workflow-status loader.bar').should.be.displayed
82+
summaryEl.querySelector('.workflow-status loader.bar').should.not.have.property("display", "none")
8383
})
8484

8585
it('should show the input of the workflow, and any pending events', async function () {

server/test/domain.test.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,17 @@ describe('Describe Domain', function() {
66
status: 'REGISTERED',
77
description: 'domain for running CI tests',
88
ownerEmail: '[email protected]',
9-
data: null
9+
data: null,
10+
uuid: null
1011
},
1112
isGlobalDomain: false,
1213
failoverVersion: 0,
1314
configuration: {
15+
archivalBucketName: null,
16+
archivalBucketOwner: null,
17+
archivalRetentionPeriodInDays: null,
18+
archivalStatus: null,
19+
badBinaries: null,
1420
emitMetric: false,
1521
workflowExecutionRetentionPeriodInDays: 14
1622
},
@@ -39,11 +45,17 @@ describe('Describe Domain', function() {
3945
status: 'REGISTERED',
4046
description: 'ci test domain',
4147
ownerEmail: null,
42-
data: {}
48+
data: {},
49+
uuid: null
4350
},
4451
failoverVersion: 0,
4552
isGlobalDomain: true,
4653
configuration: {
54+
archivalBucketName: null,
55+
archivalBucketOwner: null,
56+
archivalRetentionPeriodInDays: null,
57+
archivalStatus: null,
58+
badBinaries: null,
4759
workflowExecutionRetentionPeriodInDays: 14,
4860
emitMetric: true
4961
},

server/test/history.test.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,22 @@ wfHistoryThrift = [{
2121
childPolicy: 'TERMINATE',
2222
expirationTimestamp: null,
2323
continuedExecutionRunId: null,
24+
continuedFailureDetails: null,
25+
continuedFailureReason: null,
26+
cronSchedule: null,
27+
firstDecisionTaskBackoffSeconds: null,
28+
firstExecutionRunId: null,
29+
header: null,
30+
initiator: null,
31+
lastCompletionResult: null,
32+
memo: null,
33+
originalExecutionRunId: null,
2434
parentInitiatedEventId: null,
2535
parentWorkflowDomain: null,
2636
parentWorkflowExecution: null,
37+
prevAutoResetPoints: null,
2738
retryPolicy: null,
39+
searchAttributes: null,
2840
taskStartToCloseTimeoutSeconds: 30,
2941
executionStartToCloseTimeoutSeconds: 1080
3042
}
@@ -119,6 +131,7 @@ describe('Workflow History', function() {
119131
.expect(200)
120132
.expect('Content-Type', /json/)
121133
.expect({
134+
archived: null,
122135
history: { events: [] },
123136
nextPageToken: 'cGFnZTM='
124137
})
@@ -150,6 +163,7 @@ describe('Workflow History', function() {
150163
.get('/api/domain/canary/workflows/ci%2Fdemo/run1/history')
151164
.expect(200)
152165
.expect({
166+
archived: null,
153167
history: { events: wfHistoryJson },
154168
nextPageToken: 'cGFnZTI='
155169
})

server/test/workflows.test.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,13 @@ describe('Listing Workflows', function() {
1010
startTime: dateToLong('2017-11-10T21:30:00.000Z'),
1111
closeTime: null,
1212
closeStatus: null,
13-
historyLength: null
13+
historyLength: null,
14+
autoResetPoints: null,
15+
executionTime: null,
16+
memo: null,
17+
parentDomainId: null,
18+
parentExecution: null,
19+
searchAttributes: null
1420
},
1521
demoExecJson = Object.assign({}, demoExecThrift, {
1622
startTime: '2017-11-10T21:30:00.000Z',

0 commit comments

Comments
 (0)