Fix workflow history flaky test (#861)

* await for resolver

* add verification checks

* remove unused changes and fix docker typo

Author: Assem-Uber

Dockerfile

@@ -34,7 +34,7 @@ COPY . .
 # Learn more here: https://nextjs.org/telemetry
 # Uncomment the following line in case you want to disable telemetry during the build.
 ENV NEXT_TELEMETRY_DISABLED 1
-# optimize Build size by inclduding only required resources
+# optimize Build size by including only required resources
 
 RUN npm run generate:idl
 RUN npm run build
@@ -68,4 +68,4 @@ COPY --from=builder --chown=nextjs:nodejs /app/.next/static ./.next/static
 USER nextjs
 
 
-CMD  ["sh","-c", "CADENCE_WEB_PORT=${CADENCE_WEB_PORT:-8088} CADENCE_WEB_HOSTNAME=${CADENCE_WEB_HOSTNAME:-0.0.0.0} exec node server.js"]
+CMD  ["sh","-c", "CADENCE_WEB_PORT=${CADENCE_WEB_PORT:-8088} CADENCE_WEB_HOSTNAME=${CADENCE_WEB_HOSTNAME:-0.0.0.0} exec node server.js"]

src/views/workflow-history/__tests__/workflow-history.test.tsx

@@ -142,6 +142,11 @@ describe('WorkflowHistory', () => {
       hasNextPage: true,
     });
 
+    await waitFor(() => {
+      expect(screen.getByText('keep loading events')).toBeInTheDocument();
+    });
+
+    // Load first page
     await act(async () => {
       const resolver = getRequestResolver();
       resolver({
@@ -154,9 +159,11 @@ describe('WorkflowHistory', () => {
       });
     });
 
-    const loadingIndicator = await screen.findByText('keep loading events');
-    expect(loadingIndicator).toBeInTheDocument();
+    await waitFor(() => {
+      expect(screen.getByText('keep loading events')).toBeInTheDocument();
+    });
 
+    // Load second page
     await act(async () => {
       const secondPageResolver = getRequestResolver();
       secondPageResolver({
@@ -205,6 +212,7 @@ async function setup({
   const getRequestResolver = () => requestResolver;
   const getRequestRejector = () => requestRejector;
   let requestIndex = -1;
+
   const renderResult = render(
     <Suspense fallback={'Suspense placeholder'}>
       <WorkflowHistory
@@ -225,10 +233,12 @@ async function setup({
           mockOnce: false,
           httpResolver: async () => {
             requestIndex = requestIndex + 1;
+
             if (requestIndex > 0 && resolveLoadMoreManually) {
               return await new Promise((resolve, reject) => {
                 requestResolver = (result: GetWorkflowHistoryResponse) =>
                   resolve(HttpResponse.json(result, { status: 200 }));
+
                 requestRejector = () =>
                   reject(
                     HttpResponse.json(
@@ -238,11 +248,12 @@ async function setup({
                   );
               });
             } else {
-              if (error)
+              if (error) {
                 return HttpResponse.json(
                   { message: 'Failed to fetch workflow history' },
                   { status: 500 }
                 );
+              }
 
               return HttpResponse.json(
                 {