Skip to content

Commit cb4439d

Browse files
Misc fixes for Domain Page Extended Metadata (#914)
* Fix ListTableNested item label styling to use regular weight labels instead of bold ones * Add a placeholder for empty descriptions to DomainPageMetadataDescription * Use direct strings for button props instead of the enums
1 parent ba49bcf commit cb4439d

File tree

4 files changed

+19
-6
lines changed

4 files changed

+19
-6
lines changed

src/components/list-table-nested/list-table-nested.styles.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export const styled = {
4040
'div',
4141
({ $theme }: { $theme: Theme }): StyleObject => ({
4242
...$theme.typography.LabelSmall,
43-
fontWeight: '700',
4443
})
4544
),
4645
Description: createStyled(

src/views/domain-page/domain-page-metadata-description/__tests__/domain-page-metadata-description.test.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ describe(DomainPageMetadataDescription.name, () => {
1414
expect(screen.getByText('Test Description')).toBeInTheDocument();
1515
});
1616

17+
it('displays "No description" when description is empty', () => {
18+
render(<DomainPageMetadataDescription description="" />);
19+
expect(screen.getByText('No description')).toBeInTheDocument();
20+
});
21+
1722
it('renders the edit button with correct link', () => {
1823
render(<DomainPageMetadataDescription description="Test Description" />);
1924
const button = screen.getByText('Edit in Settings');

src/views/domain-page/domain-page-metadata-description/domain-page-metadata-description.styles.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,7 @@ export const styled = {
77
alignItems: 'flex-start',
88
gap: $theme.sizing.scale500,
99
})),
10+
DescriptionPlaceholder: createStyled('div', ({ $theme }) => ({
11+
color: $theme.colors.contentTertiary,
12+
})),
1013
};

src/views/domain-page/domain-page-metadata-description/domain-page-metadata-description.tsx

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Button, KIND, SHAPE, SIZE } from 'baseui/button';
1+
import { Button } from 'baseui/button';
22
import Link from 'next/link';
33
import { useParams } from 'next/navigation';
44
import { MdEdit } from 'react-icons/md';
@@ -14,11 +14,17 @@ export default function DomainPageMetadataDescription(props: Props) {
1414

1515
return (
1616
<styled.DescriptionContainer>
17-
{props.description}
17+
{props.description !== '' ? (
18+
props.description
19+
) : (
20+
<styled.DescriptionPlaceholder>
21+
No description
22+
</styled.DescriptionPlaceholder>
23+
)}
1824
<Button
19-
kind={KIND.secondary}
20-
shape={SHAPE.pill}
21-
size={SIZE.mini}
25+
kind="secondary"
26+
shape="pill"
27+
size="mini"
2228
startEnhancer={<MdEdit />}
2329
$as={Link}
2430
href={`/domains/${encodedDomain}/${encodedCluster}/settings`}

0 commit comments

Comments
 (0)