Support resetting to binary checksum (#887)

Allow resetting to binary checksum

Author: Assem-Uber

src/views/workflow-actions/__tests__/workflow-actions.test.tsx

@@ -2,9 +2,9 @@ import React from 'react';
 
 import { HttpResponse } from 'msw';
 
-import { act, render, screen, userEvent, waitFor } from '@/test-utils/rtl';
+import { render, screen, userEvent, waitFor } from '@/test-utils/rtl';
 
-import { describeWorkflowResponse } from '@/views/workflow-page/__fixtures__/describe-workflow-response';
+import { mockDescribeWorkflowResponse } from '@/views/workflow-page/__fixtures__/describe-workflow-response';
 
 import { mockWorkflowDetailsParams } from '../../workflow-page/__fixtures__/workflow-details-params';
 import { mockWorkflowActionsConfig } from '../__fixtures__/workflow-actions-config';
@@ -126,7 +126,7 @@ function setup({
               { status: 500 }
             );
           } else {
-            return HttpResponse.json(describeWorkflowResponse, {
+            return HttpResponse.json(mockDescribeWorkflowResponse, {
               status: 200,
             });
           }

src/views/workflow-actions/config/workflow-actions.config.ts

@@ -109,7 +109,19 @@ export const resetWorkflowActionConfig: WorkflowAction<
     withForm: true,
     form: WorkflowActionResetForm,
     formSchema: resetWorkflowFormSchema,
-    transformFormDataToSubmission: (v) => v,
+    transformFormDataToSubmission: (
+      formData: ResetWorkflowFormData
+    ): ResetWorkflowSubmissionData => {
+      const decisionFinishEventId =
+        formData.resetType === 'BinaryChecksum'
+          ? formData.binaryChecksumFirstDecisionCompletedId
+          : formData.decisionFinishEventId;
+      return {
+        reason: formData.reason,
+        decisionFinishEventId,
+        skipSignalReapply: formData.skipSignalReapply,
+      };
+    },
   },
   icon: MdRefresh,
   getRunnableStatus: () => 'RUNNABLE',

src/views/workflow-actions/workflow-action-reset-form/__tests__/workflow-action-reset-form.test.tsx

@@ -1,12 +1,44 @@
 import React from 'react';
 
+import { HttpResponse } from 'msw';
 import { type FieldErrors, useForm } from 'react-hook-form';
 
 import { render, screen, userEvent } from '@/test-utils/rtl';
 
+import { type ResetPoints } from '@/__generated__/proto-ts/uber/cadence/api/v1/ResetPoints';
+import { mockDescribeWorkflowResponse } from '@/views/workflow-page/__fixtures__/describe-workflow-response';
+
 import WorkflowActionResetForm from '../workflow-action-reset-form';
 import { type ResetWorkflowFormData } from '../workflow-action-reset-form.types';
 
+const resetPoints = {
+  points: [
+    {
+      binaryChecksum: 'test-binary-checksum',
+      runId: 'test-run-id',
+      firstDecisionCompletedId: '4',
+      resettable: false,
+      createdTime: null,
+      expiringTime: null,
+    },
+    {
+      binaryChecksum: 'test-binary-checksum-2',
+      runId: 'test-run-id',
+      firstDecisionCompletedId: '7',
+      resettable: true,
+      createdTime: null,
+      expiringTime: null,
+    },
+    {
+      binaryChecksum: 'test-binary-checksum-3',
+      runId: 'test-run-id',
+      firstDecisionCompletedId: '10',
+      resettable: true,
+      createdTime: null,
+      expiringTime: null,
+    },
+  ],
+};
 describe('WorkflowActionResetForm', () => {
   it('renders all form fields correctly', async () => {
     await setup({});
@@ -68,6 +100,84 @@ describe('WorkflowActionResetForm', () => {
     });
     expect(skipSignalCheckbox).not.toBeChecked();
   });
+
+  it('switches between Event ID and Binary Checksum reset types', async () => {
+    const { user } = await setup({});
+
+    const binaryChecksumRadio = screen.getByRole('radio', {
+      name: 'Binary Checksum',
+    });
+    await user.click(binaryChecksumRadio);
+
+    expect(
+      screen.queryByPlaceholderText('Find Event ID')
+    ).not.toBeInTheDocument();
+    expect(screen.getByText('Select binary checksum')).toBeInTheDocument();
+
+    const eventIdRadio = screen.getByRole('radio', {
+      name: 'Event ID',
+    });
+    await user.click(eventIdRadio);
+
+    expect(screen.getByPlaceholderText('Find Event ID')).toBeInTheDocument();
+    expect(
+      screen.queryByText('Select binary checksum')
+    ).not.toBeInTheDocument();
+  });
+
+  it('lists only resettable points', async () => {
+    const { user } = await setup({ resetPoints });
+
+    const binaryChecksumRadio = screen.getByRole('radio', {
+      name: 'Binary Checksum',
+    });
+    await user.click(binaryChecksumRadio);
+
+    const binaryChecksumSelect = screen.getByRole('combobox', {
+      name: 'Select binary checksum',
+    });
+    await user.click(binaryChecksumSelect);
+
+    expect((await screen.findAllByRole('option')).length).toBe(2);
+    expect(screen.getByText('test-binary-checksum-2')).toBeInTheDocument();
+    expect(screen.getByText('test-binary-checksum-3')).toBeInTheDocument();
+  });
+
+  it('handles error state for bad binary fetch', async () => {
+    const { user } = await setup({ isError: true });
+
+    const binaryChecksumRadio = screen.getByRole('radio', {
+      name: 'Binary Checksum',
+    });
+    await user.click(binaryChecksumRadio);
+
+    const binaryChecksumSelect = screen.getByRole('combobox', {
+      name: 'Select binary checksum',
+    });
+
+    await user.click(binaryChecksumSelect);
+
+    expect(
+      await screen.findByText('Failed to load binary checksums')
+    ).toBeInTheDocument();
+  });
+
+  it('handles empty state', async () => {
+    const { user } = await setup({ resetPoints: { points: [] } });
+
+    const binaryChecksumRadio = screen.getByRole('radio', {
+      name: 'Binary Checksum',
+    });
+    await user.click(binaryChecksumRadio);
+
+    const binaryChecksumSelect = screen.getByRole('combobox', {
+      name: 'Select binary checksum',
+    });
+
+    await user.click(binaryChecksumSelect);
+
+    expect(await screen.findByText('No results found')).toBeInTheDocument();
+  });
 });
 
 type TestProps = {
@@ -83,6 +193,7 @@ function TestWrapper({ formErrors, formData }: TestProps) {
   return (
     <WorkflowActionResetForm
       control={methods.control}
+      clearErrors={methods.clearErrors}
       fieldErrors={formErrors}
       formData={formData}
       cluster="test-cluster"
@@ -99,11 +210,41 @@ async function setup({
     decisionFinishEventId: '',
     reason: '',
     skipSignalReapply: false,
+    resetType: 'EventId',
   },
-}: Partial<TestProps>) {
+  resetPoints = mockDescribeWorkflowResponse.workflowExecutionInfo
+    .autoResetPoints,
+  isError = false,
+}: Partial<TestProps> & { resetPoints?: ResetPoints; isError?: boolean }) {
   const user = userEvent.setup();
 
-  render(<TestWrapper formErrors={formErrors} formData={formData} />);
+  const describeWorkflowResponse = {
+    ...mockDescribeWorkflowResponse,
+    workflowExecutionInfo: {
+      ...mockDescribeWorkflowResponse.workflowExecutionInfo,
+      autoResetPoints: resetPoints,
+    },
+  };
+  render(<TestWrapper formErrors={formErrors} formData={formData} />, {
+    endpointsMocks: [
+      {
+        path: '/api/domains/:domain/:cluster/workflows/:workflowId/:runId',
+        httpMethod: 'GET',
+        httpResolver: () => {
+          if (isError) {
+            return HttpResponse.json(
+              { message: 'Failed to fetch workflow summary' },
+              { status: 500 }
+            );
+          } else {
+            return HttpResponse.json(describeWorkflowResponse, {
+              status: 200,
+            });
+          }
+        },
+      },
+    ],
+  });
 
   return { user };
 }

src/views/workflow-actions/workflow-action-reset-form/schemas/reset-workflow-form-schema.ts

@@ -1,7 +1,21 @@
 import { z } from 'zod';
 
-export const resetWorkflowFormSchema = z.object({
-  decisionFinishEventId: z.string().min(1),
+const baseSchema = z.object({
   reason: z.string().min(1),
   skipSignalReapply: z.boolean().optional(),
 });
+
+const eventIdSchema = baseSchema.extend({
+  resetType: z.literal('EventId'),
+  decisionFinishEventId: z.string().min(1),
+});
+
+const binaryChecksumSchema = baseSchema.extend({
+  resetType: z.literal('BinaryChecksum'),
+  binaryChecksumFirstDecisionCompletedId: z.string().min(1),
+});
+
+export const resetWorkflowFormSchema = z.discriminatedUnion('resetType', [
+  eventIdSchema,
+  binaryChecksumSchema,
+]);