Skip to content

Commit daa4104

Browse files
Replace usage of custom hooks with useConfigValue (#988)
* Replace usage of custom hooks with useConfigValue * remove unused file * replace usage for useSuspenseClusterConfig * fix lint --------- Co-authored-by: Adhitya Mamallan <[email protected]>
1 parent 87c4ca1 commit daa4104

File tree

12 files changed

+23
-122
lines changed

12 files changed

+23
-122
lines changed

src/views/domain-page/domain-page-context-provider/domain-page-context-provider.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use client';
22
import { createContext, useMemo } from 'react';
33

4-
import useSuspenseClusterConfig from '@/views/shared/hooks/use-suspense-cluster-config';
4+
import useSuspenseConfigValue from '@/hooks/use-config-value/use-suspense-config-value';
55

66
import { type DomainPageContextType } from './domain-page-context-provider.types';
77

@@ -14,7 +14,7 @@ export default function DomainPageContextProvider({
1414
}: {
1515
children: any;
1616
}) {
17-
const { data: CLUSTERS_PUBLIC } = useSuspenseClusterConfig();
17+
const { data: CLUSTERS_PUBLIC } = useSuspenseConfigValue('CLUSTERS_PUBLIC');
1818
const ctx = useMemo(() => {
1919
return { pageConfig: { CLUSTERS_PUBLIC } };
2020
}, [CLUSTERS_PUBLIC]);

src/views/domain-page/domain-page-help/domain-page-help.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,18 @@ import { Button } from 'baseui/button';
22
import { StatefulPopover } from 'baseui/popover';
33
import { MdArrowDropDown, MdSupport } from 'react-icons/md';
44

5+
import useSuspenseConfigValue from '@/hooks/use-config-value/use-suspense-config-value';
6+
57
import domainPageHelpMenuConfig from '../config/domain-page-help-menu.config';
68
import DomainPageHelpItemButton from '../domain-page-help-item-button/domain-page-help-item-button';
7-
import useSuspenseIsExtendedMetadataEnabled from '../hooks/use-is-extended-metadata-enabled/use-suspense-is-extended-metadata-enabled';
89

910
import { overrides, styled } from './domain-page-help.styles';
1011
import { type DomainPageHelpGroup } from './domain-page-help.types';
1112

1213
export default function DomainPageHelp() {
1314
const {
1415
data: { metadata: isExtendedMetadataEnabled },
15-
} = useSuspenseIsExtendedMetadataEnabled();
16+
} = useSuspenseConfigValue('EXTENDED_DOMAIN_INFO_ENABLED');
1617

1718
if (!isExtendedMetadataEnabled) return null;
1819

src/views/domain-page/domain-page-metadata/domain-page-metadata.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import React from 'react';
33

44
import { useSuspenseQueries } from '@tanstack/react-query';
55

6+
import getConfigValueQueryOptions from '@/hooks/use-config-value/get-config-value-query-options';
67
import getDomainDescriptionQueryOptions from '@/views/shared/hooks/use-domain-description/get-domain-description-query-options';
78

89
import { type DomainPageTabContentProps } from '../domain-page-content/domain-page-content.types';
910
import DomainPageMetadataTable from '../domain-page-metadata-table/domain-page-metadata-table';
10-
import getIsExtendedMetadataEnabledQueryOptions from '../hooks/use-is-extended-metadata-enabled/get-is-extended-metadata-enabled-query-options';
1111

1212
import { type DomainMetadata } from './domain-page-metadata.types';
1313

@@ -23,7 +23,10 @@ export default function DomainPageMetadata(props: DomainPageTabContentProps) {
2323
domain: props.domain,
2424
cluster: props.cluster,
2525
}),
26-
getIsExtendedMetadataEnabledQueryOptions(),
26+
getConfigValueQueryOptions({
27+
key: 'EXTENDED_DOMAIN_INFO_ENABLED',
28+
args: undefined,
29+
}),
2730
],
2831
});
2932

src/views/domain-page/hooks/use-is-extended-metadata-enabled/get-is-extended-metadata-enabled-query-options.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/views/domain-page/hooks/use-is-extended-metadata-enabled/use-suspense-is-extended-metadata-enabled.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

src/views/domains-page/domains-page-context-provider/domains-page-context-provider.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use client';
22
import { createContext, useMemo } from 'react';
33

4-
import useSuspenseClusterConfig from '@/views/shared/hooks/use-suspense-cluster-config';
4+
import useSuspenseConfigValue from '@/hooks/use-config-value/use-suspense-config-value';
55

66
import { type DomainsPageContextType } from './domains-page-context-provider.types';
77

@@ -14,7 +14,7 @@ export default function DomainsPageContextProvider({
1414
}: {
1515
children: any;
1616
}) {
17-
const { data: CLUSTERS_PUBLIC } = useSuspenseClusterConfig();
17+
const { data: CLUSTERS_PUBLIC } = useSuspenseConfigValue('CLUSTERS_PUBLIC');
1818
const ctx = useMemo(() => {
1919
return { pageConfig: { CLUSTERS_PUBLIC } };
2020
}, [CLUSTERS_PUBLIC]);

src/views/shared/hooks/use-suspense-cluster-config.ts

Lines changed: 0 additions & 29 deletions
This file was deleted.

src/views/shared/hooks/use-workflow-diagnostics-issues-count.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,15 @@
11
import { useMemo } from 'react';
22

3-
import { useQuery } from '@tanstack/react-query';
4-
3+
import useConfigValue from '@/hooks/use-config-value/use-config-value';
54
import useDiagnoseWorkflow from '@/views/workflow-diagnostics/hooks/use-diagnose-workflow/use-diagnose-workflow';
65
import { type UseDiagnoseWorkflowParams } from '@/views/workflow-diagnostics/hooks/use-diagnose-workflow/use-diagnose-workflow.types';
76
import { useDescribeWorkflow } from '@/views/workflow-page/hooks/use-describe-workflow';
8-
import getIsWorkflowDiagnosticsEnabledQueryOptions from '@/views/workflow-page/hooks/use-is-workflow-diagnostics-enabled/get-is-workflow-diagnostics-enabled-query-options';
97

108
export default function useWorkflowDiagnosticsIssuesCount(
119
params: UseDiagnoseWorkflowParams
1210
): number | undefined {
13-
const { data: isWorkflowDiagnosticsEnabled } = useQuery(
14-
getIsWorkflowDiagnosticsEnabledQueryOptions()
11+
const { data: isWorkflowDiagnosticsEnabled } = useConfigValue(
12+
'WORKFLOW_DIAGNOSTICS_ENABLED'
1513
);
1614

1715
const { data: describeWorkflowResponse } = useDescribeWorkflow(params);

src/views/workflow-diagnostics/workflow-diagnostics.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
import React from 'react';
44

55
import SectionLoadingIndicator from '@/components/section-loading-indicator/section-loading-indicator';
6+
import useSuspenseConfigValue from '@/hooks/use-config-value/use-suspense-config-value';
67
import { type WorkflowPageTabContentProps } from '@/views/workflow-page/workflow-page-tab-content/workflow-page-tab-content.types';
78

89
import { useSuspenseDescribeWorkflow } from '../workflow-page/hooks/use-describe-workflow';
9-
import useSuspenseIsWorkflowDiagnosticsEnabled from '../workflow-page/hooks/use-is-workflow-diagnostics-enabled/use-suspense-is-workflow-diagnostics-enabled';
1010

1111
import useDiagnoseWorkflow from './hooks/use-diagnose-workflow/use-diagnose-workflow';
1212
import WorkflowDiagnosticsContent from './workflow-diagnostics-content/workflow-diagnostics-content';
@@ -19,8 +19,9 @@ import {
1919
export default function WorkflowDiagnostics({
2020
params: { domain, cluster, workflowId, runId },
2121
}: WorkflowPageTabContentProps) {
22-
const { data: isWorkflowDiagnosticsEnabled } =
23-
useSuspenseIsWorkflowDiagnosticsEnabled();
22+
const { data: isWorkflowDiagnosticsEnabled } = useSuspenseConfigValue(
23+
'WORKFLOW_DIAGNOSTICS_ENABLED'
24+
);
2425

2526
const {
2627
data: { workflowExecutionInfo },

src/views/workflow-page/hooks/use-is-workflow-diagnostics-enabled/get-is-workflow-diagnostics-enabled-query-options.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)