diff --git a/src/views/workflow-history/workflow-history-event-details-json/__tests__/workflow-history-event-details-json.test.tsx b/src/views/workflow-history/workflow-history-event-details-json/__tests__/workflow-history-event-details-json.test.tsx index 388745ab2..d6335aae1 100644 --- a/src/views/workflow-history/workflow-history-event-details-json/__tests__/workflow-history-event-details-json.test.tsx +++ b/src/views/workflow-history/workflow-history-event-details-json/__tests__/workflow-history-event-details-json.test.tsx @@ -4,7 +4,7 @@ import { render } from '@/test-utils/rtl'; import losslessJsonStringify from '@/utils/lossless-json-stringify'; -import WorkflowSummaryTabJsonView from '../workflow-history-event-details-json'; +import WorkflowHistoryEventDetailsJson from '../workflow-history-event-details-json'; jest.mock('@/components/copy-text-button/copy-text-button', () => jest.fn(({ textToCopy }) =>
Copy Button: {textToCopy}
) @@ -22,7 +22,7 @@ describe('WorkflowHistoryEventDetailsJson', () => { it('renders correctly with initial props', () => { const { getByText } = render( - + ); expect(getByText('PrettyJson Mock')).toBeInTheDocument(); @@ -30,7 +30,7 @@ describe('WorkflowHistoryEventDetailsJson', () => { it('renders copy text button and pass the correct text', () => { const { getByText } = render( - + ); const copyButton = getByText(/Copy Button/); diff --git a/src/views/workflow-page/config/workflow-page-tabs.config.ts b/src/views/workflow-page/config/workflow-page-tabs.config.ts index 46c944e2b..f49be822f 100644 --- a/src/views/workflow-page/config/workflow-page-tabs.config.ts +++ b/src/views/workflow-page/config/workflow-page-tabs.config.ts @@ -11,7 +11,7 @@ import WorkflowDiagnostics from '@/views/workflow-diagnostics/workflow-diagnosti import WorkflowHistoryWrapper from '@/views/workflow-history/workflow-history-wrapper/workflow-history-wrapper'; import WorkflowQueries from '@/views/workflow-queries/workflow-queries'; import WorkflowStackTrace from '@/views/workflow-stack-trace/workflow-stack-trace'; -import WorkflowSummaryTab from '@/views/workflow-summary-tab/workflow-summary-tab'; +import WorkflowSummary from '@/views/workflow-summary/workflow-summary'; import getWorkflowPageErrorConfig from '../helpers/get-workflow-page-error-config'; import WorkflowPageDiagnosticsBadge from '../workflow-page-diagnostics-badge/workflow-page-diagnostics-badge'; @@ -24,7 +24,7 @@ const workflowPageTabsConfig: WorkflowPageTabsConfig< summary: { title: 'Summary', artwork: MdListAlt, - content: WorkflowSummaryTab, + content: WorkflowSummary, getErrorConfig: (err) => getWorkflowPageErrorConfig( err, diff --git a/src/views/workflow-summary-tab/__tests__/workflow-summary-tab.test.tsx b/src/views/workflow-summary/__tests__/workflow-summary.test.tsx similarity index 72% rename from src/views/workflow-summary-tab/__tests__/workflow-summary-tab.test.tsx rename to src/views/workflow-summary/__tests__/workflow-summary.test.tsx index d3dab8495..b754109b2 100644 --- a/src/views/workflow-summary-tab/__tests__/workflow-summary-tab.test.tsx +++ b/src/views/workflow-summary/__tests__/workflow-summary.test.tsx @@ -7,23 +7,22 @@ import { type GetWorkflowExecutionHistoryResponse } from '@/__generated__/proto- import { startWorkflowExecutionEvent } from '@/views/workflow-history/__fixtures__/workflow-history-single-events'; import { type WorkflowPageTabContentProps } from '@/views/workflow-page/workflow-page-tab-content/workflow-page-tab-content.types'; -import WorkflowSummaryTab from '../workflow-summary-tab'; +import WorkflowSummary from '../workflow-summary'; -jest.mock('../workflow-summary-tab-details/workflow-summary-tab-details', () => - jest.fn(() =>
MockWorkflowSummaryTabDetails
) +jest.mock('../workflow-summary-details/workflow-summary-details', () => + jest.fn(() =>
MockWorkflowSummaryDetails
) ); -jest.mock( - '../workflow-summary-tab-json-view/workflow-summary-tab-json-view', - () => jest.fn(() =>
MockWorkflowSummaryTabJsonView
) +jest.mock('../workflow-summary-json-view/workflow-summary-json-view', () => + jest.fn(() =>
MockWorkflowSummaryJsonView
) ); jest.mock( - '../workflow-summary-tab-diagnostics-banner/workflow-summary-tab-diagnostics-banner', - () => jest.fn(() =>
MockWorkflowSummaryTabDiagnosticsBanner
) + '../workflow-summary-diagnostics-banner/workflow-summary-diagnostics-banner', + () => jest.fn(() =>
MockWorkflowSummaryDiagnosticsBanner
) ); -describe('WorkflowSummaryTab', () => { +describe('WorkflowSummary', () => { beforeEach(() => { jest.clearAllMocks(); }); @@ -39,7 +38,7 @@ describe('WorkflowSummaryTab', () => { it('should render tab deatils, JSON view, and diagnostics banner', async () => { render( - + , { endpointsMocks: [ @@ -70,13 +69,13 @@ describe('WorkflowSummaryTab', () => { } ); expect( - await screen.findByText('MockWorkflowSummaryTabDetails') + await screen.findByText('MockWorkflowSummaryDetails') ).toBeInTheDocument(); expect( - await screen.findByText('MockWorkflowSummaryTabJsonView') + await screen.findByText('MockWorkflowSummaryJsonView') ).toBeInTheDocument(); expect( - await screen.findByText('MockWorkflowSummaryTabDiagnosticsBanner') + await screen.findByText('MockWorkflowSummaryDiagnosticsBanner') ).toBeInTheDocument(); }); }); diff --git a/src/views/workflow-summary-tab/config/workflow-summary-tab-details.config.ts b/src/views/workflow-summary/config/workflow-summary-details.config.ts similarity index 95% rename from src/views/workflow-summary-tab/config/workflow-summary-tab-details.config.ts rename to src/views/workflow-summary/config/workflow-summary-details.config.ts index d18e1faa2..38ac7ec67 100644 --- a/src/views/workflow-summary-tab/config/workflow-summary-tab-details.config.ts +++ b/src/views/workflow-summary/config/workflow-summary-details.config.ts @@ -6,9 +6,9 @@ import WorkflowStatusTag from '@/views/shared/workflow-status-tag/workflow-statu import getWorkflowStatusTagProps from '@/views/workflow-page/helpers/get-workflow-status-tag-props'; import WorkflowEventDetailsExecutionLink from '../../shared/workflow-event-details-execution-link/workflow-event-details-execution-link'; -import { type WorkflowSummaryTabDetailsConfig } from '../workflow-summary-tab-details/workflow-summary-tab-details.types'; +import { type WorkflowSummaryDetailsConfig } from '../workflow-summary-details/workflow-summary-details.types'; -const workflowSummaryTabDetailsConfig: WorkflowSummaryTabDetailsConfig[] = [ +const workflowSummaryDetailsConfig: WorkflowSummaryDetailsConfig[] = [ { key: 'status', getLabel: () => 'Status', @@ -146,4 +146,4 @@ const workflowSummaryTabDetailsConfig: WorkflowSummaryTabDetailsConfig[] = [ }, ]; -export default workflowSummaryTabDetailsConfig; +export default workflowSummaryDetailsConfig; diff --git a/src/views/workflow-summary-tab/helpers/__tests__/get-workflow-result-json.test.ts b/src/views/workflow-summary/helpers/__tests__/get-workflow-result-json.test.ts similarity index 100% rename from src/views/workflow-summary-tab/helpers/__tests__/get-workflow-result-json.test.ts rename to src/views/workflow-summary/helpers/__tests__/get-workflow-result-json.test.ts diff --git a/src/views/workflow-summary-tab/helpers/get-workflow-result-json.ts b/src/views/workflow-summary/helpers/get-workflow-result-json.ts similarity index 100% rename from src/views/workflow-summary-tab/helpers/get-workflow-result-json.ts rename to src/views/workflow-summary/helpers/get-workflow-result-json.ts diff --git a/src/views/workflow-summary-tab/workflow-summary-tab-details/__tests__/workflow-summary-tab-details.test.tsx b/src/views/workflow-summary/workflow-summary-details/__tests__/workflow-summary-details.test.tsx similarity index 90% rename from src/views/workflow-summary-tab/workflow-summary-tab-details/__tests__/workflow-summary-tab-details.test.tsx rename to src/views/workflow-summary/workflow-summary-details/__tests__/workflow-summary-details.test.tsx index 0bedeef32..0edd3cd57 100644 --- a/src/views/workflow-summary-tab/workflow-summary-tab-details/__tests__/workflow-summary-tab-details.test.tsx +++ b/src/views/workflow-summary/workflow-summary-details/__tests__/workflow-summary-details.test.tsx @@ -10,14 +10,14 @@ import { startWorkflowExecutionEvent, } from '@/views/workflow-history/__fixtures__/workflow-history-single-events'; -import WorkflowSummaryTabDetails from '../workflow-summary-tab-details'; +import WorkflowSummaryDetails from '../workflow-summary-details'; import { - type WorkflowSummaryTabDetailsConfig, + type WorkflowSummaryDetailsConfig, type Props, -} from '../workflow-summary-tab-details.types'; +} from '../workflow-summary-details.types'; jest.mock( - '../../config/workflow-summary-tab-details.config', + '../../config/workflow-summary-details.config', () => [ { @@ -37,7 +37,7 @@ jest.mock( getLabel: () => 'Hidden Label 3', valueComponent: () => Hidden Value 3, }, - ] satisfies WorkflowSummaryTabDetailsConfig[] + ] satisfies WorkflowSummaryDetailsConfig[] ); const params: Props['decodedPageUrlParams'] = { @@ -56,7 +56,7 @@ const mockWorkflowDetails: DescribeWorkflowResponse = { workflowExecutionInfo: null, }; -describe('WorkflowSummaryTabDetails', () => { +describe('WorkflowSummaryDetails', () => { // TODO @assem.hafez enhance typing for formattedFirstHistoryEvent //@ts-expect-error - TS is complaining about the type of formattedFirstHistoryEvent const formattedFirstHistoryEvent: FormattedHistoryEventForType<'WorkflowExecutionStarted'> = @@ -66,7 +66,7 @@ describe('WorkflowSummaryTabDetails', () => { ); it('should render workflow type name from firstHistoryEvent', () => { render( - { it('should render all detail rows that are not hidden', () => { render( - { it('should not render detail rows that are hidden', () => { render( -
- {workflowSummaryTabDetailsConfig + {workflowSummaryDetailsConfig .filter( (c) => !c.hide || diff --git a/src/views/workflow-summary-tab/workflow-summary-tab-details/workflow-summary-tab-details.types.ts b/src/views/workflow-summary/workflow-summary-details/workflow-summary-details.types.ts similarity index 94% rename from src/views/workflow-summary-tab/workflow-summary-tab-details/workflow-summary-tab-details.types.ts rename to src/views/workflow-summary/workflow-summary-details/workflow-summary-details.types.ts index c3ff65d1d..48d26b4a8 100644 --- a/src/views/workflow-summary-tab/workflow-summary-tab-details/workflow-summary-tab-details.types.ts +++ b/src/views/workflow-summary/workflow-summary-details/workflow-summary-details.types.ts @@ -17,11 +17,11 @@ export type Props = { decodedPageUrlParams: WorkflowPageTabContentProps['params']; }; -export type WorkflowSummaryTabDetailsComponent = +export type WorkflowSummaryDetailsComponent = | keyof JSX.IntrinsicElements | React.JSXElementConstructor; -export type WorkflowSummaryTabDetailsConfig = { +export type WorkflowSummaryDetailsConfig = { key: string; getLabel: () => string; valueComponent: React.ComponentType<{ diff --git a/src/views/workflow-summary-tab/workflow-summary-tab-diagnostics-banner/__tests__/workflow-summary-tab-diagnostics-banner.test.tsx b/src/views/workflow-summary/workflow-summary-diagnostics-banner/__tests__/workflow-summary-diagnostics-banner.test.tsx similarity index 91% rename from src/views/workflow-summary-tab/workflow-summary-tab-diagnostics-banner/__tests__/workflow-summary-tab-diagnostics-banner.test.tsx rename to src/views/workflow-summary/workflow-summary-diagnostics-banner/__tests__/workflow-summary-diagnostics-banner.test.tsx index 162f80a09..c3c875b0e 100644 --- a/src/views/workflow-summary-tab/workflow-summary-tab-diagnostics-banner/__tests__/workflow-summary-tab-diagnostics-banner.test.tsx +++ b/src/views/workflow-summary/workflow-summary-diagnostics-banner/__tests__/workflow-summary-diagnostics-banner.test.tsx @@ -4,13 +4,13 @@ import { render, screen } from '@/test-utils/rtl'; import * as useWorkflowDiagnosticsIssuesCountModule from '@/views/shared/hooks/use-workflow-diagnostics-issues-count'; -import WorkflowSummaryTabDiagnosticsBanner from '../workflow-summary-tab-diagnostics-banner'; +import WorkflowSummaryDiagnosticsBanner from '../workflow-summary-diagnostics-banner'; jest.mock('@/views/shared/hooks/use-workflow-diagnostics-issues-count', () => jest.fn(() => undefined) ); -describe(WorkflowSummaryTabDiagnosticsBanner.name, () => { +describe(WorkflowSummaryDiagnosticsBanner.name, () => { afterEach(() => { jest.restoreAllMocks(); }); @@ -62,7 +62,7 @@ function setup({ mockIssuesCount }: { mockIssuesCount?: number }) { .mockReturnValue(mockIssuesCount); const result = render( - jest.fn(({ textToCopy }) =>
Copy Button: {textToCopy}
) @@ -27,7 +27,7 @@ jest.mock('@/components/pretty-json-skeleton/pretty-json-skeleton', () => jest.fn(() =>
Mock JSON skeleton
) ); -describe('WorkflowSummaryTabJsonView Component', () => { +describe('WorkflowSummaryJsonView Component', () => { it('renders correctly with initial props', () => { const { getByText } = setup({}); @@ -115,7 +115,7 @@ const setup = ({ isArchived = false, }: Partial) => { return render( -
- - + Taskslist
*/}
-