Commit 0def4af
authored
fix: add nil pointer check for active cluster selection policy mappers (#7398)
<!-- Describe what has changed in this PR -->
**What changed?**
- add nil pointer check for active cluster selection policy mappers
<!-- Tell your future self why have you made these changes -->
**Why?**
We want to remove those fields from ActiveClusterSelectionPolicy.
However, the change is not safe to rollback because of the nil-pointer
dereference of the new data that doesn't have those fields serialized
into thrift. This change is to create a commit that's safe to be rolled
back.
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
unit tests
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
<!-- Is it notable for release? e.g. schema updates, configuration or
data migration required? If so, please mention it, and also update
CHANGELOG.md -->
**Release notes**
<!-- Is there any documentation updates should be made for config,
https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please
open an PR in https://github.com/cadence-workflow/cadence-docs -->
**Documentation Changes**1 parent 53d9b92 commit 0def4af
File tree
2 files changed
+5
-3
lines changed- common/types/mapper/thrift
2 files changed
+5
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7059 | 7059 | | |
7060 | 7060 | | |
7061 | 7061 | | |
7062 | | - | |
7063 | | - | |
7064 | | - | |
| 7062 | + | |
| 7063 | + | |
| 7064 | + | |
7065 | 7065 | | |
7066 | 7066 | | |
7067 | 7067 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3591 | 3591 | | |
3592 | 3592 | | |
3593 | 3593 | | |
| 3594 | + | |
| 3595 | + | |
3594 | 3596 | | |
3595 | 3597 | | |
3596 | 3598 | | |
| |||
0 commit comments