Don't treat missing PartitionConfig data as an error (#6576)

We intentionally set the isolation group to "" when we leak tasks, which causes forwarded tasks to report an error resolving the isolation group.

Additionally update the matching simulation to use the isolation group based load balancer and provide a default for the QpsTrackerInterval. 0s results in a panic on service startup.

Additionally specify an Identity on requests in the matching simulation so that poller history is tracked.

Author: natemort

common/partition/default-partitioner.go

@@ -84,7 +84,7 @@ func (r *defaultPartitioner) GetIsolationGroupByDomainID(ctx context.Context, sc
 	}
 	wfPartition := mapPartitionConfigToDefaultPartitionConfig(wfPartitionData)
 	if wfPartition.WorkflowStartIsolationGroup == "" || wfPartition.WFID == "" {
-		return "", ErrInvalidPartitionConfig
+		return "", nil
 	}
 
 	isolationGroups, err := r.isolationGroupState.IsolationGroupsByDomainID(ctx, pollerInfo.DomainID)

common/partition/default-partitioner_test.go

@@ -112,7 +112,7 @@ func TestDefaultPartitioner_GetIsolationGroupByDomainID(t *testing.T) {
 			stateAffordance:      func(state *isolationgroup.MockState) {},
 			incomingContext:      context.Background(),
 			expectedValue:        "",
-			expectedError:        errors.New("invalid partition config"),
+			expectedError:        nil,
 		},
 		"Error condition - No isolation-group information passed in 2": {
 			partitionKeyPassedIn: nil,

host/matching_simulation_test.go

@@ -128,7 +128,7 @@ func TestMatchingSimulation(t *testing.T) {
 		dynamicconfig.MatchingPartitionUpscaleSustainedDuration:    clusterConfig.MatchingConfig.SimulationConfig.PartitionUpscaleSustainedDuration,
 		dynamicconfig.MatchingPartitionDownscaleSustainedDuration:  clusterConfig.MatchingConfig.SimulationConfig.PartitionDownscaleSustainedDuration,
 		dynamicconfig.MatchingAdaptiveScalerUpdateInterval:         clusterConfig.MatchingConfig.SimulationConfig.AdaptiveScalerUpdateInterval,
-		dynamicconfig.MatchingQPSTrackerInterval:                   clusterConfig.MatchingConfig.SimulationConfig.QPSTrackerInterval,
+		dynamicconfig.MatchingQPSTrackerInterval:                   getQpsTrackerInterval(clusterConfig.MatchingConfig.SimulationConfig.QPSTrackerInterval),
 		dynamicconfig.TaskIsolationDuration:                        clusterConfig.MatchingConfig.SimulationConfig.TaskIsolationDuration,
 	}
 
@@ -426,6 +426,7 @@ func (s *MatchingSimulationSuite) poll(
 						Name: tasklist,
 						Kind: types.TaskListKindNormal.Ptr(),
 					},
+					Identity: pollerID,
 				},
 				IsolationGroup: pollerConfig.getIsolationGroup(),
 			})
@@ -672,6 +673,13 @@ func getPartitionTaskListName(root string, partition int) string {
 	return fmt.Sprintf("%v%v/%v", common.ReservedTaskListPrefix, root, partition)
 }
 
+func getQpsTrackerInterval(duration time.Duration) time.Duration {
+	if duration == 0 {
+		return 10 * time.Second
+	}
+	return duration
+}
+
 func randomlyPickKey(weights map[string]int) string {
 	// Calculate the total weight
 	totalWeight := 0

host/testdata/matching_simulation_zonal_isolation_few_pollers.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 30
         taskspersecond: 500

host/testdata/matching_simulation_zonal_isolation_many_pollers.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 30
         taskspersecond: 500

host/testdata/matching_simulation_zonal_isolation_single_partition.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 30
         taskspersecond: 500

host/testdata/matching_simulation_zonal_isolation_skew.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 10
         taskspersecond: 180

host/testdata/matching_simulation_zonal_isolation_skew_extreme.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 3
         taskspersecond: 50

host/testdata/matching_simulation_zonal_isolation_skew_forwarding.yaml

@@ -17,6 +17,7 @@ matchingconfig:
     localpollwaittime: 10ms
     localtaskwaittime: 10ms
     taskisolationduration: 1s
+    tasklistloadbalancerstrategy: isolation
     tasks:
       - numtaskgenerators: 10
         taskspersecond: 180