fix: Remove MaxCreatedTime from DomainAuditLogFilter (#7725)

<!-- 1-2 line summary of WHAT changed technically:
- Always link the relevant projects GitHub issue, unless it is a minor
bugfix
- Good: "Modified FailoverDomain mapper to allow null ActiveClusterName
#320"
- Bad: "added nil check" -->
**What changed?**
- Removed `MaxCreatedTime` from `DomainAuditLogFilter`

<!-- Your goal is to provide all the required context for a future
maintainer
to understand the reasons for making this change (see
https://cbea.ms/git-commit/#why-not-how).
How did this work previously (and what was wrong with it)? What has
changed, and why did you solve it
this way?
- Good: "Active-active domains have independent cluster attributes per
region. Previously,
modifying cluster attributes required spedifying the default
ActiveClusterName which
updates the global domain default. This prevents operators from updating
regional
configurations without affecting the primary cluster designation. This
change allows
  attribute updates to be independent of active cluster selection."
- Bad: "Improves domain handling" -->
**Why?**
- Remove duplicate logic between `MaxCreatedTime` and
`PageMaxCreatedTime` in domain audit filtering

Part of: #7602 

<!-- Include specific test commands and setup. Please include the exact
commands such that
another maintainer or contributor can reproduce the test steps taken. 
- e.g Unit test commands with exact invocation
`go test -v ./common/types/mapper/proto -run TestFailoverDomainRequest`
- For integration tests include setup steps and test commands
Example: "Started local server with `./cadence start`, then ran `make
test_e2e`"
- For local simulation testing include setup steps for the server and
how you ran the tests
- Good: Full commands that reviewers can copy-paste to verify
- Bad: "Tested locally" or "Added tests" -->
**How did you test it?**
- Unit tests: `go test -v ./common/persistence/sql -run
TestGetDomainAuditLogs TestSelectFromDomainAuditLogs`

<!-- If there are risks that the release engineer should know about
document them here.
For example:
- Has an API/IDL been modified? Is it backwards/forwards compatible? If
not, what are the repecussions?
- Has a schema change been introduced? Is it possible to roll back?
- Has a feature flag been re-used for a new purpose? 
- Is there a potential performance concern? Is the change modifying core
task processing logic?
- If truly N/A, you can mark it as such -->
**Potential risks**
N/A, logic stays the same

<!-- If this PR completes a user facing feature or changes functionality
add release notes here.
Your release notes should allow a user and the release engineer to
understand the changes with little context.
Always ensure that the description contains a link to the relevant
GitHub issue. -->
**Release notes**
N/A

<!-- Consider whether this change requires documentation updates in the
Cadence-Docs repo
- If yes: mention what needs updating (or link to docs PR in
cadence-docs repo)
- If in doubt, add a note about potential doc needs
- Only mark N/A if you're certain no docs are affected -->
**Documentation Changes**
N/A

---

## Reviewer Validation

**PR Description Quality** (check these before reviewing code):

- [x] **"What changed"** provides a clear 1-2 line summary
  - [x] Project Issue is linked
- [x] **"Why"** explains the full motivation with sufficient context
- [ ] **Testing is documented:**
- [ ] Unit test commands are included (with exact `go test` invocation)
- [ ] Integration test setup/commands included (if integration tests
were run)
  - [ ] Canary testing details included (if canary was mentioned)
- [x] **Potential risks** section is thoughtfully filled out (or
legitimately N/A)
- [x] **Release notes** included if this completes a user-facing feature
- [x] **Documentation** needs are addressed (or noted if uncertain)

Signed-off-by: Joanna Lau <118241363+joannalauu@users.noreply.github.com>

Author: joannalauu

common/persistence/sql/sql_domain_audit_store.go

@@ -119,7 +119,6 @@ func (m *sqlDomainAuditStore) GetDomainAuditLogs(
 		DomainID:           request.DomainID,
 		OperationType:      request.OperationType,
 		MinCreatedTime:     &minCreatedTime,
-		MaxCreatedTime:     &maxCreatedTime,
 		PageSize:           request.PageSize,
 		PageMaxCreatedTime: &pageMaxCreatedTime,
 		PageMinEventID:     &pageMinEventID,

common/persistence/sql/sql_domain_audit_store_test.go

@@ -226,7 +226,6 @@ func TestGetDomainAuditLogs(t *testing.T) {
 					DomainID:           "d1111111-1111-1111-1111-111111111111",
 					OperationType:      persistence.DomainAuditOperationTypeUpdate,
 					MinCreatedTime:     &minTime,
-					MaxCreatedTime:     &maxTime,
 					PageSize:           pageSize,
 					PageMaxCreatedTime: &maxTime,
 					PageMinEventID:     &maxUUID,
@@ -302,7 +301,6 @@ func TestGetDomainAuditLogs(t *testing.T) {
 					DomainID:           "d1111111-1111-1111-1111-111111111111",
 					OperationType:      persistence.DomainAuditOperationTypeUpdate,
 					MinCreatedTime:     &minTime,
-					MaxCreatedTime:     &maxTime,
 					PageSize:           pageSize2,
 					PageMaxCreatedTime: &expectedCreatedTime,
 					PageMinEventID:     &expectedEventID,

common/persistence/sql/sqlplugin/interfaces.go

@@ -604,7 +604,6 @@ type (
 		DomainID       string
 		OperationType  persistence.DomainAuditOperationType
 		MinCreatedTime *time.Time
-		MaxCreatedTime *time.Time
 		PageSize       int
 		// PageMaxCreatedTime and PageMinEventID are used to paginate Select queries
 		PageMaxCreatedTime *time.Time

common/persistence/sql/sqlplugin/postgres/domain_audit_log.go

@@ -37,16 +37,16 @@ const (
 		event_id, domain_id, state_before, state_before_encoding, state_after, state_after_encoding,
 		operation_type, created_time, last_updated_time, identity, identity_type, comment
 	FROM domain_audit_log
-	WHERE domain_id = $1 AND operation_type = $2 AND created_time >= $3 AND created_time < $4
-	AND (created_time < $5 OR (created_time = $5 AND event_id > $6))
+	WHERE domain_id = $1 AND operation_type = $2 AND created_time >= $3
+	AND (created_time < $4 OR (created_time = $4 AND event_id > $5))
 	ORDER BY created_time DESC, event_id ASC
-	LIMIT $7`
+	LIMIT $6`
 	_selectAllDomainAuditLogsQuery = `SELECT
 		event_id, domain_id, state_before, state_before_encoding, state_after, state_after_encoding,
 		operation_type, created_time, last_updated_time, identity, identity_type, comment
 	FROM domain_audit_log
-	WHERE domain_id = $1 AND operation_type = $2 AND created_time >= $3 AND created_time < $4
-	AND (created_time < $5 OR (created_time = $5 AND event_id > $6))
+	WHERE domain_id = $1 AND operation_type = $2 AND created_time >= $3
+	AND (created_time < $4 OR (created_time = $4 AND event_id > $5))
 	ORDER BY created_time DESC, event_id ASC`
 )
 
@@ -80,7 +80,6 @@ func (pdb *db) SelectFromDomainAuditLogs(
 		filter.DomainID,
 		filter.OperationType,
 		*filter.MinCreatedTime,
-		*filter.MaxCreatedTime,
 		*filter.PageMaxCreatedTime,
 		*filter.PageMinEventID,
 	}

common/persistence/sql/sqlplugin/postgres/domain_audit_log_test.go

@@ -171,7 +171,6 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 				DomainID:           domainID,
 				OperationType:      operationType,
 				MinCreatedTime:     &minTime,
-				MaxCreatedTime:     &maxTime,
 				PageSize:           2,
 				PageMaxCreatedTime: &defaultPageMaxCreatedTime,
 				PageMinEventID:     &defaultPageMinEventID,
@@ -182,7 +181,7 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 					sqlplugin.DbDefaultShard,
 					gomock.Any(),
 					_selectDomainAuditLogsQuery,
-					domainID, operationType, minTime, maxTime, defaultPageMaxCreatedTime, defaultPageMinEventID, 2,
+					domainID, operationType, minTime, defaultPageMaxCreatedTime, defaultPageMinEventID, 2,
 				).DoAndReturn(func(ctx context.Context, shardID int, dest interface{}, query string, args ...interface{}) error {
 					rows := dest.(*[]*sqlplugin.DomainAuditLogRow)
 					*rows = []*sqlplugin.DomainAuditLogRow{
@@ -224,7 +223,6 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 				DomainID:           domainID,
 				OperationType:      operationType,
 				MinCreatedTime:     &minTime,
-				MaxCreatedTime:     &maxTime,
 				PageSize:           0,
 				PageMaxCreatedTime: &createdTime2,
 				PageMinEventID:     &eventID2,
@@ -235,7 +233,7 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 					sqlplugin.DbDefaultShard,
 					gomock.Any(),
 					_selectAllDomainAuditLogsQuery,
-					domainID, operationType, minTime, maxTime, createdTime2, eventID2,
+					domainID, operationType, minTime, createdTime2, eventID2,
 				).DoAndReturn(func(ctx context.Context, shardID int, dest interface{}, query string, args ...interface{}) error {
 					rows := dest.(*[]*sqlplugin.DomainAuditLogRow)
 					*rows = []*sqlplugin.DomainAuditLogRow{
@@ -277,7 +275,6 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 				DomainID:           domainID,
 				OperationType:      operationType,
 				MinCreatedTime:     &minTime,
-				MaxCreatedTime:     &maxTime,
 				PageMaxCreatedTime: &defaultPageMaxCreatedTime,
 				PageMinEventID:     &defaultPageMinEventID,
 			},
@@ -287,7 +284,7 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 					sqlplugin.DbDefaultShard,
 					gomock.Any(),
 					_selectAllDomainAuditLogsQuery,
-					domainID, operationType, minTime, maxTime, defaultPageMaxCreatedTime, defaultPageMinEventID,
+					domainID, operationType, minTime, defaultPageMaxCreatedTime, defaultPageMinEventID,
 				).DoAndReturn(func(ctx context.Context, shardID int, dest interface{}, query string, args ...interface{}) error {
 					return nil
 				})
@@ -301,7 +298,6 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 				DomainID:           domainID,
 				OperationType:      operationType,
 				MinCreatedTime:     &minTime,
-				MaxCreatedTime:     &maxTime,
 				PageMaxCreatedTime: &defaultPageMaxCreatedTime,
 				PageMinEventID:     &defaultPageMinEventID,
 			},
@@ -311,7 +307,7 @@ func TestSelectFromDomainAuditLogs(t *testing.T) {
 					sqlplugin.DbDefaultShard,
 					gomock.Any(),
 					_selectAllDomainAuditLogsQuery,
-					domainID, operationType, minTime, maxTime, defaultPageMaxCreatedTime, defaultPageMinEventID,
+					domainID, operationType, minTime, defaultPageMaxCreatedTime, defaultPageMinEventID,
 				).Return(errors.New("select failed"))
 			},
 			wantRows: nil,