Skip to content

Commit 808d658

Browse files
committed
Trim metrics scope for task-ack histogram
Signed-off-by: zawadzki <zawadzki@uber.com>
1 parent b03f633 commit 808d658

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

common/metrics/defs.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2651,7 +2651,6 @@ const (
26512651
CacheRequests
26522652
CacheFailures
26532653
CacheLatency
2654-
ExponentialCacheLatency
26552654
CacheHitCounter
26562655
CacheMissCounter
26572656
CacheFullCounter
@@ -2733,7 +2732,6 @@ const (
27332732
ReplicationTasksReturned
27342733
ReplicationTasksReturnedDiff
27352734
ReplicationTasksAppliedLatency
2736-
ExponentialReplicationTasksAppliedLatency
27372735
ReplicationTasksBatchSize
27382736
ReplicationDynamicTaskBatchSizerDecision
27392737
ReplicationDLQFailed
@@ -3472,11 +3470,10 @@ var MetricDefs = map[ServiceIdx]map[MetricIdx]metricDefinition{
34723470
UnbufferReplicationTaskTimer: {metricName: "unbuffer_replication_tasks", metricType: Timer},
34733471
HistoryConflictsCounter: {metricName: "history_conflicts", metricType: Counter},
34743472
CompleteTaskFailedCounter: {metricName: "complete_task_fail_count", metricType: Counter},
3475-
CacheSize: {metricName: "cache_size", metricType: Gauge},
3473+
CacheSize: {metricName: "cache_size", metricType: Timer},
34763474
CacheRequests: {metricName: "cache_requests", metricType: Counter},
34773475
CacheFailures: {metricName: "cache_errors", metricType: Counter},
34783476
CacheLatency: {metricName: "cache_latency", metricType: Timer},
3479-
ExponentialCacheLatency: {metricName: "cache_latency_ns", metricType: Histogram, exponentialBuckets: Low1ms100s},
34803477
CacheHitCounter: {metricName: "cache_hit", metricType: Counter},
34813478
CacheMissCounter: {metricName: "cache_miss", metricType: Counter},
34823479
CacheFullCounter: {metricName: "cache_full", metricType: Counter},
@@ -3550,7 +3547,6 @@ var MetricDefs = map[ServiceIdx]map[MetricIdx]metricDefinition{
35503547
ReplicationTasksReturned: {metricName: "replication_tasks_returned", metricType: Timer},
35513548
ReplicationTasksReturnedDiff: {metricName: "replication_tasks_returned_diff", metricType: Timer},
35523549
ReplicationTasksAppliedLatency: {metricName: "replication_tasks_applied_latency", metricType: Timer},
3553-
ExponentialReplicationTasksAppliedLatency: {metricName: "replication_tasks_applied_latency_ns", metricType: Histogram, exponentialBuckets: Low1ms100s},
35543550
ReplicationTasksBatchSize: {metricName: "replication_tasks_batch_size", metricType: Gauge},
35553551
ReplicationDynamicTaskBatchSizerDecision: {metricName: "replication_dynamic_task_batch_sizer_decision", metricType: Counter},
35563552
ReplicationDLQFailed: {metricName: "replication_dlq_enqueue_failed", metricType: Counter},

0 commit comments

Comments
 (0)