Skip to content

Commit b2acd72

Browse files
authored
[Wf-Diagnostics] Include all failure related rootcauses in rc handling within daignostics (#6504)
1 parent 9432f48 commit b2acd72

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

service/worker/diagnostics/invariant/interface.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,9 @@ const (
4747
RootCauseTypePollersStatus RootCause = "There are pollers for the tasklist. Check backlog status"
4848
RootCauseTypeHeartBeatingNotEnabled RootCause = "HeartBeating not enabled for activity"
4949
RootCauseTypeHeartBeatingEnabledMissingHeartbeat RootCause = "HeartBeating enabled for activity but timed out due to missing heartbeat"
50-
RootCauseTypeServiceSideIssue RootCause = "There is an issue in the worker service that is causing this failure. Check identity for service logs"
51-
RootCauseTypeServiceSidePanic RootCause = "There is a panic in the activity/workflow that is causing this failure"
52-
RootCauseTypeServiceSideCustomError RootCause = "This is a customised error returned by the activity/workflow"
50+
RootCauseTypeServiceSideIssue RootCause = "There is an issue in the worker service that is causing a failure. Check identity for service logs"
51+
RootCauseTypeServiceSidePanic RootCause = "There is a panic in the activity/workflow that is causing a failure"
52+
RootCauseTypeServiceSideCustomError RootCause = "Customised error returned by the activity/workflow"
5353
)
5454

5555
func (r RootCause) String() string {

service/worker/diagnostics/workflow.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ func retrieveFailureIssues(issues []invariant.InvariantCheckResult) ([]*failures
269269
func retrieveFailureRootCause(rootCause []invariant.InvariantRootCauseResult) []string {
270270
result := make([]string, 0)
271271
for _, rc := range rootCause {
272-
if rc.RootCause == invariant.RootCauseTypeServiceSideIssue {
272+
if rc.RootCause == invariant.RootCauseTypeServiceSideIssue || rc.RootCause == invariant.RootCauseTypeServiceSidePanic || rc.RootCause == invariant.RootCauseTypeServiceSideCustomError {
273273
result = append(result, rc.RootCause.String())
274274
}
275275
}

0 commit comments

Comments
 (0)