Bypass failover drills for active-active domains (#7191)

Author: c-warren

service/worker/failovermanager/workflow.go

@@ -381,6 +381,14 @@ func shouldFailover(domain *types.DescribeDomainResponse, sourceCluster string)
 	if !domain.GetIsGlobalDomain() {
 		return false
 	}
+
+	// TODO(active-active): Remove this check once failover drills are supported for
+	// active-active workflows
+	if domain.ReplicationConfiguration.ActiveClusters != nil &&
+		len(domain.ReplicationConfiguration.ActiveClusters.ActiveClustersByRegion) > 0 {
+		return false
+	}
+
 	currentActiveCluster := domain.ReplicationConfiguration.GetActiveClusterName()
 	isDomainTarget := currentActiveCluster == sourceCluster
 	return isDomainTarget && isDomainFailoverManagedByCadence(domain)

service/worker/failovermanager/workflow_test.go

@@ -320,6 +320,48 @@ func (s *failoverWorkflowTestSuite) TestShouldFailover() {
 			sourceCluster: "c2",
 			expected:      true,
 		},
+		{
+			domain: &types.DescribeDomainResponse{
+				IsGlobalDomain: true,
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c2",
+					Clusters:          clusters,
+					ActiveClusters: &types.ActiveClusters{
+						ActiveClustersByRegion: map[string]types.ActiveClusterInfo{
+							"c1": {
+								ActiveClusterName: "c1",
+							},
+						},
+					},
+				},
+				DomainInfo: &types.DomainInfo{
+					Data: map[string]string{
+						constants.DomainDataKeyForManagedFailover: "true",
+					},
+				},
+			},
+			sourceCluster: "c2",
+			expected:      false,
+		},
+		{
+			domain: &types.DescribeDomainResponse{
+				IsGlobalDomain: true,
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c2",
+					Clusters:          clusters,
+					ActiveClusters: &types.ActiveClusters{
+						ActiveClustersByRegion: map[string]types.ActiveClusterInfo{},
+					},
+				},
+				DomainInfo: &types.DomainInfo{
+					Data: map[string]string{
+						constants.DomainDataKeyForManagedFailover: "true",
+					},
+				},
+			},
+			sourceCluster: "c2",
+			expected:      true,
+		},
 	}
 	for _, t := range tests {
 		s.Equal(t.expected, shouldFailover(t.domain, t.sourceCluster))
@@ -410,6 +452,122 @@ func (s *failoverWorkflowTestSuite) TestGetDomainsActivity_WithTargetDomains() {
 	s.Equal([]string{"d1"}, result) // d3 filtered out because not managed
 }
 
+func (s *failoverWorkflowTestSuite) TestGetDomainsActivity_FiltersActiveActiveDomains() {
+	env, mockResource := s.prepareTestActivityEnv()
+
+	domains := &types.ListDomainsResponse{
+		Domains: []*types.DescribeDomainResponse{
+			{
+				DomainInfo: &types.DomainInfo{
+					Name: "regular-domain",
+					Data: map[string]string{constants.DomainDataKeyForManagedFailover: "true"},
+				},
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c1",
+					Clusters:          clusters,
+				},
+				IsGlobalDomain: true,
+			},
+			{
+				DomainInfo: &types.DomainInfo{
+					Name: "active-active-domain",
+					Data: map[string]string{constants.DomainDataKeyForManagedFailover: "true"},
+				},
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c1",
+					Clusters:          clusters,
+					ActiveClusters: &types.ActiveClusters{
+						ActiveClustersByRegion: map[string]types.ActiveClusterInfo{
+							"region1": {
+								ActiveClusterName: "c1",
+							},
+						},
+					},
+				},
+				IsGlobalDomain: true,
+			},
+			{
+				DomainInfo: &types.DomainInfo{
+					Name: "empty-active-clusters-domain",
+					Data: map[string]string{constants.DomainDataKeyForManagedFailover: "true"},
+				},
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c1",
+					Clusters:          clusters,
+					ActiveClusters: &types.ActiveClusters{
+						ActiveClustersByRegion: map[string]types.ActiveClusterInfo{},
+					},
+				},
+				IsGlobalDomain: true,
+			},
+		},
+	}
+	mockResource.FrontendClient.EXPECT().ListDomains(gomock.Any(), gomock.Any()).Return(domains, nil)
+
+	params := &GetDomainsActivityParams{
+		TargetCluster: "c2",
+		SourceCluster: "c1",
+	}
+	actResult, err := env.ExecuteActivity(getDomainsActivityName, params)
+	s.NoError(err)
+	var result []string
+	s.NoError(actResult.Get(&result))
+	s.Equal([]string{"regular-domain", "empty-active-clusters-domain"}, result)
+}
+
+func (s *failoverWorkflowTestSuite) TestGetDomainsActivity_WithActiveActiveTargetDomains() {
+	env, mockResource := s.prepareTestActivityEnv()
+
+	domains := &types.ListDomainsResponse{
+		Domains: []*types.DescribeDomainResponse{
+			{
+				DomainInfo: &types.DomainInfo{
+					Name: "regular-domain",
+					Data: map[string]string{constants.DomainDataKeyForManagedFailover: "true"},
+				},
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c1",
+					Clusters:          clusters,
+				},
+				IsGlobalDomain: true,
+			},
+			{
+				DomainInfo: &types.DomainInfo{
+					Name: "active-active-domain",
+					Data: map[string]string{constants.DomainDataKeyForManagedFailover: "true"},
+				},
+				ReplicationConfiguration: &types.DomainReplicationConfiguration{
+					ActiveClusterName: "c1",
+					Clusters:          clusters,
+					ActiveClusters: &types.ActiveClusters{
+						ActiveClustersByRegion: map[string]types.ActiveClusterInfo{
+							"region1": {
+								ActiveClusterName: "c1",
+							},
+							"region2": {
+								ActiveClusterName: "c2",
+							},
+						},
+					},
+				},
+				IsGlobalDomain: true,
+			},
+		},
+	}
+	mockResource.FrontendClient.EXPECT().ListDomains(gomock.Any(), gomock.Any()).Return(domains, nil)
+
+	params := &GetDomainsActivityParams{
+		TargetCluster: "c2",
+		SourceCluster: "c1",
+		Domains:       []string{"regular-domain", "active-active-domain"},
+	}
+	actResult, err := env.ExecuteActivity(getDomainsActivityName, params)
+	s.NoError(err)
+	var result []string
+	s.NoError(actResult.Get(&result))
+	s.Equal([]string{"regular-domain"}, result)
+}
+
 func (s *failoverWorkflowTestSuite) TestFailoverActivity_ForceFailover_Success() {
 	env, mockResource := s.prepareTestActivityEnv()