childWorkflow的执行过程中遇到了error：missing or negative ScheduleToStartTimeoutSeconds

[Johnite]

我根据demo，尝试使用了一下childworkflow，因为我的parent workflow中有个while循环，想每个循环里面创建一个childWorkflow，不过，不太确定这样使用是否有问题。code如下：

func SerialRawSqlWorkflow(ctx workflow.Context, params *entity.TaskObjectParams) error {
	logger := workflow.GetLogger(ctx)
	ao := workflow.ActivityOptions{
		ScheduleToStartTimeout: entity.ActivityScheduleToStartTimeout,
		StartToCloseTimeout:    entity.ActivityStartToCloseTimeout,
		ScheduleToCloseTimeout: entity.ActivityStartToCloseTimeout,
	}
	ctx = workflow.WithActivityOptions(ctx, ao)
	//执行查询数据库，获取结果
	newSqlMap, _, err := CreateExpandNewSql(context.Background(), params.SqlStr)
	if err != nil {
		return err
	}
	for cityId, sqlMap := range newSqlMap {
		sql := strings.TrimSpace(sqlMap["newSql"].(string))
		if sql == "" {
			logger.Warn("SerialRawSqlWorkflow sql is null", zap.Error(err), zap.Any("cityId", cityId))
			continue
		}
		execution := workflow.GetInfo(ctx).WorkflowExecution
		childID := fmt.Sprintf("child_workflow:%v", execution.RunID)
		cwo := workflow.ChildWorkflowOptions{
			// Do not specify WorkflowID if you want cadence to generate a unique ID for child execution
			WorkflowID:                   childID,
			ExecutionStartToCloseTimeout: time.Minute,
		}
		ctx = workflow.WithChildOptions(ctx, cwo)
		var result string
		err := workflow.ExecuteChildWorkflow(ctx, SerialRawSqlChildWorkflow, sql,cityId, params).Get(ctx, &result)
		if err != nil {
			logger.Error("Parent execution received child execution failure.", zap.Error(err))
			return err
		}
	}
	logger.Info("SerialRawSqlWorkflow execute " + strconv.Itoa(len(newSqlMap)) + " sql success")
	return nil
}

func SerialRawSqlChildWorkflow (ctx workflow.Context, sql, cityId string, params *entity.TaskObjectParams) (string, error) {
	var err error
	logger := workflow.GetLogger(ctx)
	switch params.Switch {
	case 1:
		var featureValue []*entity.DeliveryFeatures
		err = workflow.ExecuteActivity(ctx, GetFeatureValueBySqlActivity, sql, params).Get(ctx, &featureValue)
		if err != nil {
			logger.Error("SerialRawSqlWorkflow GetFeatureValueByRawSqlActivity execute failed", zap.Error(err), zap.Any("cityId", cityId))
		}
		logger.Info("SerialRawSqlWorkflow GetFeatureValueBySqlActivity execute success", zap.Any("sql", params.SqlStr), zap.Any("result length", len(featureValue)))
		err = workflow.ExecuteActivity(ctx, SendJsonToMQActivity, featureValue, params).Get(ctx, nil)
		if err != nil {
			logger.Error("SerialRawSqlWorkflow SendJsonToMQActivity execute failed", zap.Error(err), zap.Any("cityId", cityId))
		}
		logger.Info("SerialRawSqlWorkflow execute success", zap.Any("sql", sql), zap.Any("query result length:", len(featureValue)))
	case 2:
		var featureValue []*entity.FeatureValueObjectV1
		err = workflow.ExecuteActivity(ctx, GetFeatureValueBySqlV1Activity, sql, params).Get(ctx, &featureValue)
		if err != nil {
			logger.Error("SerialRawSqlWorkflow GetFeatureValueBySqlV1Activity execute failed", zap.Error(err), zap.Any("cityId", cityId))
		}
		logger.Info("SerialRawSqlWorkflow GetFeatureValueBySqlActivity execute success", zap.Any("sql", params.SqlStr), zap.Any("result length", len(featureValue)))
		err = workflow.ExecuteActivity(ctx, SendJsonToMQV1Activity, featureValue, params).Get(ctx, nil)
		if err != nil {
			logger.Error("SerialRawSqlWorkflow SendJsonToMQV1Activity execute failed", zap.Error(err), zap.Any("cityId", cityId))
		}
		logger.Info("SerialRawSqlWorkflow execute success", zap.Any("sql", sql), zap.Any("query result length:", len(featureValue)))
	}
	//return "", workflow.NewContinueAsNewError(ctx, SerialRawSqlChildWorkflow, sql, cityId, params)
	return "", err
}

但是我遇到了以下错误：
2021-08-17T11:12:08.783+0800 error SerialRawSqlWorkflow SendJsonToMQV1Activity execute failed {"Domain": "cron-domain", "TaskList": "24", "WorkerID": "13519@yaoxiuqiang@24", "WorkflowType": "cadence-worker/logic.SerialRawSqlChildWorkflow", "WorkflowID": "child_workflow:eeade29b-7272-43f0-bbf7-2cda811c0a72", "RunID": "f0fa4613-2921-4fda-aca6-ef784e4610cb", "error": "missing or negative ScheduleToStartTimeoutSeconds", "cityId": "55000450"}

[longquanzheng]

The error is obvious as it says. You need to set ActivityOptions for executing activities in ChildWF:

See sample: https://github.com/uber-common/cadence-samples/blob/689b4234307e51f85e1c6424110506308e57f032/cmd/samples/recipes/helloworld/helloworld_workflow.go#L23

[longquanzheng]

Did you manage to address the problems?

[Johnite]

是的，确实在childworkflow中的activity没有添加activityoptions，增加之后问题就解决了。