primary key on domain_metadata table

[raunakkumar]

hi,
We are planning to use cadence as sql/postgres database for our implementation and require to define a primary key for all the tables. We noticed domain_metadata is missing a primary key. Can notification_version be a primary key for the table?

cadence=# \d domain_metadata;
                 Table "public.domain_metadata"
        Column        |  Type  | Collation | Nullable | Default 
----------------------+--------+-----------+----------+---------
 notification_version | bigint |           | not null | 

[longquanzheng]

Yes that would work. However usually ppl would expect a immutable pk. You can add a new column as PK, eg id.

[raunakkumar]

Thanks @longquanzheng. That was my next suggestion. Hope that wouldn't break anything for cadence.

[longquanzheng]

No it won’t. You can also submit a PR to change for every one. I will review it for you