Merge pull request kubernetes-sigs#9819 from chrischdi/pr-test-md-scale-fix

k8s-ci-robot · web-flow · commit 309e34624533 · 2023-12-07T08:14:12.000+01:00
🐛 test: wait for topology to get rolled out before continuing with scaling checks
diff --git a/test/framework/machinedeployment_helpers.go b/test/framework/machinedeployment_helpers.go
@@ -582,7 +582,7 @@ func ScaleAndWaitMachineDeploymentTopology(ctx context.Context, input ScaleAndWa
 			return -1, errors.New("Machine count does not match existing nodes count")
 		}
 		return nodeRefCount, nil
-	}, input.WaitForMachineDeployments...).Should(Equal(int(*md.Spec.Replicas)), "Timed out waiting for Machine Deployment %s to have %d replicas", klog.KObj(&md), *md.Spec.Replicas)
+	}, input.WaitForMachineDeployments...).Should(Equal(int(input.Replicas)), "Timed out waiting for Machine Deployment %s to have %d replicas", klog.KObj(&md), input.Replicas)
 }
 
 type AssertMachineDeploymentReplicasInput struct {

Original file line number	Diff line number	Diff line change
`@@ -582,7 +582,7 @@ func ScaleAndWaitMachineDeploymentTopology(ctx context.Context, input ScaleAndWa`
`582`	`582`	`return -1, errors.New("Machine count does not match existing nodes count")`
`583`	`583`	`}`
`584`	`584`	`return nodeRefCount, nil`
`585`		`- }, input.WaitForMachineDeployments...).Should(Equal(int(md.Spec.Replicas)), "Timed out waiting for Machine Deployment %s to have %d replicas", klog.KObj(&md), md.Spec.Replicas)`
	`585`	`+ }, input.WaitForMachineDeployments...).Should(Equal(int(input.Replicas)), "Timed out waiting for Machine Deployment %s to have %d replicas", klog.KObj(&md), input.Replicas)`
`586`	`586`	`}`
`587`	`587`
`588`	`588`	`type AssertMachineDeploymentReplicasInput struct {`