Skip to content

Commit 9f7c446

Browse files
authored
Merge pull request kubernetes-sigs#9723 from sbueringer/pr-mp-timeout
🌱 Add MP timeouts to cluster upgrade tests
2 parents a3fd482 + 79904e4 commit 9f7c446

File tree

2 files changed

+24
-22
lines changed

2 files changed

+24
-22
lines changed

test/e2e/cluster_upgrade.go

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -155,18 +155,19 @@ func ClusterUpgradeConformanceSpec(ctx context.Context, inputGetter func() Clust
155155
// Cluster is using ClusterClass, upgrade via topology.
156156
By("Upgrading the Cluster topology")
157157
framework.UpgradeClusterTopologyAndWaitForUpgrade(ctx, framework.UpgradeClusterTopologyAndWaitForUpgradeInput{
158-
ClusterProxy: input.BootstrapClusterProxy,
159-
Cluster: clusterResources.Cluster,
160-
ControlPlane: clusterResources.ControlPlane,
161-
EtcdImageTag: input.E2EConfig.GetVariable(EtcdVersionUpgradeTo),
162-
DNSImageTag: input.E2EConfig.GetVariable(CoreDNSVersionUpgradeTo),
163-
MachineDeployments: clusterResources.MachineDeployments,
164-
MachinePools: clusterResources.MachinePools,
165-
KubernetesUpgradeVersion: input.E2EConfig.GetVariable(KubernetesVersionUpgradeTo),
166-
WaitForMachinesToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
167-
WaitForKubeProxyUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
168-
WaitForDNSUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
169-
WaitForEtcdUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
158+
ClusterProxy: input.BootstrapClusterProxy,
159+
Cluster: clusterResources.Cluster,
160+
ControlPlane: clusterResources.ControlPlane,
161+
EtcdImageTag: input.E2EConfig.GetVariable(EtcdVersionUpgradeTo),
162+
DNSImageTag: input.E2EConfig.GetVariable(CoreDNSVersionUpgradeTo),
163+
MachineDeployments: clusterResources.MachineDeployments,
164+
MachinePools: clusterResources.MachinePools,
165+
KubernetesUpgradeVersion: input.E2EConfig.GetVariable(KubernetesVersionUpgradeTo),
166+
WaitForMachinesToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
167+
WaitForMachinePoolToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-pool-upgrade"),
168+
WaitForKubeProxyUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
169+
WaitForDNSUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
170+
WaitForEtcdUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
170171
})
171172
} else {
172173
// Cluster is not using ClusterClass, upgrade via individual resources.

test/e2e/cluster_upgrade_runtimesdk.go

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -217,16 +217,17 @@ func clusterUpgradeWithRuntimeSDKSpec(ctx context.Context, inputGetter func() cl
217217
// Upgrade the Cluster topology to run through an entire cluster lifecycle to test the lifecycle hooks.
218218
By("Upgrading the Cluster topology; creation waits for BeforeClusterUpgradeHook and AfterControlPlaneUpgradeHook to gate the operation")
219219
framework.UpgradeClusterTopologyAndWaitForUpgrade(ctx, framework.UpgradeClusterTopologyAndWaitForUpgradeInput{
220-
ClusterProxy: input.BootstrapClusterProxy,
221-
Cluster: clusterResources.Cluster,
222-
ControlPlane: clusterResources.ControlPlane,
223-
MachineDeployments: clusterResources.MachineDeployments,
224-
MachinePools: clusterResources.MachinePools,
225-
KubernetesUpgradeVersion: input.E2EConfig.GetVariable(KubernetesVersionUpgradeTo),
226-
WaitForMachinesToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
227-
WaitForKubeProxyUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
228-
WaitForDNSUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
229-
WaitForEtcdUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
220+
ClusterProxy: input.BootstrapClusterProxy,
221+
Cluster: clusterResources.Cluster,
222+
ControlPlane: clusterResources.ControlPlane,
223+
MachineDeployments: clusterResources.MachineDeployments,
224+
MachinePools: clusterResources.MachinePools,
225+
KubernetesUpgradeVersion: input.E2EConfig.GetVariable(KubernetesVersionUpgradeTo),
226+
WaitForMachinesToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
227+
WaitForMachinePoolToBeUpgraded: input.E2EConfig.GetIntervals(specName, "wait-machine-pool-upgrade"),
228+
WaitForKubeProxyUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
229+
WaitForDNSUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
230+
WaitForEtcdUpgrade: input.E2EConfig.GetIntervals(specName, "wait-machine-upgrade"),
230231
PreWaitForControlPlaneToBeUpgraded: func() {
231232
beforeClusterUpgradeTestHandler(ctx,
232233
input.BootstrapClusterProxy.GetClient(),

0 commit comments

Comments
 (0)