test/framework: scale up should use allocatable memory

vincepri · vincepri · commit a1f370e9ae63 · 2024-08-02T07:46:26.000-07:00
Capacity has the entire memory pool that the node carries, while
allocatable is the true memory available for scheduling purposes.

Signed-off-by: Vince Prignano &lt;vince@prigna.com&gt;
diff --git a/test/framework/autoscaler_helpers.go b/test/framework/autoscaler_helpers.go
@@ -158,7 +158,7 @@ func AddScaleUpDeploymentAndWait(ctx context.Context, input AddScaleUpDeployment
 		if _, ok := n.Labels[nodeRoleOldControlPlane]; ok {
 			continue
 		}
-		memory = n.Status.Capacity.Memory() // Assume that all nodes have the same memory.
+		memory = n.Status.Allocatable.Memory() // Assume that all nodes have the same memory.
 		workers++
 	}
 	Expect(memory).ToNot(BeNil(), "failed to get memory for the worker node")

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ func AddScaleUpDeploymentAndWait(ctx context.Context, input AddScaleUpDeployment`
`158`	`158`	`if _, ok := n.Labels[nodeRoleOldControlPlane]; ok {`
`159`	`159`	`continue`
`160`	`160`	`}`
`161`		`- memory = n.Status.Capacity.Memory() // Assume that all nodes have the same memory.`
	`161`	`+ memory = n.Status.Allocatable.Memory() // Assume that all nodes have the same memory.`
`162`	`162`	`workers++`
`163`	`163`	`}`
`164`	`164`	`Expect(memory).ToNot(BeNil(), "failed to get memory for the worker node")`