Fix CI

Author: fabriziopandini

util/conditions/getter.go

@@ -117,7 +117,7 @@ func GetLastTransitionTime(from Getter, t clusterv1.ConditionType) *metav1.Time
 
 // summary returns a Ready condition with the summary of all the conditions existing
 // on an object. If the object does not have other conditions, no summary condition is generated.
-// NOTE: The resulting Ready condition will have positive polarity; the we are starting from might have positive or negative polarity.
+// NOTE: The resulting Ready condition will have positive polarity; the conditions we are starting from might have positive or negative polarity.
 func summary(from Getter, options ...MergeOption) *clusterv1.Condition {
 	conditions := from.GetConditions()
 

util/conditions/getter_test.go

@@ -155,7 +155,6 @@ func TestSummary(t *testing.T) {
 	baz := FalseCondition("baz", "reason falseInfo2", clusterv1.ConditionSeverityInfo, "message falseInfo2")
 	negativeFoo := PositiveFalseCondition("negative-foo")
 	negativeBar := NegativeTrueCondition("negative-bar", "reason negative-falseInfo1", clusterv1.ConditionSeverityInfo, "message negative-falseInfo1")
-	// negativeBaz := NegativeTrueCondition("negative-baz", "reason negative-falseInfo2", clusterv1.ConditionSeverityInfo, "message negative-falseInfo2")
 	existingReady := FalseCondition(clusterv1.ReadyCondition, "reason falseError1", clusterv1.ConditionSeverityError, "message falseError1") // NB. existing ready has higher priority than other conditions
 
 	tests := []struct {

util/conditions/merge.go

@@ -27,7 +27,10 @@ import (
 type conditionPolarity string
 
 const (
+	// PositivePolarity describe a condition with positive polarity (Status=True good).
 	PositivePolarity conditionPolarity = "Positive"
+
+	// NegativePolarity describe a condition with negative polarity (Status=False good).
 	NegativePolarity conditionPolarity = "Negative"
 )